135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update NodeVendor.pm (#427)

Browse Source 
It would seem like we'd want for this to be distinct mac addresses here right? Otherwise you'd could get duplicate counters. In our environment where things move around this makes for repeat lines in the nodes table. To get a true inventory count I'd think this should only count unique macs. Apologies if this is NOT the desired output for this module.
This commit is contained in:
slofunk
2018-10-19 09:42:37 -04:00
committed by Oliver Gorwits
parent 75c26717f0
commit 00ac3cff4a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/App/Netdisco/Web/Plugin/Report/NodeVendor.pm
View File

@@ -102,7 +102,7 @@ get '/ajax/content/report/nodevendor' => require_login sub {
$rs = $rs->search( $rs = $rs->search(
{ }, { },
{ join => 'oui', { join => 'oui',
select => [ 'oui.abbrev', { count => 'me.mac' } ], select => [ 'oui.abbrev', { count => {distinct 'me.mac'}} ],
as => [qw/ vendor count /], as => [qw/ vendor count /],
group_by => [qw/ oui.abbrev /] group_by => [qw/ oui.abbrev /]
} }