From 08969583cbe68658ce73bdbd8027ce2589c4fccc Mon Sep 17 00:00:00 2001 From: Oliver Gorwits Date: Wed, 30 Oct 2019 19:50:04 +0000 Subject: [PATCH] change double negative logic --- lib/App/Netdisco/Util/Device.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/App/Netdisco/Util/Device.pm b/lib/App/Netdisco/Util/Device.pm index 1e306219..c156b05a 100644 --- a/lib/App/Netdisco/Util/Device.pm +++ b/lib/App/Netdisco/Util/Device.pm @@ -237,7 +237,7 @@ sub is_arpnipable { my $device = get_device($ip) or return 0; return _bail_msg("is_arpnipable: $device has no layer 3 capability") - unless ($device->has_layer(3) || !$device->in_storage()); + if ($device->in_storage() and not $device->has_layer(3)); return _bail_msg("is_arpnipable: $device matched arpnip_no") if check_acl_no($device, 'arpnip_no'); @@ -288,8 +288,9 @@ Returns false if the host is not permitted to macsuck the target device. sub is_macsuckable { my $ip = shift; my $device = get_device($ip) or return 0; + return _bail_msg("is_macsuckable: $device has no layer 2 capability") - unless ($device->has_layer(2) || !$device->in_storage()); + if ($device->in_storage() and not $device->has_layer(2)); return _bail_msg("is_macsuckable: $device matched macsuck_no") if check_acl_no($device, 'macsuck_no');