From 0d3a066c38c4b1ab01c4969ee708da6326bb55eb Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Tue, 12 Jul 2022 09:15:04 +0100
Subject: [PATCH] better check for missing -d on addpseudodevice

---
 lib/App/Netdisco/Worker/Plugin/AddPseudoDevice.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/App/Netdisco/Worker/Plugin/AddPseudoDevice.pm b/lib/App/Netdisco/Worker/Plugin/AddPseudoDevice.pm
index 43fa7712..570f81c4 100644
--- a/lib/App/Netdisco/Worker/Plugin/AddPseudoDevice.pm
+++ b/lib/App/Netdisco/Worker/Plugin/AddPseudoDevice.pm
@@ -11,10 +11,13 @@ use NetAddr::IP::Lite ':lower';
 
 register_worker({ phase => 'check' }, sub {
     my ($job, $workerconf) = @_;
-    my $devip = $job->device->ip;
     my $name  = $job->extra;
     my $ports = $job->port;
 
+    return Status->error('Missing or invalid device IP (-d).')
+      unless $job->device;
+    my $devip = $job->device->ip;
+
     return Status->error('Missing or invalid device name (-e).')
       unless $name
       and $name =~ m/^[[:print:]]+$/