From 1e42dce0f5e44e542c6d3c5e8ec7db9dc62e58a9 Mon Sep 17 00:00:00 2001 From: Oliver Gorwits Date: Fri, 5 Jan 2018 17:20:16 +0000 Subject: [PATCH] better comment on job deduplication --- lib/App/Netdisco/JobQueue/PostgreSQL.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/App/Netdisco/JobQueue/PostgreSQL.pm b/lib/App/Netdisco/JobQueue/PostgreSQL.pm index 53ead077..14b31cde 100644 --- a/lib/App/Netdisco/JobQueue/PostgreSQL.pm +++ b/lib/App/Netdisco/JobQueue/PostgreSQL.pm @@ -129,6 +129,11 @@ sub jq_getsome { # remove any duplicate jobs, incuding possibly this job if there # is already an equivalent job running + # note that the self-removal of a job has an unhelpful log: it is + # reported as a duplicate of itself! however what's happening is that + # netdisco has seen another running job with same params (but the query + # cannot see that ID to use it in the message). + my %job_properties = ( action => $job->action, port => $job->port,