135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor to remove second loop

Browse Source
This commit is contained in:
Oliver Gorwits
2017-09-12 08:12:12 +01:00
parent 64a9491115
commit 1fdb086183
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/App/Netdisco/Worker/Runner.pm
View File

@@ -63,19 +63,12 @@ sub run {
my @phase_hooks = grep { m/^nd2_${action}_/ } my @phase_hooks = grep { m/^nd2_${action}_/ }
@{ (setting('_nd2worker_hooks') || []) }; @{ (setting('_nd2worker_hooks') || []) };
foreach my $stage (qw/init first second/) { foreach my $phase ("nd2_${action}", @phase_hooks) {
my $hookname = "nd2_${action}_${stage}";
next unless scalar @{ $store->get_hooks_for($hookname) };
$self->run_workers($hookname);
last if $stage eq 'init' and $self->jobstat->not_ok;
}
foreach my $phase (@phase_hooks) {
foreach my $stage (qw/init first second/) { foreach my $stage (qw/init first second/) {
my $hookname = "${phase}_${stage}"; my $hookname = "${phase}_${stage}";
next unless scalar @{ $store->get_hooks_for($hookname) }; next unless scalar @{ $store->get_hooks_for($hookname) };
$self->run_workers($hookname); $self->run_workers($hookname);
last if $stage eq 'init' and $self->jobstat->not_ok; return if $stage eq 'init' and $self->jobstat->not_ok;
} }
} }
} }