135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

multi worker actions need not return done from all workers

Browse Source
This commit is contained in:
Oliver Gorwits
2017-10-07 09:35:14 +01:00
parent ee38bae48a
commit 256c10bae5
13 changed files with 32 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/App/Netdisco/Worker/Plugin/Discover/CanonicalIP.pm
View File

@@ -59,8 +59,7 @@ register_worker({ stage => 'main', driver => 'snmp' }, sub {
} # ALIAS
}
return Status->done("Ended discover for $device")
if $new_ip eq $old_ip;
return true if $new_ip eq $old_ip;
schema('netdisco')->txn_do(sub {
# delete target device with the same vendor and serial number
@@ -72,11 +71,9 @@ register_worker({ stage => 'main', driver => 'snmp' }, sub {
$device->renumber($new_ip)
or die "cannot renumber to: $new_ip"; # rollback
debug sprintf ' [%s] device - changed IP to %s (%s)',
$old_ip, $device->ip, ($device->dns || '');
return Status->noop(sprintf ' [%s] device - changed IP to %s (%s)',
$old_ip, $device->ip, ($device->dns || ''));
});
return Status->done("Ended discover for $device");
});
true;