#936 user auth method should be drop-down

lib/App/Netdisco/Web/Plugin/AdminTask/Users.pm

@@ -40,9 +40,17 @@ ajax '/ajax/control/admin/users/add' => require_role setting('defanged_admin') =
           username => param('username'),
           password => _make_password(param('password')),
           fullname => param('fullname'),
-          ldap => (param('ldap') ? \'true' : \'false'),
+
-          radius => (param('radius') ? \'true' : \'false'),
+          (param('auth_method') ? (
-          tacacs => (param('tacacs') ? \'true' : \'false'),
+            (ldap => (param('auth_method') eq 'ldap' ? \'true' : \'false')),
+            (radius => (param('auth_method') eq 'radius' ? \'true' : \'false')),
+            (tacacs => (param('auth_method') eq 'tacacs' ? \'true' : \'false')),
+          ) : (
+            ldap => \'false',
+            radius => \'false',
+            tacacs => \'false',
+          )),
+
           port_control => (param('port_control') ? \'true' : \'false'),
           admin => (param('admin') ? \'true' : \'false'),
           note => param('note'),
@@ -72,9 +80,17 @@ ajax '/ajax/control/admin/users/update' => require_role setting('defanged_admin'
           ? (password => _make_password(param('password')))
           : ()),
         fullname => param('fullname'),
-        ldap => (param('ldap') ? \'true' : \'false'),
+
-        radius => (param('radius') ? \'true' : \'false'),
+        (param('auth_method') ? (
-        tacacs => (param('tacacs') ? \'true' : \'false'),
+          (ldap => (param('auth_method') eq 'ldap' ? \'true' : \'false')),
+          (radius => (param('auth_method') eq 'radius' ? \'true' : \'false')),
+          (tacacs => (param('auth_method') eq 'tacacs' ? \'true' : \'false')),
+        ) : (
+          ldap => \'false',
+          radius => \'false',
+          tacacs => \'false',
+        )),
+
         port_control => (param('port_control') ? \'true' : \'false'),
         admin => (param('admin') ? \'true' : \'false'),
         note => param('note'),

share/views/ajax/admintask/users.tt

@@ -4,9 +4,7 @@
       <th class="nd_center-cell">Full Name</th>
       <th class="nd_center-cell">Username</th>
       <th class="nd_center-cell">Password</th>
-      <th class="nd_center-cell">LDAP Auth</th>
+      <th class="nd_center-cell">Auth Method</th>
-      <th class="nd_center-cell">RADIUS Auth</th>
-      <th class="nd_center-cell">TACACS+ Auth</th>
       <th class="nd_center-cell">Port Control</th>
       <th class="nd_center-cell">Administrator</th>
       <th class="nd_center-cell">Created</th>
@@ -20,9 +18,16 @@
       <td class="nd_center-cell"><input data-form="add" name="fullname" type="text"></td>
       <td class="nd_center-cell"><input class="span2" data-form="add" name="username" type="text"></td>
       <td class="nd_center-cell"><input class="span2" data-form="add" name="password" type="password"></td>
-      <td class="nd_center-cell"><input data-form="add" type="checkbox" name="ldap"></td>
+      <td class="nd_center-cell">
-      <td class="nd_center-cell"><input data-form="add" type="checkbox" name="radius"></td>
+        <div class="form-group">
-      <td class="nd_center-cell"><input data-form="add" type="checkbox" name="tacacs"></td>
+          <select class="span2 form-control" data-form="add" name="auth_method">
+            <option value="" selected>Netdisco Password</option>
+            <option value="ldap">LDAP</option>
+            <option value="radius">RADIUS</option>
+            <option value="tacacs">TACACS</option>
+          </select>
+        </div>
+      </td>
       <td class="nd_center-cell"><input data-form="add" type="checkbox" name="port_control"></td>
       <td class="nd_center-cell"><input data-form="add" type="checkbox" name="admin"></td>
       <td class="nd_center-cell"></td>
@@ -47,13 +52,14 @@
         <input class="span2" data-form="update" name="password" type="password" value="********">
       </td>
       <td class="nd_center-cell">
-        <input data-form="update" name="ldap" type="checkbox" [% ' checked="checked"' IF row.ldap %]>
+        <div class="form-group">
-      </td>
+          <select class="span2 form-control" data-form="update" name="auth_method">
-      <td class="nd_center-cell">
+            <option value="">Netdisco Password</option>
-        <input data-form="update" name="radius" type="checkbox" [% ' checked="checked"' IF row.radius %]>
+            <option[% ' selected' IF row.ldap %] value="ldap">LDAP</option>
-      </td>
+            <option[% ' selected' IF row.radius %] value="radius">RADIUS</option>
-      <td class="nd_center-cell">
+            <option[% ' selected' IF row.tacacs %] value="tacacs">TACACS</option>
-        <input data-form="update" name="tacacs" type="checkbox" [% ' checked="checked"' IF row.tacacs %]>
+          </select>
+        </div>
       </td>
       <td class="nd_center-cell">
         <input data-form="update" name="port_control" type="checkbox" [% ' checked="checked"' IF row.port_control %]>

share/views/js/admintask.js

@@ -141,7 +141,7 @@
         ,async: true
         ,dataType: 'html'
         ,url: uri_base + '/ajax/control/admin/' + tab + '/' + mode
-        ,data: $(this).closest('tr').find('input[data-form="' + mode + '"]').serializeArray()
+        ,data: $(this).closest('tr').find('input[data-form="' + mode + '"],select[data-form="' + mode + '"]').serializeArray()
         ,beforeSend: function() {
           if (mode == 'add' || mode == 'delete') {
             $(target).html(