135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

introduce noop and refactor checks in all workers

Browse Source
This commit is contained in:
Oliver Gorwits
2017-10-06 07:15:59 +01:00
parent 98463c8cad
commit 3af13f0dfe
26 changed files with 172 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/App/Netdisco/Worker/Plugin/Location.pm
View File

@@ -7,9 +7,14 @@ use aliased 'App::Netdisco::Worker::Status';
use App::Netdisco::Transport::SNMP;
register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).')
unless defined (shift)->device;
return Status->done('Location is able to run');
});
register_worker({ stage => 'main' }, sub {
my ($job, $workerconf) = @_;
my ($device, $data) = map {$job->$_} qw/device extra/;
return Status->error('Missing device (-d).') if !defined $device;
# snmp connect using rw community
my $snmp = App::Netdisco::Transport::SNMP->writer_for($device)