135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

introduce noop and refactor checks in all workers

Browse Source
This commit is contained in:
Oliver Gorwits
2017-10-06 07:15:59 +01:00
parent 98463c8cad
commit 3af13f0dfe
26 changed files with 172 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/App/Netdisco/Worker/Plugin/Show.pm
View File

@@ -8,9 +8,14 @@ use Data::Printer ();
use App::Netdisco::Transport::SNMP;
register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).')
unless defined (shift)->device;
return Status->done('Show is able to run');
});
register_worker({ stage => 'main' }, sub {
my ($job, $workerconf) = @_;
my ($device, $port, $extra) = map {$job->$_} qw/device port extra/;
return Status->error('Missing device (-d).') if !defined $device;
$extra ||= 'interfaces'; my $class = undef;
($class, $extra) = split(/::([^:]+)$/, $extra);
@@ -26,7 +31,7 @@ register_worker({ stage => 'check' }, sub {
Data::Printer::p($i->$extra);
return Status->done(
sprintf "Showed %s response from %s.", $extra, $device->ip);
sprintf "Showed %s response from %s", $extra, $device->ip);
});
true;