From 3d1d20690536ef66ceaa30fc23b850057c764fce Mon Sep 17 00:00:00 2001 From: Oliver Gorwits Date: Sat, 1 Oct 2016 19:03:47 +0100 Subject: [PATCH] [#266] netdisco subnet utiiization report div by zero (V. Puchkov) --- Netdisco/Changes | 3 ++- .../lib/App/Netdisco/DB/Result/Virtual/SubnetUtilization.pm | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Netdisco/Changes b/Netdisco/Changes index 81431f4e..f6222763 100644 --- a/Netdisco/Changes +++ b/Netdisco/Changes @@ -15,12 +15,13 @@ * Mention netdisco-users mail list in docs (C. Goldsmith) * Avoid pathological delete mac for millions of nodes (S. Xu) * Documentation fixes (S. Elipot) - * [#265] Default sort for Nodes discovered through LLDP/CDP + * [#265] Default sort for Nodes discovered through LLDP/CDP (mzac) [BUG FIXES] * Improve security of REMOTE_USER handling (B. Marshall) * portcontrol and power jobs using device instance instead of IP address + * [#266] netdisco subnet utiiization report div by zero (V. Puchkov) 2.033006 - 2016-03-20 diff --git a/Netdisco/lib/App/Netdisco/DB/Result/Virtual/SubnetUtilization.pm b/Netdisco/lib/App/Netdisco/DB/Result/Virtual/SubnetUtilization.pm index 1ce4d9da..e3b67787 100644 --- a/Netdisco/lib/App/Netdisco/DB/Result/Virtual/SubnetUtilization.pm +++ b/Netdisco/lib/App/Netdisco/DB/Result/Virtual/SubnetUtilization.pm @@ -14,7 +14,7 @@ __PACKAGE__->result_source_instance->view_definition(<<'ENDSQL'); SELECT net as subnet, power(2, (32 - masklen(net))) as subnet_size, count(DISTINCT ip) as active, - round(100 * count(DISTINCT ip) / (power(2, (32 - masklen(net))) - 2)) as percent + round(100 * count(DISTINCT ip) / (power(2, (32 - masklen(net))))) as percent FROM ( SELECT DISTINCT net, ni.ip FROM subnets s1, node_ip ni