diff --git a/bin/netdisco-do b/bin/netdisco-do index f24da01f..34d6c16c 100755 --- a/bin/netdisco-do +++ b/bin/netdisco-do @@ -421,7 +421,7 @@ L trace enabled =back -In case of issues with the colored output, setting the environment variable +In case of issues with the colored output, setting the environment variable C can be used to suppress it. =cut diff --git a/lib/App/Netdisco/Backend/Job.pm b/lib/App/Netdisco/Backend/Job.pm index 75879326..bab5d036 100644 --- a/lib/App/Netdisco/Backend/Job.pm +++ b/lib/App/Netdisco/Backend/Job.pm @@ -94,7 +94,7 @@ sub best_status { my $cur_status = ''; foreach my $status (reverse @{ $job->_statuslist }) { - next if $status->phase + next if $status->phase and $status->phase !~ m/^(?:early|main|store|late)$/; if ($status->level >= $cur_level) { @@ -123,7 +123,7 @@ sub finalise_status { my $max_level = Status->error()->level; foreach my $status (reverse @{ $job->_statuslist }) { - next if $status->phase + next if $status->phase and $status->phase !~ m/^(?:check|early|main|store|late)$/; # done() from check phase should not be the action's done() diff --git a/lib/App/Netdisco/Util/DeviceAuth.pm b/lib/App/Netdisco/Util/DeviceAuth.pm index 80ed8d8a..034ab669 100644 --- a/lib/App/Netdisco/Util/DeviceAuth.pm +++ b/lib/App/Netdisco/Util/DeviceAuth.pm @@ -89,7 +89,7 @@ sub fixup_device_auth { push @new_stanzas, $stanza; } - # legacy config + # legacy config # note: read strings tried before write # note: read-write is no longer used for read operations diff --git a/lib/App/Netdisco/Util/SNMP.pm b/lib/App/Netdisco/Util/SNMP.pm index 26708726..efbb19ad 100644 --- a/lib/App/Netdisco/Util/SNMP.pm +++ b/lib/App/Netdisco/Util/SNMP.pm @@ -100,18 +100,18 @@ sub snmp_comm_reindex { } $prefix ||= 'vlan-'; - if ($vlan =~ /^[0-9]+$/i && $vlan) { + if ($vlan =~ /^[0-9]+$/i && $vlan) { debug sprintf '[%s] reindexing to "%s%s" (ver: %s, class: %s)', $device->ip, $prefix, $vlan, $ver, $snmp->class; $snmp->update(Context => ($prefix . $vlan)); - } elsif ($vlan =~ /^[a-z0-9]+$/i && $vlan) { + } elsif ($vlan =~ /^[a-z0-9]+$/i && $vlan) { debug sprintf '[%s] reindexing to "%s" (ver: %s, class: %s)', $device->ip, $vlan, $ver, $snmp->class; $snmp->update(Context => ($vlan)); - } else { + } else { debug sprintf '[%s] reindexing without context (ver: %s, class: %s)', $device->ip, $ver, $snmp->class; - $snmp->update(Context => ''); + $snmp->update(Context => ''); } } else { diff --git a/share/views/ajax/admintask/duplicatedevices.tt b/share/views/ajax/admintask/duplicatedevices.tt index ec654be6..71c71790 100644 --- a/share/views/ajax/admintask/duplicatedevices.tt +++ b/share/views/ajax/admintask/duplicatedevices.tt @@ -15,7 +15,7 @@ Delete - + [% SET count = 0 %] [% FOREACH row IN results %] [% SET count = count + 1 %] diff --git a/share/views/ajax/admintask/jobqueue.tt b/share/views/ajax/admintask/jobqueue.tt index 10ec7df6..cfcf7d52 100644 --- a/share/views/ajax/admintask/jobqueue.tt +++ b/share/views/ajax/admintask/jobqueue.tt @@ -16,7 +16,7 @@ Action - + [% FOREACH row IN results %] Action - + diff --git a/share/views/ajax/admintask/performance.tt b/share/views/ajax/admintask/performance.tt index 6b1d62f5..37484229 100644 --- a/share/views/ajax/admintask/performance.tt +++ b/share/views/ajax/admintask/performance.tt @@ -12,7 +12,7 @@ Time Elapsed - + [% WHILE (row = results.next) %] Action - + diff --git a/share/views/ajax/admintask/slowdevices.tt b/share/views/ajax/admintask/slowdevices.tt index f2c5ebe8..dfb84385 100644 --- a/share/views/ajax/admintask/slowdevices.tt +++ b/share/views/ajax/admintask/slowdevices.tt @@ -11,7 +11,7 @@ Time Elapsed - + [% WHILE (row = results.next) %] [% row.action.ucfirst | html_entity %] diff --git a/share/views/ajax/admintask/timedoutdevices.tt b/share/views/ajax/admintask/timedoutdevices.tt index e86667d8..3046c154 100644 --- a/share/views/ajax/admintask/timedoutdevices.tt +++ b/share/views/ajax/admintask/timedoutdevices.tt @@ -12,7 +12,7 @@ Try Again - + [% FOREACH row IN results %] [% row.backend | html_entity %] diff --git a/share/views/ajax/admintask/topology.tt b/share/views/ajax/admintask/topology.tt index 510a8c25..fb5f49fe 100644 --- a/share/views/ajax/admintask/topology.tt +++ b/share/views/ajax/admintask/topology.tt @@ -8,7 +8,7 @@ Action - +
diff --git a/share/views/ajax/admintask/undiscoveredneighbors.tt b/share/views/ajax/admintask/undiscoveredneighbors.tt index c8ec1624..b61925c8 100644 --- a/share/views/ajax/admintask/undiscoveredneighbors.tt +++ b/share/views/ajax/admintask/undiscoveredneighbors.tt @@ -7,7 +7,7 @@ Last Discovery - + [% FOREACH row IN results %] [% NEXT IF NOT row.remote_ip %] diff --git a/share/views/ajax/admintask/users.tt b/share/views/ajax/admintask/users.tt index 45e1da16..9c14b1eb 100644 --- a/share/views/ajax/admintask/users.tt +++ b/share/views/ajax/admintask/users.tt @@ -13,7 +13,7 @@ Action - + diff --git a/share/views/ajax/device/details.tt b/share/views/ajax/device/details.tt index 30ae863f..049c9c96 100644 --- a/share/views/ajax/device/details.tt +++ b/share/views/ajax/device/details.tt @@ -1,6 +1,6 @@ [% SET user_can_port_control = user_has_role('port_control') %] - + diff --git a/share/views/ajax/report/generic_report.tt b/share/views/ajax/report/generic_report.tt index 4b690ef2..7a583597 100644 --- a/share/views/ajax/report/generic_report.tt +++ b/share/views/ajax/report/generic_report.tt @@ -6,7 +6,7 @@ [% END %] - + [% FOREACH row IN results %] [% FOREACH col IN columns %] diff --git a/share/views/ajax/report/inventorybymodelbyos.tt b/share/views/ajax/report/inventorybymodelbyos.tt index 925946f6..52d82732 100644 --- a/share/views/ajax/report/inventorybymodelbyos.tt +++ b/share/views/ajax/report/inventorybymodelbyos.tt @@ -6,7 +6,7 @@ - + [% FOREACH row IN results %] - + diff --git a/share/views/ajax/report/subnets.tt b/share/views/ajax/report/subnets.tt index 79f05d18..4f03b2bd 100644 --- a/share/views/ajax/report/subnets.tt +++ b/share/views/ajax/report/subnets.tt @@ -8,7 +8,7 @@ - + [% FOREACH row IN results %] - + [% WHILE (row = macs.next) %] [% IF row.nbname %] diff --git a/share/views/ajax/search/node_by_mac.tt b/share/views/ajax/search/node_by_mac.tt index cb07db8b..3440ba4d 100644 --- a/share/views/ajax/search/node_by_mac.tt +++ b/share/views/ajax/search/node_by_mac.tt @@ -11,7 +11,7 @@ [% END %] - + [% WHILE (row = ips.next) %]
System Name [% d.name %]
Count
diff --git a/share/views/ajax/report/portlog.tt b/share/views/ajax/report/portlog.tt index b229065e..6d45fe55 100644 --- a/share/views/ajax/report/portlog.tt +++ b/share/views/ajax/report/portlog.tt @@ -10,7 +10,7 @@ Action
- [% session.logged_in_user | html_entity %]Percent Utilization
diff --git a/share/views/ajax/search/node_by_ip.tt b/share/views/ajax/search/node_by_ip.tt index 759b03c2..1548bf81 100644 --- a/share/views/ajax/search/node_by_ip.tt +++ b/share/views/ajax/search/node_by_ip.tt @@ -12,7 +12,7 @@ [% END %]