135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

more useful to log the ID than the type (esp in homogeneous networks)

Browse Source
This commit is contained in:
Oliver Gorwits
2018-01-05 17:26:36 +00:00
parent 1e42dce0f5
commit 4716be4c2f
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Changes
View File

@@ -3,6 +3,7 @@
[ENHANCEMENTS] [ENHANCEMENTS]
* Disable preventLabelOverlappingOnForceEnd on network neighbor map * Disable preventLabelOverlappingOnForceEnd on network neighbor map
* Debug log the neighbor ID to help with problem diagnosis
[BUG FIXES] [BUG FIXES]

7
lib/App/Netdisco/Worker/Plugin/Discover/Neighbors.pm
View File

@@ -72,6 +72,9 @@ register_worker({ phase => 'main', driver => 'snmp' }, sub {
subaction => 'with-nodes', subaction => 'with-nodes',
($remote_id ? (device_key => $remote_id) : ()), ($remote_id ? (device_key => $remote_id) : ()),
}); });
debug sprintf ' queue - queued device %s (ID: [%s])',
$ip, ($remote_id || '');
} }
return Status->info(sprintf ' [%s] neigh - processed %s neighbors', return Status->info(sprintf ' [%s] neigh - processed %s neighbors',
@@ -241,8 +244,8 @@ sub store_neighbors {
# what we came here to do.... discover the neighbor # what we came here to do.... discover the neighbor
debug sprintf debug sprintf
' [%s] neigh - adding neighbor %s, type [%s], on %s to discovery queue', ' [%s] neigh - adding neighbor %s, ID [%s], on %s to discovery queue',
$device->ip, $remote_ip, ($remote_type || ''), $port; $device->ip, $remote_ip, ($remote_id || ''), $port;
push @to_discover, [$remote_ip, $remote_type, $remote_id]; push @to_discover, [$remote_ip, $remote_type, $remote_id];
$remote_port = $c_port->{$entry}; $remote_port = $c_port->{$entry};