135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

do not run discover parts if properties failed to complete

Browse Source
This commit is contained in:
Oliver Gorwits
2017-10-07 13:21:13 +01:00
parent b52aaaf1a1
commit 58d0fbddda
9 changed files with 27 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/App/Netdisco/Worker/Plugin/Discover/CanonicalIP.pm
View File

@@ -13,6 +13,7 @@ register_worker({ phase => 'main', driver => 'snmp' }, sub {
my ($job, $workerconf) = @_;
my $device = $job->device;
return unless $device->in_storage;
my $snmp = App::Netdisco::Transport::SNMP->reader_for($device)
or return Status->defer("discover failed: could not SNMP connect to $device");
@@ -59,7 +60,7 @@ register_worker({ phase => 'main', driver => 'snmp' }, sub {
} # ALIAS
}
return true if $new_ip eq $old_ip;
return if $new_ip eq $old_ip;
schema('netdisco')->txn_do(sub {
# delete target device with the same vendor and serial number