135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix use of snmp_connect_ip which does not work for SNMPv3

Browse Source
This commit is contained in:
Oliver Gorwits
2017-11-16 22:10:18 +00:00
parent 68a56d35bb
commit 5aff19621c
3 changed files with 37 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/App/Netdisco/Util/SNMP.pm
View File

@@ -1,6 +1,7 @@
package App::Netdisco::Util::SNMP;
use Dancer qw/:syntax :script/;
use App::Netdisco::Util::DNS 'hostname_from_ip';
use App::Netdisco::Util::Permission ':all';
use base 'Exporter';
@@ -138,7 +139,8 @@ sub get_communities {
# clean the community table of obsolete tags
eval { $device->community->update({$tag_name => undef}) }
if not $stored_tag or !exists $seen_tags->{ $stored_tag };
if $device->in_storage
and (not $stored_tag or !exists $seen_tags->{ $stored_tag });
return ( @communities, @$config );
}
@@ -147,7 +149,7 @@ sub _get_external_community {
my ($device, $mode) = @_;
my $cmd = setting('get_community');
my $ip = $device->ip;
my $host = $device->dns || $ip;
my $host = ($device->dns || hostname_from_ip($ip) || $ip);
if (defined $cmd and length $cmd) {
# replace variables