From 927f2f0a74aa97b3720401d56feb6f3972f703d5 Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Sat, 7 Apr 2018 23:27:06 +0100
Subject: [PATCH 1/3] #390 cannot take logarithm of zero (C. Stromsoe)

---
 lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm b/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm
index 0d843e2c..a67c8985 100644
--- a/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm
+++ b/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm
@@ -11,7 +11,7 @@ __PACKAGE__->table('device_port_speed');
 __PACKAGE__->result_source_instance->is_virtual(1);
 __PACKAGE__->result_source_instance->view_definition(<<ENDSQL
   SELECT ip,
-         sum( COALESCE(dpp.raw_speed,1) ) as total
+         GREATEST(1, sum( COALESCE(dpp.raw_speed,1) )) as total
   FROM device_port
   LEFT OUTER JOIN device_port_properties dpp USING (ip, port)
   WHERE port !~* 'vlan'

From 97d5501ba0ea5f88b8931fd2c17a5ee59a814641 Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Sat, 7 Apr 2018 23:59:59 +0100
Subject: [PATCH 2/3] do not include logical aggregate masters in netmap/speed
 calc

---
 lib/App/Netdisco/DB/Result/Virtual/DeviceLinks.pm     | 1 +
 lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm | 1 +
 2 files changed, 2 insertions(+)

diff --git a/lib/App/Netdisco/DB/Result/Virtual/DeviceLinks.pm b/lib/App/Netdisco/DB/Result/Virtual/DeviceLinks.pm
index ed7299af..8c893816 100644
--- a/lib/App/Netdisco/DB/Result/Virtual/DeviceLinks.pm
+++ b/lib/App/Netdisco/DB/Result/Virtual/DeviceLinks.pm
@@ -33,6 +33,7 @@ __PACKAGE__->result_source_instance->view_definition(<<ENDSQL
    AND dp.port !~* 'vlan'
    AND (dp.type IS NULL OR dp.type !~* '^(53|ieee8023adLag|propVirtual|l2vlan|l3ipvlan|135|136|137)\$')
    AND (dp.name IS NULL OR dp.name !~* 'vlan')
+   AND (dp.is_master = 'false' OR dp.slave_of IS NOT NULL)
    AND dp.ip <= dp2.ip
  GROUP BY left_ip, left_dns, left_name, right_ip, right_dns, right_name
  ORDER BY dp.ip
diff --git a/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm b/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm
index a67c8985..520c2b4c 100644
--- a/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm
+++ b/lib/App/Netdisco/DB/Result/Virtual/DevicePortSpeed.pm
@@ -17,6 +17,7 @@ __PACKAGE__->result_source_instance->view_definition(<<ENDSQL
   WHERE port !~* 'vlan'
     AND (type IS NULL OR type !~* '^(53|ieee8023adLag|propVirtual|l2vlan|l3ipvlan|135|136|137)\$')
     AND (name IS NULL OR name !~* 'vlan')
+    AND (is_master = 'false' OR slave_of IS NOT NULL)
   GROUP BY ip
   ORDER BY total DESC, ip ASC
 ENDSQL

From 8e30dec24f2b01556e958e313511d1564879ccb4 Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Sun, 8 Apr 2018 00:09:46 +0100
Subject: [PATCH 3/3] protect against undef mac (l.e. ferguson)

---
 lib/App/Netdisco/Util/Node.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/App/Netdisco/Util/Node.pm b/lib/App/Netdisco/Util/Node.pm
index ca6d4eed..7cc832bc 100644
--- a/lib/App/Netdisco/Util/Node.pm
+++ b/lib/App/Netdisco/Util/Node.pm
@@ -65,6 +65,8 @@ MAC address does not belong to an interface on any known Device
 
 sub check_mac {
   my ($device, $node, $port_macs) = @_;
+  return 0 if !$device or !$node;
+
   my $mac = NetAddr::MAC->new(mac => $node);
   my $devip = (ref $device ? $device->ip : '');
   $port_macs ||= {};