135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ORDER BY ... FOR UPDATE will allow us to avoid table lock

Browse Source
This commit is contained in:
Oliver Gorwits
2013-05-24 13:10:58 +01:00
parent 7c438e01fc
commit 6f7c87ac07
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Netdisco/lib/App/Netdisco/Util/Arpnip.pm
View File

@@ -8,7 +8,6 @@ use App::Netdisco::Util::DNS ':all';
use NetAddr::IP::Lite ':lower'; use NetAddr::IP::Lite ':lower';
use Time::HiRes 'gettimeofday'; use Time::HiRes 'gettimeofday';
use Net::MAC; use Net::MAC;
use Try::Tiny;
use base 'Exporter'; use base 'Exporter';
our @EXPORT = (); our @EXPORT = ();
@@ -61,7 +60,7 @@ sub do_arpnip {
my $now = join '.', gettimeofday; my $now = join '.', gettimeofday;
# update node_ip with ARP and Neighbor Cache entries # update node_ip with ARP and Neighbor Cache entries
# TODO: find out whether FOR UPDATE would be suitable instead of table lock # TODO: ORDER BY ... FOR UPDATE will allow us to avoid the table lock
schema('netdisco')->resultset('NodeIp')->txn_do_locked( schema('netdisco')->resultset('NodeIp')->txn_do_locked(
EXCLUSIVE, sub { EXCLUSIVE, sub {
_store_arp(@$_, $now) for @v4; _store_arp(@$_, $now) for @v4;