135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix snmpretries parsing #835

Browse Source
This commit is contained in:
Christian Ramseyer
2021-10-29 20:14:13 +02:00
parent a3d405533f
commit 74210dd78f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/App/Netdisco/Transport/SNMP.pm
View File

@@ -124,9 +124,8 @@ sub _snmp_connect_generic {
my %snmp_args = ( my %snmp_args = (
AutoSpecify => 0, AutoSpecify => 0,
DestHost => $device->ip, DestHost => $device->ip,
# 0 is falsy. Using || with snmpretries equal to 0 will set retries to 2. # the defined() allows 0 to be a settable value
# check if the setting is 0. If not, use the default value of 2. Retries => defined(setting('snmpretries')) ? setting('snmpretries') : 2,
Retries => (setting('snmpretries') || setting('snmpretries') == 0 ? 0 : 2),
Timeout => (setting('snmptimeout') || 1000000), Timeout => (setting('snmptimeout') || 1000000),
NonIncreasing => (setting('nonincreasing') || 0), NonIncreasing => (setting('nonincreasing') || 0),
BulkWalk => ((defined setting('bulkwalk_off') && setting('bulkwalk_off')) BulkWalk => ((defined setting('bulkwalk_off') && setting('bulkwalk_off'))