From 7630b6ec7bf033a892a9fea16807a60f3b76558a Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Sun, 5 Oct 2014 12:34:02 +0100
Subject: [PATCH] support override of reports

---
 Netdisco/lib/App/Netdisco/Web/Plugin.pm | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/Netdisco/lib/App/Netdisco/Web/Plugin.pm b/Netdisco/lib/App/Netdisco/Web/Plugin.pm
index 17d4b503..2b4887ac 100644
--- a/Netdisco/lib/App/Netdisco/Web/Plugin.pm
+++ b/Netdisco/lib/App/Netdisco/Web/Plugin.pm
@@ -169,20 +169,21 @@ register 'register_report' => sub {
       return error "bad config to register_report";
   }
 
-  foreach my $tag (@{setting('_reports_menu')->{ $config->{category} }}) {
-      if ($tag eq $config->{tag}) {
-          setting('_reports')->{$tag} = $config;
-          return;
-      }
+  if (0 == scalar grep {$_ eq $config->{tag}}
+                       @{setting('_reports_menu')->{ $config->{category} }}) {
+      push @{setting('_reports_menu')->{ $config->{category} }}, $config->{tag};
   }
 
-  push @{setting('_reports_menu')->{ $config->{category} }}, $config->{tag};
-  setting('_reports')->{$config->{tag}} = $config;
+  foreach my $tag (@{setting('_reports_menu')->{ $config->{category} }}) {
+      if ($config->{tag} eq $tag) {
+          setting('_reports')->{$tag} = $config;
 
-  foreach my $rconfig (@{setting('reports')}) {
-      if ($rconfig->{tag} eq $config->{tag}) {
-          setting('_reports')->{$config->{tag}}->{'rconfig'} = $rconfig;
-          last;
+          foreach my $rconfig (@{setting('reports')}) {
+              if ($rconfig->{tag} eq $tag) {
+                  setting('_reports')->{$tag}->{'rconfig'} = $rconfig;
+                  last;
+              }
+          }
       }
   }
 };