135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

allow pseudo devices with layer 2/3 capability

Browse Source
This commit is contained in:
Oliver Gorwits
2019-09-03 08:59:10 +01:00
parent d1fdf574e3
commit 7d97943fcd
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/App/Netdisco/Util/Device.pm
View File

@@ -226,8 +226,7 @@ the local configuration to arpnip the device.
The configuration items C<arpnip_no> and C<arpnip_only> are checked The configuration items C<arpnip_no> and C<arpnip_only> are checked
against the given IP. against the given IP.
Also checks if the device is a pseudo device (vendor is C<netdisco>) and Also checks if the device reports layer 3 capability.
that it has reported layer 3 capability.
Returns false if the host is not permitted to arpnip the target device. Returns false if the host is not permitted to arpnip the target device.
@@ -237,9 +236,6 @@ sub is_arpnipable {
my $ip = shift; my $ip = shift;
my $device = get_device($ip) or return 0; my $device = get_device($ip) or return 0;
return _bail_msg("is_arpnipable: $device is pseudo-device")
if $device->is_pseudo;
return _bail_msg("is_arpnipable: $device has no layer 3 capability") return _bail_msg("is_arpnipable: $device has no layer 3 capability")
unless $device->has_layer(3); unless $device->has_layer(3);
@@ -285,8 +281,7 @@ the local configuration to macsuck the device.
The configuration items C<macsuck_no> and C<macsuck_only> are checked The configuration items C<macsuck_no> and C<macsuck_only> are checked
against the given IP. against the given IP.
Also checks if the device is a pseudo device (vendor is C<netdisco>) and Also checks if the device reports layer 2 capability.
that it has reported layer 2 capability.
Returns false if the host is not permitted to macsuck the target device. Returns false if the host is not permitted to macsuck the target device.
@@ -296,9 +291,6 @@ sub is_macsuckable {
my $ip = shift; my $ip = shift;
my $device = get_device($ip) or return 0; my $device = get_device($ip) or return 0;
return _bail_msg("is_macsuckable: $device is pseudo-device")
if $device->is_pseudo;
return _bail_msg("is_macsuckable: $device has no layer 2 capability") return _bail_msg("is_macsuckable: $device has no layer 2 capability")
unless $device->has_layer(2); unless $device->has_layer(2);