bug fixes

This commit is contained in:
Oliver Gorwits
2017-10-06 07:48:58 +01:00
parent b58a5816a9
commit 8b660a89c0
8 changed files with 10 additions and 10 deletions

View File

@@ -125,7 +125,7 @@ foreach my $host (@hostlist) {
my $actiontext = ( my $actiontext = (
($job->device ? ('['.$job->device->ip.']') : '') . ($job->device ? ('['.$job->device->ip.']') : '') .
($job->action eq 'show' ? ('/'.$job->subaction) : '') ($job->action eq 'show' ? ('/'. ($job->subaction || 'interfaces')) : '')
); );
# do job # do job

View File

@@ -8,7 +8,7 @@ use App::Netdisco::Transport::SNMP;
register_worker({ stage => 'check' }, sub { register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).') return Status->error('Missing device (-d).')
unless defined (shift)->device; unless defined shift->device;
return Status->done('Contact is able to run'); return Status->done('Contact is able to run');
}); });

View File

@@ -8,7 +8,7 @@ use App::Netdisco::Util::Device 'delete_device';
register_worker({ stage => 'check' }, sub { register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).') return Status->error('Missing device (-d).')
unless defined (shift)->device; unless defined shift->device;
return Status->done('Delete is able to run'); return Status->done('Delete is able to run');
}); });

View File

@@ -8,7 +8,7 @@ use Dancer::Plugin::DBIC 'schema';
register_worker({ stage => 'check' }, sub { register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).') return Status->error('Missing device (-d).')
unless defined (shift)->device; unless defined shift->device;
return Status->done('ExpireNodes is able to run'); return Status->done('ExpireNodes is able to run');
}); });

View File

@@ -8,7 +8,7 @@ use App::Netdisco::Transport::SNMP;
register_worker({ stage => 'check' }, sub { register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).') return Status->error('Missing device (-d).')
unless defined (shift)->device; unless defined shift->device;
return Status->done('Location is able to run'); return Status->done('Location is able to run');
}); });

View File

@@ -9,7 +9,7 @@ use App::Netdisco::Util::Device qw/get_device renumber_device/;
register_worker({ stage => 'check' }, sub { register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).') return Status->error('Missing device (-d).')
unless defined (shift)->device; unless defined shift->device;
my $new_ip = NetAddr::IP->new($job->extra); my $new_ip = NetAddr::IP->new($job->extra);
unless ($new_ip and $new_ip->addr ne '0.0.0.0') { unless ($new_ip and $new_ip->addr ne '0.0.0.0') {

View File

@@ -9,7 +9,7 @@ use App::Netdisco::Transport::SNMP;
register_worker({ stage => 'check' }, sub { register_worker({ stage => 'check' }, sub {
return Status->error('Missing device (-d).') return Status->error('Missing device (-d).')
unless defined (shift)->device; unless defined shift->device;
return Status->done('Show is able to run'); return Status->done('Show is able to run');
}); });

View File

@@ -59,9 +59,9 @@ sub _make_new {
return $new; return $new;
} }
sub error { (shift)->_make_new('error', @_) } sub error { shift->_make_new('error', @_) }
sub done { (shift)->_make_new('done', @_) } sub done { shift->_make_new('done', @_) }
sub defer { (shift)->_make_new('defer', @_) } sub defer { shift->_make_new('defer', @_) }
=head2 noop =head2 noop