From 912a971a75fcf288cb433e478868862bf9a36a12 Mon Sep 17 00:00:00 2001 From: Oliver Gorwits Date: Thu, 13 Feb 2020 10:23:07 +0000 Subject: [PATCH] tidy the Clavister module --- .../SSHCollector/Platform/Clavister.pm | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/App/Netdisco/SSHCollector/Platform/Clavister.pm b/lib/App/Netdisco/SSHCollector/Platform/Clavister.pm index 28bb5129..248406cc 100644 --- a/lib/App/Netdisco/SSHCollector/Platform/Clavister.pm +++ b/lib/App/Netdisco/SSHCollector/Platform/Clavister.pm @@ -1,38 +1,37 @@ package App::Netdisco::SSHCollector::Platform::Clavister; -# vim: set expandtab tabstop=8 softtabstop=4 shiftwidth=4: - =head1 NAME + App::Netdisco::SSHCollector::Platform::Clavister + =head1 DESCRIPTION + Collect ARP entries from Clavister firewalls. These devices does not expose mac table through snmp. + =cut use strict; use warnings; -use Data::Dumper; -sub new { - my $proto = shift; - my $class = ref($proto) || $proto; - my $self = {}; - bless ($self, $class); - return $self; -} +use Dancer ':script'; +use Moo; =head1 PUBLIC METHODS + =over 4 + =item B + Retrieve ARP entries from device. C<$host> is the hostname or IP address of the device. C<$ssh> is a Net::OpenSSH connection to the device. Returns an array of hashrefs in the format { mac => MACADDR, ip => IPADDR }. + =cut + sub arpnip { - my ($self, $hostlabel, $ssh, @args) = @_; - - print "$hostlabel $$ arpnip()\n"; + debug "$hostlabel $$ arpnip()"; my @data = $ssh->capture("neighborcache"); chomp @data; @@ -49,4 +48,5 @@ sub arpnip { } return @arpentries; } + 1;