move macsuck and macwalk to worker plugins (macsuck needs snmp scope guard)

2017-09-09 15:55:53 +01:00
parent 68ca85643b
commit 9167e02de5
6 changed files with 191 additions and 175 deletions
--- a/lib/App/Netdisco/Worker/Plugin/Nbtstat.pm
+++ b/lib/App/Netdisco/Worker/Plugin/Nbtstat.pm
@@ -10,7 +10,7 @@ register_worker({ primary => true }, sub {
  my ($job, $workerconf) = @_;

  return Status->error('nbtstat failed: unable to interpret device param')
-    if !defined $job->device;
+    unless defined $job->device;

  return Status->defer(sprintf 'nbtstat deferred: %s is not macsuckable', $job->device->ip)
    unless is_macsuckable($job->device);