135/netdisco
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ACL support for scheduled jobs (#1106)

Browse Source 
implements #580
This commit is contained in:
Oliver Gorwits
2023-09-27 12:03:49 +01:00
committed by GitHub
parent 389823bf09
commit 993edd0c6a
4 changed files with 129 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
lib/App/Netdisco/Util/Device.pm
View File

@@ -4,8 +4,10 @@ use Dancer qw/:syntax :script/;
use Dancer::Plugin::DBIC 'schema';
use App::Netdisco::Util::Permission qw/acl_matches acl_matches_only/;
use List::MoreUtils ();
use File::Spec::Functions qw(catdir catfile);
use File::Path 'make_path';
use NetAddr::IP;
use base 'Exporter';
our @EXPORT = ();
@@ -362,7 +364,34 @@ sub get_denied_actions {
push @badactions, 'arpnip'
if not is_arpnipable($device);
return @badactions;
# add pseudo-actions for schedule entries with ACLs
my $schedule = setting('schedule') || {};
foreach my $label (keys %$schedule) {
my $sched = $schedule->{$label} || next;
next unless $sched->{only} or $sched->{no};
my $action = $sched->{action} || $label;
my $pseudo_action = "scheduled-$label";
# if this action is denied in global config then schedule should not run
if (scalar grep {$_ eq $action} @badactions) {
push @badactions, $pseudo_action;
next;
}
my $net = NetAddr::IP->new($sched->{device});
next if ($sched->{device}
and (!$net or $net->num == 0 or $net->addr eq '0.0.0.0'));
push @badactions, $pseudo_action
if $sched->{device} and not acl_matches_only($device, $net->cidr);
push @badactions, $pseudo_action
if $sched->{no} and acl_matches($device, $sched->{no});
push @badactions, $pseudo_action
if $sched->{only} and not acl_matches_only($device, $sched->{only});
}
return List::MoreUtils::uniq @badactions;
}
1;