From acb7bfe797cff9bd66d30d1f95b562522b2b5f8c Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Mon, 3 Dec 2012 22:59:18 +0000
Subject: [PATCH] always log error from set_foo

---
 Netdisco/lib/Netdisco/PortControl.pm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Netdisco/lib/Netdisco/PortControl.pm b/Netdisco/lib/Netdisco/PortControl.pm
index b3d527d8..2200222c 100644
--- a/Netdisco/lib/Netdisco/PortControl.pm
+++ b/Netdisco/lib/Netdisco/PortControl.pm
@@ -20,7 +20,8 @@ sub _set_generic {
   try {
       # snmp connect using rw community
       my $info = snmp_connect($ip)
-        or return ();
+        or return ('error',
+          sprintf 'Failed to connect to device [%s] to update %s', $ip, $slot);
 
       my $method = 'set_'. $slot;
       my $rv = $info->$method($data);
@@ -42,7 +43,9 @@ sub _set_generic {
 
       # get device details from db
       my $device = get_device($ip)
-        or return ();
+        or return ('error',
+          sprintf 'Updated %s on [%s] to [%s] but failed to update database',
+            $slot, $ip, $data);
 
       # update netdisco DB
       $device->update({$slot => $data});