cancel early if we can

2018-02-11 12:07:12 +00:00
parent d3c83c395d
commit b213d0b9af
1 changed files with 4 additions and 0 deletions
--- a/lib/App/Netdisco/Worker/Plugin/Discover.pm
+++ b/lib/App/Netdisco/Worker/Plugin/Discover.pm
@@ -19,6 +19,10 @@ register_worker({ phase => 'check' }, sub {
  return Status->defer("discover skipped: $device is pseudo-device")
    if $device->is_pseudo;

+  # runner has already called get_device to promote $job->device
+  return $job->cancel("fresh discover cancelled: $device already known")
+    if $device->in_storage and $job->subaction eq 'with-nodes';
+
  return Status->defer("discover deferred: $device is not discoverable")
    unless is_discoverable_now($device);