From be66c70636fd8a319ae80a4b8274141f94681a70 Mon Sep 17 00:00:00 2001 From: "Eric A. Miller" Date: Sun, 23 Feb 2014 16:09:33 -0500 Subject: [PATCH] Fix NetBIOS report with search on blank domain --- Netdisco/Changes | 6 ++++++ Netdisco/lib/App/Netdisco/Web/Plugin/Report/Netbios.pm | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Netdisco/Changes b/Netdisco/Changes index 45f98a93..342f741e 100644 --- a/Netdisco/Changes +++ b/Netdisco/Changes @@ -1,3 +1,9 @@ +2.024001 - + + [BUG FIXES] + + * Fix NetBIOS report with search on blank domain + 2.024000 - 2014-02-22 [NEW FEATURES] diff --git a/Netdisco/lib/App/Netdisco/Web/Plugin/Report/Netbios.pm b/Netdisco/lib/App/Netdisco/Web/Plugin/Report/Netbios.pm index 61df286c..3b5aba00 100644 --- a/Netdisco/lib/App/Netdisco/Web/Plugin/Report/Netbios.pm +++ b/Netdisco/lib/App/Netdisco/Web/Plugin/Report/Netbios.pm @@ -41,9 +41,9 @@ get '/ajax/content/report/netbios' => require_login sub { my $rs = schema('netdisco')->resultset('NodeNbt'); if ( defined $domain ) { - $domain = '' if $domain eq 'blank'; + my $search = $domain eq 'blank' ? '' : $domain; $rs - = $rs->search( { domain => $domain } ) + = $rs->search( { domain => $search } ) ->order_by( [ { -asc => 'domain' }, { -desc => 'time_last' } ] ) ->hri; }