From cd2a4b936266b6a67f49ad0f79ae7f58e545f5d4 Mon Sep 17 00:00:00 2001
From: nick n <39005454+inphobia@users.noreply.github.com>
Date: Sun, 12 May 2019 09:32:42 +0200
Subject: [PATCH] html template fixups (#576)
* none is not a valid value for min-width, so set it to zero
* these 2 "checked" if statements need a space in front of them,
else they will attach to the previous element
id="nd_showspeed"checked="checked"
* multiple tag has no options according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select
also, don't close select before we've gotten to the option tags
* multiple tag has no options according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select
also, don't close select before we've gotten to the option tags
* just to be sure put a space in front of these optional tags as well,
* $a is technically allowed but is considered not best practice
---
lib/App/Netdisco/Web/PortControl.pm | 8 ++++----
share/public/css/netdisco.css | 2 +-
share/views/ajax/admintask/nodemonitor.tt | 4 ++--
share/views/ajax/admintask/users.tt | 6 +++---
share/views/sidebar/device/netmap.tt | 14 ++++++-------
share/views/sidebar/device/ports.tt | 2 +-
share/views/sidebar/report/moduleinventory.tt | 4 ++--
share/views/sidebar/report/netbios.tt | 4 ++--
share/views/sidebar/report/nodesdiscovered.tt | 4 ++--
share/views/sidebar/report/nodevendor.tt | 4 ++--
share/views/sidebar/report/portssid.tt | 4 ++--
share/views/sidebar/search/device.tt | 20 +++++++++----------
12 files changed, 38 insertions(+), 38 deletions(-)
diff --git a/lib/App/Netdisco/Web/PortControl.pm b/lib/App/Netdisco/Web/PortControl.pm
index cf28f4bb..eff24f47 100644
--- a/lib/App/Netdisco/Web/PortControl.pm
+++ b/lib/App/Netdisco/Web/PortControl.pm
@@ -31,14 +31,14 @@ ajax '/ajax/portcontrol' => require_any_role [qw(admin port_control)] => sub {
schema('netdisco')->txn_do(sub {
if (param('port')) {
- my $a = "$action $subaction";
- $a =~ s/-other$//;
- $a =~ s/^portcontrol/port/;
+ my $act = "$action $subaction";
+ $act =~ s/-other$//;
+ $act =~ s/^portcontrol/port/;
schema('netdisco')->resultset('DevicePortLog')->create({
ip => param('device'),
port => param('port'),
- action => $a,
+ action => $act,
username => session('logged_in_user'),
userip => request->remote_address,
reason => (param('reason') || 'other'),
diff --git a/share/public/css/netdisco.css b/share/public/css/netdisco.css
index 02123971..ebc913b4 100644
--- a/share/public/css/netdisco.css
+++ b/share/public/css/netdisco.css
@@ -87,7 +87,7 @@ div.content > div.tab-content table.nd_floatinghead thead {
/* to be added to qtip-bootstrap class */
.nd_qtip-unconstrained {
- min-width: none;
+ min-width: 0;
max-width: none;
}
diff --git a/share/views/ajax/admintask/nodemonitor.tt b/share/views/ajax/admintask/nodemonitor.tt
index b2f0c1cb..c72287b7 100644
--- a/share/views/ajax/admintask/nodemonitor.tt
+++ b/share/views/ajax/admintask/nodemonitor.tt
@@ -32,10 +32,10 @@