From d1a1235c8512c214c1521b5673e41428bea7f4fe Mon Sep 17 00:00:00 2001 From: nick n <39005454+inphobia@users.noreply.github.com> Date: Fri, 19 Jul 2019 04:16:06 +0200 Subject: [PATCH] handle row.power.power being NULL fixes this error, since device_port_power.power can be null: Argument "" isn't numeric in numeric gt (>) at /home/netdisco/perl5/lib/perl5/auto/share/dist/App-Netdisco/views/ajax/device/ports.tt line 251. currently only seen on cisco sb switches, which do have all other columns filled in ip | port | module | admin | status | class | power ---------------+------+--------+-------+------------+--------+------- 10.40.254.150 | fa2 | 1 | true | otherFault | class3 | 10.40.254.150 | fa16 | 1 | true | searching | class3 | 10.40.254.150 | fa3 | 1 | true | searching | class3 | ... --- share/views/ajax/device/ports.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/share/views/ajax/device/ports.tt b/share/views/ajax/device/ports.tt index d373a90b..668be5ef 100644 --- a/share/views/ajax/device/ports.tt +++ b/share/views/ajax/device/ports.tt @@ -244,7 +244,7 @@ [% END %] - [% IF row.power.power > 0 %] + [% IF row.power.power AND row.power.power > 0 %] [% row.power.power | html_entity %] mW [% ELSE %] ([% row.power.status | html_entity %])