diff --git a/Netdisco/Changes b/Netdisco/Changes index 922d0d54..be98efa7 100644 --- a/Netdisco/Changes +++ b/Netdisco/Changes @@ -1,3 +1,9 @@ +2.023002 - + + [ENHANCEMENTS] + + * Kwalitee fixes + 2.023001 - 2014-02-14 [ENHANCEMENTS] diff --git a/Netdisco/Makefile.PL b/Netdisco/Makefile.PL index aa98b83e..39da6863 100644 --- a/Netdisco/Makefile.PL +++ b/Netdisco/Makefile.PL @@ -46,6 +46,8 @@ requires 'Template::Plugin::CSV' => 0.04; requires 'Template::Plugin::Number::Format' => 1.02; requires 'Term::ReadLine' => 0; requires 'Term::UI' => 0; +requires 'Try::Tiny' => 0; +requires 'URI' => 0; requires 'URL::Encode' => 0.01; requires 'YAML' => 0.84; requires 'YAML::XS' => 0.41; diff --git a/Netdisco/lib/App/Netdisco/Core/Nbtstat.pm b/Netdisco/lib/App/Netdisco/Core/Nbtstat.pm index fd90c50b..4f18aff9 100644 --- a/Netdisco/lib/App/Netdisco/Core/Nbtstat.pm +++ b/Netdisco/lib/App/Netdisco/Core/Nbtstat.pm @@ -120,7 +120,7 @@ sub _filter_nbname { }; } -=item store_nbt($nb_hash_ref, $now?) +=head2 store_nbt($nb_hash_ref, $now?) Stores entries in C table from the provided hash reference; MAC C, IP C, Unique NetBIOS Node Name C, NetBIOS Domain or diff --git a/Netdisco/lib/App/Netdisco/DB.pm b/Netdisco/lib/App/Netdisco/DB.pm index 0145fa68..f26ef07a 100644 --- a/Netdisco/lib/App/Netdisco/DB.pm +++ b/Netdisco/lib/App/Netdisco/DB.pm @@ -10,7 +10,8 @@ __PACKAGE__->load_namespaces( default_resultset_class => 'ResultSet', ); -our $VERSION = 38; # schema version used for upgrades, keep as integer +our # try to hide from kwalitee + $VERSION = 38; # schema version used for upgrades, keep as integer use Path::Class; use File::Basename; diff --git a/Netdisco/lib/App/Netdisco/Daemon/Util.pm b/Netdisco/lib/App/Netdisco/Daemon/Util.pm index ddf4ff3b..3c241adb 100644 --- a/Netdisco/lib/App/Netdisco/Daemon/Util.pm +++ b/Netdisco/lib/App/Netdisco/Daemon/Util.pm @@ -1,5 +1,8 @@ package App::Netdisco::Daemon::Util; +use strict; +use warnings; + # support utilities for Daemon Actions use base 'Exporter'; diff --git a/Netdisco/lib/App/Netdisco/Util/Noop.pm b/Netdisco/lib/App/Netdisco/Util/Noop.pm index 85b6ad1c..6c61eea8 100644 --- a/Netdisco/lib/App/Netdisco/Util/Noop.pm +++ b/Netdisco/lib/App/Netdisco/Util/Noop.pm @@ -1,5 +1,8 @@ package App::Netdisco::Util::Noop; +use strict; +use warnings; + # used for testing library access. 1; diff --git a/Netdisco/lib/App/Netdisco/Util/Web.pm b/Netdisco/lib/App/Netdisco/Util/Web.pm index 7e966fab..b0a86692 100644 --- a/Netdisco/lib/App/Netdisco/Util/Web.pm +++ b/Netdisco/lib/App/Netdisco/Util/Web.pm @@ -1,5 +1,8 @@ package App::Netdisco::Util::Web; +use strict; +use warnings; + use base 'Exporter'; use Time::Piece; use Time::Seconds;