#398 user submitted jobs are run regardless of max deferrals

Changes

@@ -4,6 +4,7 @@
 
   * #392 fix heuristic neighbour detection
   * #393 avoid 'modification of readonly variable' error in netmap
+  * #398 user submitted jobs are run regardless of max deferrals
   * clean up check_mac() interface (ml-cms)
 
 2.039021 - 2018-04-10

lib/App/Netdisco/DB/Result/Virtual/TastyJobs.pm

@@ -29,7 +29,7 @@ __PACKAGE__->result_source_instance->view_definition(<<ENDSQL
     LEFT OUTER JOIN device_skip ds
       ON (ds.backend = ? AND ds.device = my_jobs.device)
 
-   WHERE ds.deferrals < ?
+   WHERE ((ds.deferrals < ?) OR my_jobs.username IS NOT NULL)
       OR (ds.deferrals IS NULL AND ds.last_defer IS NULL)
       OR ds.last_defer <= ( LOCALTIMESTAMP - ?::interval )
 

lib/App/Netdisco/JobQueue/PostgreSQL.pm

@@ -241,7 +241,7 @@ sub jq_complete {
 
   # now that SNMP connect failures are deferrals and not errors, any complete
   # status, whether success or failure, indicates an SNMP connect. reset the
-  # connection failures counter to forget oabout occasional connect glitches.
+  # connection failures counter to forget about occasional connect glitches.
 
   try {
     schema('netdisco')->txn_do(sub {