fixes to SQL and api spec

lib/App/Netdisco/DB/Result/Virtual/UserRole.pm

@@ -20,8 +20,8 @@ __PACKAGE__->result_source_instance->view_definition(<<ENDSQL
   SELECT username, 'ldap' AS role FROM users
     WHERE ldap
   UNION
-  SELECT username, 'api', AS role FROM users
-    WHERE token AND token_from
+  SELECT username, 'api' AS role FROM users
+    WHERE token IS NOT NULL AND token_from IS NOT NULL
 ENDSQL
 );
 

lib/App/Netdisco/Util/API.pm

@@ -12,11 +12,11 @@ our @EXPORT = qw/
 sub parse_search_params {
     my $params = shift;
     my $search = {};
-    my $partial = $params->{partial} || 0;
+    my $partial = $params->{partial} || false;
 
     foreach my $param (keys %{$params}) {
         if ($param ne 'return_url' and $param ne 'partial') {
-            if ($partial == 1) { 
+            if ($partial eq 'true') {
                 $search->{"text(".$param.")"} = { -ilike => '%'.$params->{$param}.'%'};
             }
             else {

lib/App/Netdisco/Web/Plugin/API/NodeIP.pm

@@ -25,6 +25,9 @@ swagger_path {
       description => 'All parameters will be searched for case insensitively in their values',
     },
   ],
+  responses => {
+    default => { description => 'A row from the node_ip table' },
+  },
 },
 get '/api/nodeip/search' => require_role api => sub {
     my $para = params;