From f75f1e5cbf51d024b0588ca9b410b0d0abad517f Mon Sep 17 00:00:00 2001
From: Oliver Gorwits <oliver@cpan.org>
Date: Mon, 6 May 2013 00:45:18 +0100
Subject: [PATCH] add frontend update/del forms, and display port count

---
 Netdisco/lib/App/Netdisco/DB/Result/Device.pm | 10 ++++
 .../lib/App/Netdisco/DB/ResultSet/Device.pm   | 30 ++++++++++++
 .../Web/Plugin/AdminTask/PseudoDevice.pm      | 48 ++++++++++++++++++-
 Netdisco/share/public/css/netdisco.css        |  4 ++
 .../views/ajax/admintask/pseudodevice.tt      | 11 ++++-
 5 files changed, 100 insertions(+), 3 deletions(-)

diff --git a/Netdisco/lib/App/Netdisco/DB/Result/Device.pm b/Netdisco/lib/App/Netdisco/DB/Result/Device.pm
index 19774496..d0b81e24 100644
--- a/Netdisco/lib/App/Netdisco/DB/Result/Device.pm
+++ b/Netdisco/lib/App/Netdisco/DB/Result/Device.pm
@@ -180,6 +180,16 @@ __PACKAGE__->has_many(
 
 =head1 ADDITIONAL COLUMNS
 
+=head2 port_count
+
+Returns the number of ports on this device. Enable this
+column by applying the C<with_port_count()> modifier to C<search()>.
+
+=cut
+
+sub port_count { return (shift)->get_column('port_count') }
+
+
 =head2 uptime_age
 
 Formatted version of the C<uptime> field.
diff --git a/Netdisco/lib/App/Netdisco/DB/ResultSet/Device.pm b/Netdisco/lib/App/Netdisco/DB/ResultSet/Device.pm
index f5e6f0f8..097fd902 100644
--- a/Netdisco/lib/App/Netdisco/DB/ResultSet/Device.pm
+++ b/Netdisco/lib/App/Netdisco/DB/ResultSet/Device.pm
@@ -491,4 +491,34 @@ sub get_distinct_col {
   )->get_column($col)->all;
 }
 
+=head2 with_port_count
+
+This is a modifier for any C<search()> which
+will add the following additional synthesized column to the result set:
+
+=over 4
+
+=item port_count
+
+=back
+
+=cut
+
+sub with_port_count {
+  my ($rs, $cond, $attrs) = @_;
+
+  return $rs
+    ->search_rs($cond, $attrs)
+    ->search({},
+      {
+        '+columns' => { port_count =>
+          $rs->result_source->schema->resultset('DevicePort')
+            ->search(
+              { 'dp.ip' => { -ident => 'me.ip' } },
+              { alias => 'dp' }
+            )->count_rs->as_query
+        },
+      });
+}
+
 1;
diff --git a/Netdisco/lib/App/Netdisco/Web/Plugin/AdminTask/PseudoDevice.pm b/Netdisco/lib/App/Netdisco/Web/Plugin/AdminTask/PseudoDevice.pm
index 6ac3a208..5a41bca7 100644
--- a/Netdisco/lib/App/Netdisco/Web/Plugin/AdminTask/PseudoDevice.pm
+++ b/Netdisco/lib/App/Netdisco/Web/Plugin/AdminTask/PseudoDevice.pm
@@ -5,18 +5,64 @@ use Dancer::Plugin::Ajax;
 use Dancer::Plugin::DBIC;
 
 use App::Netdisco::Web::Plugin;
+use NetAddr::IP::Lite ':lower';
+use Try::Tiny;
 
 register_admin_task({
   tag => 'pseudodevice',
   label => 'Manage Pseudo Devices',
 });
 
+sub _sanity_ok {
+    my $happy = 0;
+
+    try {
+        return 0 unless length param('dns')
+          and param('dns') =~ m/^[[:print:]]+$/
+          and param('dns') !~ m/[[:space:]]/;
+
+        my $ip = NetAddr::IP::Lite->new(param('ip'));
+        return 0 if $ip->addr eq '0.0.0.0';
+
+        return 0 unless length param('ports')
+          and param('ports') =~ m/^[[:digit:]]+$/;
+
+        $happy = 1;
+    };
+
+    return $happy;
+}
+
+ajax '/ajax/content/admin/pseudodevice/add' => sub {
+    forward '/ajax/content/admin/pseudodevice'
+      unless _sanity_ok();
+
+    try {
+        schema('netdisco')->txn_do(sub {
+          my $device = schema('netdisco')->resultset('Device')
+            ->create({
+              ip => param('ip'),
+              dns => param('dns'),
+              vendor => 'netdisco',
+              last_discover => \'now()',
+            });
+
+          $device->ports->populate([
+            ['port'],
+            map {["Port$_"]} @{[1 .. param('ports')]},
+          ]);
+        });
+    };
+
+    forward '/ajax/content/admin/pseudodevice';
+};
+
 ajax '/ajax/content/admin/pseudodevice' => sub {
     my $set = schema('netdisco')->resultset('Device')
       ->search(
         {vendor => 'netdisco'},
         {order_by => { -desc => 'last_discover' }},
-      );
+      )->with_port_count;
 
     content_type('text/html');
     template 'ajax/admintask/pseudodevice.tt', {
diff --git a/Netdisco/share/public/css/netdisco.css b/Netdisco/share/public/css/netdisco.css
index d380136f..f16caa6e 100644
--- a/Netdisco/share/public/css/netdisco.css
+++ b/Netdisco/share/public/css/netdisco.css
@@ -196,6 +196,10 @@ td {
   margin-bottom: 2px;
 }
 
+.nd_inline_form {
+  display: inline;
+}
+
 /* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */
 /* tabs */
 
diff --git a/Netdisco/share/views/ajax/admintask/pseudodevice.tt b/Netdisco/share/views/ajax/admintask/pseudodevice.tt
index 98e73c98..a0be74e2 100644
--- a/Netdisco/share/views/ajax/admintask/pseudodevice.tt
+++ b/Netdisco/share/views/ajax/admintask/pseudodevice.tt
@@ -20,11 +20,18 @@
     </tr>
     [% WHILE (row = results.next) %]
     <tr>
+      <form name="update">
       <td class="center_cell"><a class="nd_linkcell"
         href="[% device_ports %]&q=[% row.dns | uri %]">[% row.dns | html_entity %]</a></td>
       <td class="center_cell">[% row.ip | html_entity %]</td>
-      <td class="center_cell">[% row.ports.count | html_entity %]</td>
-      <td class="center_cell"><a class="btn btn-small" href="#"><i class="icon-plus-sign"></i> Add</a></td>
+      <td class="center_cell"><input name="ports" type="number" value="[% row.port_count | html_entity %]"</td>
+      <td class="center_cell">
+        <button class="btn" name="update" type="submit"><i class="icon-save text-warning"></i></button>
+      </form>
+      <form name="del" class="nd_inline_form">
+        <button class="btn" name="del" type="submit"><i class="icon-trash text-error"></i></button>
+      </form>
+      </td>
     </tr>
     [% END %]
   </tbody>