From f9f06032f0a9c8708763f4464f57dc4d0342b093 Mon Sep 17 00:00:00 2001 From: Oliver Gorwits Date: Fri, 30 Sep 2022 21:55:50 +0100 Subject: [PATCH] revert change as check_acl_only is the right way to go --- lib/App/Netdisco/Worker/Plugin/Discover/Properties.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/App/Netdisco/Worker/Plugin/Discover/Properties.pm b/lib/App/Netdisco/Worker/Plugin/Discover/Properties.pm index a0ecc1ac..6f726d86 100644 --- a/lib/App/Netdisco/Worker/Plugin/Discover/Properties.pm +++ b/lib/App/Netdisco/Worker/Plugin/Discover/Properties.pm @@ -5,7 +5,7 @@ use App::Netdisco::Worker::Plugin; use aliased 'App::Netdisco::Worker::Status'; use App::Netdisco::Transport::SNMP (); -use App::Netdisco::Util::Permission 'check_acl_no'; +use App::Netdisco::Util::Permission qw/check_acl_no check_acl_only/; use App::Netdisco::Util::FastResolver 'hostnames_resolve_async'; use App::Netdisco::Util::Device 'get_device'; use App::Netdisco::Util::DNS 'hostname_from_ip'; @@ -66,7 +66,7 @@ register_worker({ phase => 'early', driver => 'snmp' }, sub { my $protect = setting('snmp_field_protection')->{'device'} || {}; my %dirty = $device->get_dirty_columns; foreach my $field (keys %dirty) { - next unless check_acl_no($ip, $protect->{$field}); + next unless check_acl_only($ip, $protect->{$field}); if (!defined $dirty{$field} or $dirty{$field} eq '') { return $job->cancel("discover cancelled: $ip failed to return valid $field"); }