373 Commits

Author SHA1 Message Date
Oliver Gorwits
a474e35cb9 tweak column size in users page 2019-08-22 17:51:54 +01:00
Oliver Gorwits
fcd07452c4 fix for #633 2019-08-19 16:52:56 +01:00
Oliver Gorwits
64fb05f556 fix for #633 2019-08-19 16:28:43 +01:00
Oliver Gorwits
8d863113d9 show how to package own radius dictionary files 2019-08-18 11:05:55 +01:00
Oliver Gorwits
26dbb714df #630 display full oui vendor 2019-08-18 10:49:57 +01:00
Oliver Gorwits
c73c3e7569 improvements to radius patch 2019-08-18 09:16:57 +01:00
David Sullivan
ad6dd2bb62 Change Port Free icon to be more accessible (#633)
The port free icon currently only differs from the port down icon by colour, on higher resolutions with a colour vision impairment they're not very distinguishable, a slightly different icon fixes this.
2019-08-16 09:49:40 +01:00
nick n
8a8deccdbe make sidebar tiny bit wider (#625) 2019-08-02 23:12:02 +01:00
nick n
4630879a1d add poe on/off icons to legend
inspired by the new wap icon
2019-07-19 06:45:44 +02:00
nick n
d1a1235c85 handle row.power.power being NULL
fixes this error, since device_port_power.power can be null:
Argument "" isn't numeric in numeric gt (>) at /home/netdisco/perl5/lib/perl5/auto/share/dist/App-Netdisco/views/ajax/device/ports.tt line 251.

currently only seen on cisco sb switches, which do have all other columns filled in
      ip       | port | module | admin |   status   | class  | power
---------------+------+--------+-------+------------+--------+-------
 10.40.254.150 | fa2  |      1 | true  | otherFault | class3 |
 10.40.254.150 | fa16 |      1 | true  | searching  | class3 |
 10.40.254.150 | fa3  |      1 | true  | searching  | class3 |
...
2019-07-19 04:16:06 +02:00
nick n
f1891be307 typo
noticed when checking docker config
2019-07-17 04:06:38 +02:00
Oliver Gorwits
039527c26a allow stats to run smoothly on ancient Pg 8.4 2019-06-12 11:51:20 +01:00
inphobia
5d5bfc9a68 Revert "fix #601"
This reverts commit ade14665fc.
2019-06-02 01:13:44 +02:00
nick n
ade14665fc fix #601
this broke all kinds of stuff, will need new netdisco release asap.

yet 1 more reason to work harder on my html5 transition
2019-06-01 22:51:10 +02:00
Oliver Gorwits
2c138a5690 #581 skip storing and displaying fabricated vlan 0 2019-05-30 06:58:34 +01:00
Oliver Gorwits
262fa88009 #585 make toastr notifications less annoying 2019-05-27 12:53:56 +01:00
Oliver Gorwits
744da684de #594 add PK to device_port_log and other tidying 2019-05-27 12:47:50 +01:00
nick n
e65f7b84c8 dbic sync between actual db & our functions/docs (#595) 2019-05-27 12:39:07 +01:00
nick n
cd2a4b9362 html template fixups (#576)
* none is not a valid value for min-width, so set it to zero

* these 2 "checked" if statements need a space in front of them,
else they will attach to the previous element

id="nd_showspeed"checked="checked"

* multiple tag has no options according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select

also, don't close select before we've gotten to the option tags

* multiple tag has no options according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select

also, don't close select before we've gotten to the option tags

* just to be sure put a space in front of these optional tags as well,

* $a is technically allowed but is considered not best practice
2019-05-12 08:32:42 +01:00
Oliver Gorwits
a4d4bf7f33 #568 use different icon for WAPs from clients 2019-04-28 20:52:37 +01:00
Oliver Gorwits
8f1f35abab fix inconsistency in titlebar global search when port is selected 2019-04-16 17:10:13 +01:00
nick n
fd4752897d netdisco rancid updates (#558)
* typo

* make this a link

* netdisco-rancid-export has been replaced

* rancid worker config

* netdisco-rancid-export now a no-op

* note debugging option
2019-04-05 01:28:30 +02:00
Oliver Gorwits
b22c32a578 better sql update, fixed worker return, better logic on vlans 2019-04-01 22:36:35 +01:00
Oliver Gorwits
a6e7943c03 #528 record egress untagged vlans in device_port_vlan table 2019-04-01 14:38:27 +01:00
Oliver Gorwits
3e1541071c #552 device addresses report has broken column data 2019-04-01 12:56:36 +01:00
pyro3d
cbf23e467a Fix clickability of port log/control icons in port list display (#556) 2019-04-01 10:49:50 +01:00
Oliver Gorwits
4575aab888 Make more room for port log/control icons in port list display (#555) 2019-03-31 15:28:32 +01:00
nick n
3e5e7d36cc whitespace cleanup (#547)
* whitespace

* start tbody correctly
2019-03-23 09:28:43 +00:00
nick n
7ad712d79a missing closing anchor tag 2019-03-23 02:40:47 +01:00
nick n
3f407685b1 unneeded question marks 2019-03-23 02:07:17 +01:00
Oliver Gorwits
4ef5691bb5 allow pseudo devices to arpnip 2019-03-19 13:05:47 +00:00
Oliver Gorwits
46d8c52a08 Implement changes for API authentication and Swagger UI (#541)
* initial token-based-api login handler

* add token schema and validation

* initial import of pyro3d api code

* basic Swagger spec support

* Merge in working copy of API/Device.pm

* Fix some error handling for API/Device.pm

* Break out utility functions into separate file, to allow other api portions to use

* Add NodeIP support.

* Add nodeip plugin to config

* remove double define of "plugin:" (#448)

disclaimer: i did not test this is any way, came across it when looking for something else.

* only AuthZ header for api use, and alway regen key on login

* use RFC7235

* workaround for Swagger plugin weird response body

* do not autodiscover swagger routes

* code formatting only

* move api util to utils area

* initial full swagger spec for nodeip search

* add api user role and fix api auth failure response

* update version of swagger-ui to 3.20.3

* add more openapi defs

* fixes to SQL and api spec

* clean up subs

* improvements to login/logout for API

* make api logout work

* add openapi tags to group operations

* allow api params to be generated from DBIC schema spec

* remove API calls for nodes and devices

* remove some poor assumptions about api calls

* tidy up

* remove DDP

* make login and logout similar

* example of api call being handled by ajax call

* make the branch authonly
2019-03-17 20:27:19 +00:00
Oliver Gorwits
9b39d1e452 rename CLI Transport to SSH 2019-03-13 22:23:38 +00:00
Oliver Gorwits
d44a8f56ea Integrate netdisco-sshcollector into Worker::Plugin architecture (#489) (#535)
* update changes and SNMP::Info dep

* Integrate netdisco-sshcollector into Worker::Plugin architecture (#489)

* Initial integration of sshcollector into Worker::Plugin architecture

 * add NodesBySSH.pm
 * update Build.PL and config.yml to integrate the new module

* Further integration of sshcollector into Worker::Plugin architecture

 * added App::Netdisco::Transport::CLI loosely based on ::SNMP counterpart
 * switched to the more prevalent two-space tabs style
 * removed various TBD items, some new ones

* Further steps to integration of sshcollector into Worker::Plugin architecture

 * cleaned up code
 * added various error handling
 * warning for bin/netdisco-sshcollector deprecation
 * device_auth allows passing master_opts to Net::OpenSSH
 * netdisco-do -D also toggles Net::OpenSSH debug

* Merged NodesBySSH.pm into Nodes.pm

 * see https://github.com/netdisco/netdisco/pull/489#pullrequestreview-205603516

* Further integration of sshcollector into Worker::Plugin architecture

 * add snmp_arpnip_also option to sshcollector device_auth
 * cleanup code

* Remove big TBD: comment from CLI.pm as doc is updated now

* add transport/cli.pm to manifest

* revert some changes to allow simpler merging

* silent exit legacy script unless explicitly requested

* move ssh code into Transport, part one

* rewrite the CLI transport to provide an API

* merge in og-get_external_credentials

Squashed commit of the following:

commit 3fe8f383a7
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon Mar 11 17:07:42 2019 +0000

    add debug lines and tested

commit 3249739e42
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon Mar 11 16:54:11 2019 +0000

    change config name to get_credentials

commit e78558397a
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon Mar 11 16:51:11 2019 +0000

    separate out generic device auth to DeviceAuth module

commit 249f05165f
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Wed Mar 6 18:43:31 2019 +0000

    release 2.040007

commit e3af64df77
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Wed Mar 6 18:42:47 2019 +0000

    #521-redux fix wifi date search

commit 48857ae300
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon Mar 4 12:03:31 2019 +0000

    release 2.040006

commit e09dab5362
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon Mar 4 11:39:12 2019 +0000

    #527 update List::MoreUtils version requirement

commit 6e7de3fff3
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon Mar 4 09:59:41 2019 +0000

    release 2.040005

commit 0c98318a45
Author: Oliver Gorwits <oliver@spike.local>
Date:   Mon Mar 4 09:57:18 2019 +0000

    #526 fix discover syntax bug

commit e9efc45182
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 14:56:48 2019 +0000

    release 2.040004

commit 6cdfd80d10
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 14:34:00 2019 +0000

    allow undiscovered neighbors report to use discover_{waps,phones} setting

commit ac381e0802
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 14:13:20 2019 +0000

    #506 was a red herring

commit b83e614c85
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 13:00:36 2019 +0000

    make discover_{phones,waps} work with LLDP capabilities as well

commit 189d234b55
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 12:47:38 2019 +0000

    check discover_no_type and friends earlier on in neighbors list build

commit 9c956466f3
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 12:32:07 2019 +0000

    also update default config for new discover_phones and discover_waps settings

commit 09d29954d2
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 12:26:50 2019 +0000

    #512 fix regression in phone/wap discovery exclusion

commit 2bae91f1b6
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 12:01:34 2019 +0000

    rename match_devicetype() to match_to_setting()

commit 57cb6ddb70
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun Mar 3 09:19:39 2019 +0000

    fix for over-eager fix to #506

commit ef560fb59a
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 22:41:40 2019 +0000

    #506 relax device renumber so it works for an alias

commit 7a8bcb094e
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 22:23:39 2019 +0000

    #521 Search Node Date Range not working

commit a643820a62
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 21:54:27 2019 +0000

    #428 Port-Channels not showing in netmap

commit 5ba5bcd295
Merge: e7aacddb a1f95028
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 20:04:11 2019 +0000

    Merge branch 'master' of github.com:netdisco/netdisco

commit e7aacddbc6
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 20:01:05 2019 +0000

    #498 Map with VLAN filter omits unconnected devices

commit a1f95028ca
Author: nick n <39005454+inphobia@users.noreply.github.com>
Date:   Sat Mar 2 19:54:22 2019 +0100

    catch up with changes

    noticed that rc-sshcollector-core received updates to changes, add them here as well.

    didn't mention #499 & #522

commit ce1b847cea
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 18:47:44 2019 +0000

    fix bug showing no nodes when only one matches in netmap

commit 78e30a7926
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 16:28:15 2019 +0000

    #500 filtering in device/ports on native vlan duplicates entries

commit 9952f0c6c7
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 15:02:12 2019 +0000

    #499 netdisco-do renumber reports wrong ip (inphobia)

commit ca3fd8f466
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 15:00:18 2019 +0000

    #505 device renumber should update device port properties and device skips

commit 1265bc8470
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 14:52:21 2019 +0000

    #520 catch slave ports defined without a master

commit d4c7579c10
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 14:47:49 2019 +0000

    #522 TypeAhead.pm can reference empty data (inphobia)

commit 77decc23b7
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 2 14:45:37 2019 +0000

    #514 inconsistent results in ip inventory (inphobia)

commit 3f211650b8
Author: nick n <39005454+inphobia@users.noreply.github.com>
Date:   Fri Mar 1 12:34:42 2019 +0100

    last pieces for db schema upgrade

    last piece of #510

* import legacy sshcollector config

* add default use_legacy_sshcollector config

* remove unneeded deps

* various fixes and now tested

* enable sshcollector platform tests
2019-03-12 18:50:24 +00:00
Oliver Gorwits
b9218d91c8 Support for external command to provide device_auth stanza (#532)
* separate out generic device auth to DeviceAuth module

* change config name to get_credentials

* add debug lines and tested
2019-03-12 13:13:06 +00:00
Oliver Gorwits
9c956466f3 also update default config for new discover_phones and discover_waps settings 2019-03-03 12:32:07 +00:00
Oliver Gorwits
09d29954d2 #512 fix regression in phone/wap discovery exclusion 2019-03-03 12:26:50 +00:00
ram
c2600ac550 Change location of ifindex to DevicePortProperties
* instead of DevicePort
* as requested by Oliver in PR #513 review
2019-02-23 15:26:38 +01:00
ram
24a7e80470 PR for #510 - store ifindex in device_port 2019-02-23 15:26:38 +01:00
nick n
fe70b01bcc i think end anchor should be in the if clause (#493) 2019-01-26 22:09:55 +00:00
nick n
6a36baa961 add a new tab to device -> vlans (#483)
* first steps for vlan tab

* export sort_vlans, use strict/warnings

* update manifest, get worker closer to functioning

* remove ie 9 script & extra ./th

* make it work

* cleanup

* readd internet explorer code

* start for csv output

* move things to debug logging instead of info

* use message which was discussed

* fix for address table sorting

* link os

* final touches thx to ollyg

* fetch origin/master

* VLAN is the preferred style for user interface usage

* does a missing libexpat-dev make travis builds complain?

* Revert "does a missing libexpat-dev make travis builds complain?"

This reverts commit 0cebc66f42708ff0f946213aab4bcbcc1b1b1379.
2019-01-14 21:57:37 +00:00
Oliver Gorwits
562d525b78 #420 allow sidebar default to be overridden 2019-01-08 21:27:15 +00:00
Oliver Gorwits
cf93219b42 #420 change to better column name 2019-01-08 21:19:08 +00:00
nick n
8f952ce2e3 option to fix #457 (#481)
* move things to debug logging instead of info

* use message which was discussed

* fix for address table sorting
2019-01-08 20:53:46 +00:00
nick n
40df018ead also make os a link in device details (#482) 2019-01-08 20:53:17 +00:00
Oliver Gorwits
b3f6ffe0d7 #424 column name is "Connected Nodes & Devices" when both are shown 2019-01-03 23:12:52 +00:00
nick n
272901204b remote stray </th>
firefox said:

XML Parsing Error: mismatched tag. Expected: </tr>.
Location: http://xxx/ajax/content/statistics
Line Number 59, Column 17:

you know what, it was right.
2019-01-03 20:45:43 +01:00
nick n
485abbc9bd trailing whitespace 2018-12-30 07:52:27 +01:00
nick n
5fb9d52278 reference wiki, not nonexisting manual 2018-12-30 00:26:07 +01:00
Oliver Gorwits
b4e5dc7af7 #422 Network map positions will not save (onlinehupe) 2018-12-28 17:56:12 +00:00