Commit Graph
1921 Commits
Author SHA1 Message Date
Oliver Gorwits 11e49671fd #388 searching for 0.x.x.x returns Internal Server Error (C. Neuhaus) 2018-04-10 21:22:06 +01:00
Oliver Gorwits 6ee946cca6 #389 build/upgrade issues (EL6) 2018-04-10 21:13:48 +01:00
Brian De WolfandOliver Gorwits bebaaba626 fix sshcollector errors when devices are empty (#391)
While setting up an sshcollector, I found that the script doesn't handle an
arpless device very gracefully.  The log looks like:

	[46567] 2018-04-10 16:59:08  warn WARNING: no entries received from <IP>
	Can't use string ("1") as an ARRAY ref while "strict refs" in use at perl5/bin/netdisco-sshcollector line 114, <__ANONIO__> line 3.

This is fixed by making the process function always return the expected
structure, even if it's empty.  After this error, the following errors showed
up:

	[53232] 2018-04-10 17:06:15  warn WARNING: no entries received from <IP>
	[53210] 2018-04-10 17:06:15  info  [134.71.0.126] arpnip - retrieved 0 entries
	Use of uninitialized value in sprintf at perl5/bin/netdisco-sshcollector line 119, <__ANONIO__> line 3.
	[53210] 2018-04-10 17:06:15  info arpnip - processed  ARP Cache entries from 1 devices

This is because $stats{entry} only becomes an integer by being incremented, so
if there aren't any entries, it never exists.  This is fixed by starting it at 0.
2018-04-10 21:12:20 +01:00
Oliver Gorwits 454ededa46 Revert "#380 attempt to resolve port name when it is given wrong"
This reverts commit f4a143612b.
2018-04-10 21:03:10 +01:00
Oliver Gorwits 08a5652ae0 Revert "save a device_port lookup"
This reverts commit d19b2fac93.
2018-04-10 20:58:07 +01:00
Oliver Gorwits 67ee1808b6 Revert "better way to construct short interface name"
This reverts commit 8bcfaf12d0.
2018-04-10 20:58:06 +01:00
Oliver Gorwits 00f3f2a796 Revert "work for shortening or lengthening ports"
This reverts commit 9d48c4a025.
2018-04-10 20:58:05 +01:00
Oliver Gorwits 52e14aeeeb Revert "no need for quotemeta"
This reverts commit 9339c1a2ce.
2018-04-10 20:58:02 +01:00
Oliver Gorwits 9339c1a2ce no need for quotemeta 2018-04-09 23:15:58 +01:00
Oliver Gorwits 9d48c4a025 work for shortening or lengthening ports 2018-04-09 23:05:17 +01:00
Oliver Gorwits 8bcfaf12d0 better way to construct short interface name 2018-04-09 22:58:23 +01:00
Oliver Gorwits d19b2fac93 save a device_port lookup 2018-04-08 13:22:52 +01:00
Oliver Gorwits 60e22dda3c Merge branch 'master' into og-remoteport-fix 2018-04-08 13:13:04 +01:00
Oliver Gorwits 7a481282c0 allow empty description 2018-04-08 13:11:02 +01:00
Oliver Gorwits 02c9da4e99 do not require remote_port to exist at remote_ip
this has a bug whereby if the list of remote_ports is not the same
size as the list of real matching ports, then the list of port names
will be short, and port descriptions may be assigned to the wrong
ports, or the query may crash. needs testing.
2018-04-08 00:55:36 +01:00
Oliver Gorwits 8e30dec24f protect against undef mac (l.e. ferguson) 2018-04-08 00:09:46 +01:00
Oliver Gorwits 97d5501ba0 do not include logical aggregate masters in netmap/speed calc 2018-04-07 23:59:59 +01:00
Oliver Gorwits 927f2f0a74 #390 cannot take logarithm of zero (C. Stromsoe) 2018-04-07 23:27:11 +01:00
Oliver Gorwits 87d42eacac enforce single row return 2018-04-07 23:24:53 +01:00
Oliver Gorwits f4a143612b #380 attempt to resolve port name when it is given wrong 2018-04-07 23:17:23 +01:00
Oliver Gorwits f7ca094e26 release 2.039020 2018-03-26 22:59:11 +01:00
Oliver Gorwits d9a0103150 fix case insensitive username match for LDAP 2018-03-26 22:57:01 +01:00
Oliver Gorwits 3d5a26266e better link speed names on network map 2018-03-24 11:33:09 +00:00
Oliver Gorwits e6a2fff30f release 2.039019 2018-03-23 09:54:52 +00:00
Oliver Gorwits d89c25b60a fix device search SQL error (reported by bhuddah) 2018-03-23 09:53:57 +00:00
Oliver Gorwits c8d05f9eb8 release 2.039018 2018-03-22 21:38:56 +00:00
Oliver Gorwits 850610f6b0 network map working with pseudo devices 2018-03-22 21:22:58 +00:00
Oliver Gorwits b3457954a3 access to manual topology for admins without port_control role 2018-03-22 17:17:27 +00:00
Oliver Gorwits 3ae4eabd39 #12 store Cisco PortFast status in device_port_properties:faststart 2018-03-21 10:53:09 +00:00
Oliver Gorwits ea9ac1c1a1 #371 usernames are case insensitive but case preserving 2018-03-21 09:23:11 +00:00
Oliver Gorwits 44014fe415 release 2.039017 2018-03-20 10:11:38 +00:00
Oliver Gorwits 7529a93501 #382 invaid regexp syntax 2018-03-20 10:10:41 +00:00
Oliver Gorwits 9aa43616bb release 2.039016 2018-03-19 23:11:18 +00:00
Oliver Gorwits 72b64048bb fix netmap position saving 2018-03-19 22:58:14 +00:00
Oliver Gorwits 6b3e4ceba7 auto save map positions 2018-03-19 19:01:11 +00:00
Oliver Gorwits 938b375df6 #381 LLDP port name is space compressed 2018-03-19 18:22:45 +00:00
Oliver Gorwits 90cfac5e7a rename device_groups to host_groups in netmap positions 2018-03-19 18:15:50 +00:00
Oliver Gorwits a2ce65c8b8 working folters and colors for host group and location 2018-03-19 17:47:22 +00:00
Oliver Gorwits bf87615a8a better size for group selector 2018-03-19 16:09:14 +00:00
Oliver Gorwits 43edd06b56 use port type filter for links instead of ethernetCsmacd
per is_vlan_interface from App::Netdisco::Util::Port
see also https://www.iana.org/assignments/ianaiftype-mib/ianaiftype-mib
2018-03-19 14:30:11 +00:00
Oliver Gorwits b1bfb04bb1 add menu option to run stats job 2018-03-19 11:48:13 +00:00
Oliver Gorwits f6157e3941 fix style on checkbox in device netmap report 2018-03-19 11:43:25 +00:00
Oliver Gorwits 1ba1ea2e27 better handling of malformed IPs in c_ip results 2018-03-17 14:57:13 +00:00
Oliver Gorwits fb42c871c1 add interface alias for discovery IP 2018-03-17 14:24:05 +00:00
Oliver Gorwits 680998a82c better color by setting as dropdown 2018-03-10 21:53:48 +00:00
Oliver Gorwits 9205cb0834 finally a decent netmap sidebar 2018-03-10 20:22:24 +00:00
Oliver Gorwits 74e6b2f685 more work on netmap sidebar 2018-03-10 19:30:24 +00:00
Oliver Gorwits 2770cda090 fix tooltip for locations 2018-03-10 17:07:27 +00:00
Oliver Gorwits 695ce04f77 fix radio group 2018-03-10 17:03:16 +00:00
Oliver Gorwits 22e6e7a2d8 initial location filtering 2018-03-10 14:27:04 +00:00