Commit Graph

337 Commits

Author SHA1 Message Date
ram
24a7e80470 PR for #510 - store ifindex in device_port 2019-02-23 15:26:38 +01:00
nick n
1620feaa6a tiny typo
iteself -> itself
2019-02-22 22:53:20 +01:00
Christian Ramseyer
dc9feb747f Merge ASA.PM patch by stromsoe (#494}
* Embedded # characters in the output for show names cause sshcollector not to collect any ARP entries on the ASA platform, since the $prompt variable matches in the middle of the output. Fix is to modify $prompt to match end-of-line.
 * Changing the terminal pager length should be done before sending show names instead of after.
 * Matching on IP address to see if a name needs to be mapped should include start and end field markers, in the event that the name returned from "show arp" embeds an IP address (eg, "abc1.2.3.4xyz")
2019-01-29 23:40:43 +01:00
Oliver Gorwits
914e484b33 #490 use new checks for uplink and phone on port 2019-01-26 23:23:12 +00:00
nick n
e6d087ef5f fix for #491 (untested) (#492)
* move things to debug logging instead of info

* use message which was discussed

* merge master

* fix for #491. also use doublequotes in sprintf in portcontrol.pm line 59, else $device will not be printed
2019-01-24 14:12:06 +00:00
nick n
89b8f8c0ce allow snmp::info base class in netdisco-do (#486)
* allow the use of base snmp::info

* dont use .

* should have been: dont use $_

* also document some extra features

* reword
2019-01-14 22:02:08 +00:00
nick n
6a36baa961 add a new tab to device -> vlans (#483)
* first steps for vlan tab

* export sort_vlans, use strict/warnings

* update manifest, get worker closer to functioning

* remove ie 9 script & extra ./th

* make it work

* cleanup

* readd internet explorer code

* start for csv output

* move things to debug logging instead of info

* use message which was discussed

* fix for address table sorting

* link os

* final touches thx to ollyg

* fetch origin/master

* VLAN is the preferred style for user interface usage

* does a missing libexpat-dev make travis builds complain?

* Revert "does a missing libexpat-dev make travis builds complain?"

This reverts commit 0cebc66f42708ff0f946213aab4bcbcc1b1b1379.
2019-01-14 21:57:37 +00:00
nick n
0205a11f01 makerancidconf overhaul
* Use the Fullname in top bar of Web interface and not the login

* Implement the following parameters:
 - add a rancid_conf parameter to retrieve the existing type for RANCID devices
 - add the default_group parameter to add devices in this group if they doesn't match the other parameters
 - add the hability to work with the RANCID version in https://github.com/earendilfr/rancid with subdirectory for the configuration files

* Fix following issues:
- Problem during the check of ACL when we have a negate character. The begate character is deleted during the first check
- The renumber function doesn't want to start

* Revert "Fix following issues:"

This reverts commit a8d9e8200a925b1a4d24374827d3fd5146f85b40.

* Revert "Implement the following parameters:"

This reverts commit aa29ca924cd92943490e4a2420a3972054e81e41.

* Add the following parameters to the MakeRancidConf:

 + Change the default delimiter character from ':' to ';' that is the default RANCID delimiter since
   RANCID 3.x
 + Add an option to define the rancid config directory.
   This directory will be used to extract the vendor defined in the RANCID configuration to avoid to extract
   unexisting vendor devices in RANCID configuration (by example, Ubiquiti AirOS devices).
 + Add an option to define a default_group.
   If a device doesn't match the defined group, it will add to this group
 + Add an option to defined a manually excluded ACL
   To permit to not export devices from Netdisco to RANCID based on an ACL.

* New version of the pull request to merge the makerancid improvment.
I have fixe some errors that have impact the revert for the PR #408

I have manually check on my instance and didn't see any warning on the result of the command netdisco-do makerancidconf

* Fix an issue if the by_ip group not exist in the RANCiD part of configuration

* Print the entry sorted in the router.db file

* testing if the sql in #436 can be integrated

* a bit of documentation cleanup

* a few more doc fixes

* minor docs changes

* rename rancid_home to rancid_cvsroot, which is how the setting is defined in rancid. this should make things clearer

* a bit more in-depth examples. allow for more device types (allow - in their name). use strict & warnings

* just to many caps
2019-01-14 01:56:32 +01:00
nick n
98a5e2c407 #479 part 2, use debug logging instead of info (#480)
#479 part 2, use debug instead of info logging.

2 whitespace cleanups also included, as well as rewording props -> properties like in the rest of portproperties.pm
2019-01-08 01:50:21 +01:00
Oliver Gorwits
1b2592321d address https://metacpan.org/pod/distribution/perl/pod/perldelta.pod#Removal-of-use-vars 2019-01-07 22:51:05 +00:00
Oliver Gorwits
7f1074ff84 #479 attempt better cache control for device ports 2019-01-07 22:47:13 +00:00
Oliver Gorwits
23a87f19fd be less strict about finding the IP for logging 2019-01-03 23:29:14 +00:00
Oliver Gorwits
1dc3e70e37 fix to hopefully catch txrate and rate being scalar not list, as reported by inphobia 2019-01-03 22:59:33 +00:00
Oliver Gorwits
7811c32147 fix cached ports list which needs to be complete rows for Neighbors.pm to work 2019-01-03 22:56:17 +00:00
Oliver Gorwits
ccb0f0c78a #475 fix discover plugins do not respect ignore* config 2019-01-02 22:36:59 +00:00
Oliver Gorwits
5bc0afa2f5 #476 log on delete for rows from related tables 2019-01-02 21:44:36 +00:00
Oliver Gorwits
3769b7b66b fix to the fix for ospf_routers discovery 2019-01-02 20:56:41 +00:00
Oliver Gorwits
6a986783e4 fix to the fix for ospf_routers discovery 2019-01-02 20:54:50 +00:00
Oliver Gorwits
d614382fcd #436 new SQL query for neigbor map to allow mismatched/one-way links (Linwood-F) 2019-01-02 20:37:19 +00:00
Oliver Gorwits
505b7b5625 #471 fix bug in checking if there are OSPF router IDs to poll 2019-01-02 20:21:34 +00:00
Oliver Gorwits
b445d237e4 #471 OSPF Neighbor Discovery by router ID 2018-12-28 17:32:40 +00:00
nick n
8aed736925 ignore notpresent interfaces, with type filtering config item (set to [] to not filter). work done by postilion/nic bernstein, filter by me. also includes trailing space fix by nic. (#464) 2018-12-28 16:08:40 +00:00
nick n
86c38c9466 make job queue list in webinterface configurable (#469)
* add an option so you can define the amount of jobs returned in the webinterface jobq

* and now the actually working version
2018-12-28 16:01:40 +00:00
Christian Ramseyer
f5622929e0 Provide stdin to IOSXR.pm when none available (#462)
* See issue #461 for a detailed description
2018-12-28 14:33:02 +00:00
nick n
733f82c3dc 2 typos 2018-12-13 22:52:48 +01:00
Mohammad S Anwar
369590d17f Fixed pod error as reported by CPANTS. (#456) 2018-11-27 11:18:45 +00:00
Oliver Gorwits
3ddc1a3c8a #446 fix typo in NodeVendor report - rflor 2018-10-19 21:33:58 +01:00
Oliver Gorwits
847d7e16e3 #443 attempt to handle IPs and Names in show arp output - darknicht66 2018-10-19 15:31:31 +01:00
Oliver Gorwits
ffa2aefd8d Revert "#432 fix regexp for arp display - stromsoe"
This reverts commit 75507ed521.
2018-10-19 15:29:32 +01:00
Oliver Gorwits
75507ed521 #432 fix regexp for arp display - stromsoe 2018-10-19 15:25:36 +01:00
Oliver Gorwits
ea2fde1e56 #439 add expire_userlog with default 365 days 2018-10-19 15:11:26 +01:00
Oliver Gorwits
fb3ef12854 in fact localtime is correct if server admin runs server in GMT
Revert "#441 change localtime to gmtime"

This reverts commit 779e0a618d.
2018-10-19 15:08:38 +01:00
Oliver Gorwits
2818591462 #431 sshcollector calls die() even if all the work is not done - stromsoe 2018-10-19 14:59:32 +01:00
Oliver Gorwits
779e0a618d #441 change localtime to gmtime 2018-10-19 14:49:03 +01:00
slofunk
00ac3cff4a update NodeVendor.pm (#427)
It would seem like we'd want for this to be distinct mac addresses here right? Otherwise you'd could get duplicate counters. In our environment where things move around this makes for repeat lines in the nodes table. To get a true inventory count I'd think this should only count unique macs. Apologies if this is NOT the desired output for this module.
2018-10-19 14:42:37 +01:00
Oliver Gorwits
e39cf197bf further tune job picker 2018-06-17 21:55:18 +01:00
Oliver Gorwits
13d5f04465 #419 "neigh - discrepancy in IP" due to differences in IPv6 formatting 2018-06-08 10:56:16 +01:00
Oliver Gorwits
0cce3b3834 jobs with username are only allowed one attempt to unskip 2018-06-07 23:17:13 +01:00
Oliver Gorwits
87f1297f25 Merge branch 'og-2.040' 2018-05-09 06:50:55 +01:00
Oliver Gorwits
d959adde36 issue DB schema statements each within savepoints 2018-05-09 06:07:30 +01:00
Oliver Gorwits
3d27184b1c #414 clicking discover button with empty field causes crash 2018-05-08 22:33:31 +01:00
Oliver Gorwits
d7a0bec20b device port search will match on Description as well as Port 2018-05-07 17:34:13 +01:00
Oliver Gorwits
a97780201d Revert "Squashed commit of the following:"
This reverts commit 232df96457.
2018-05-07 17:25:24 +01:00
Oliver Gorwits
6098b893ad #410 improvements to Undiscovered Neighbors report 2018-05-07 17:15:11 +01:00
Oliver Gorwits
232df96457 Squashed commit of the following:
commit 43a3729a206c8d04f9e156d1d811a1b7cfb84089
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun May 6 22:44:09 2018 +0100

    #408 improvements to MakeRancidConf (earendilfr)

commit 205911175ef52e0107ca59b96f51fee393120582
Author: Ambroise <earendil@toleressea.fr>
Date:   Thu Apr 26 17:44:15 2018 +0200

    Add the following parameters to the MakeRancidConf:

     + Change the default delimiter character from ':' to ';' that is the default RANCID delimiter since
       RANCID 3.x
     + Add an option to define the rancid config directory.
       This directory will be used to extract the vendor defined in the RANCID configuration to avoid to extract
       unexisting vendor devices in RANCID configuration (by example, Ubiquiti AirOS devices).
     + Add an option to define a default_group.
       If a device doesn't match the defined group, it will add to this group
     + Add an option to defined a manually excluded ACL
       To permit to not export devices from Netdisco to RANCID based on an ACL.
2018-05-06 22:46:57 +01:00
Oliver Gorwits
0d8cd3e764 #411 store_modules: false is ignored 2018-05-05 16:12:43 +01:00
Oliver Gorwits
fa6f70ac8a #413 manual retrigger of discovery does not work 2018-05-05 16:00:14 +01:00
Oliver Gorwits
c0fcc7f5d5 #405 Inventory reports default to all time to fix missing IPs 2018-04-28 22:10:11 +01:00
Oliver Gorwits
342e9e5cc3 #406 error in check_mac() params causing NBTStat failure 2018-04-28 13:09:18 +01:00
Brian De Wolf
2f2c9f6b26 Improve Palo Alto SSH Collector support (#397)
The PAN CLI tries to do friendly auto-completion things and makes the SSH
Collector fail sporadically.  This change uses the "set cli scripting-mode on"
command to calm down the PAN CLI and works around the extra echoed prompts that
get sent.

This change also adds collection of IPv6 neighbor information.
2018-04-28 11:43:01 +01:00