* typo
* make this a link
* netdisco-rancid-export has been replaced
* rancid worker config
* netdisco-rancid-export now a no-op
* note debugging option
* update changes and SNMP::Info dep
* Integrate netdisco-sshcollector into Worker::Plugin architecture (#489)
* Initial integration of sshcollector into Worker::Plugin architecture
* add NodesBySSH.pm
* update Build.PL and config.yml to integrate the new module
* Further integration of sshcollector into Worker::Plugin architecture
* added App::Netdisco::Transport::CLI loosely based on ::SNMP counterpart
* switched to the more prevalent two-space tabs style
* removed various TBD items, some new ones
* Further steps to integration of sshcollector into Worker::Plugin architecture
* cleaned up code
* added various error handling
* warning for bin/netdisco-sshcollector deprecation
* device_auth allows passing master_opts to Net::OpenSSH
* netdisco-do -D also toggles Net::OpenSSH debug
* Merged NodesBySSH.pm into Nodes.pm
* see https://github.com/netdisco/netdisco/pull/489#pullrequestreview-205603516
* Further integration of sshcollector into Worker::Plugin architecture
* add snmp_arpnip_also option to sshcollector device_auth
* cleanup code
* Remove big TBD: comment from CLI.pm as doc is updated now
* add transport/cli.pm to manifest
* revert some changes to allow simpler merging
* silent exit legacy script unless explicitly requested
* move ssh code into Transport, part one
* rewrite the CLI transport to provide an API
* merge in og-get_external_credentials
Squashed commit of the following:
commit 3fe8f383a7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 11 17:07:42 2019 +0000
add debug lines and tested
commit 3249739e42
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 11 16:54:11 2019 +0000
change config name to get_credentials
commit e78558397a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 11 16:51:11 2019 +0000
separate out generic device auth to DeviceAuth module
commit 249f05165f
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Mar 6 18:43:31 2019 +0000
release 2.040007
commit e3af64df77
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Mar 6 18:42:47 2019 +0000
#521-redux fix wifi date search
commit 48857ae300
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 4 12:03:31 2019 +0000
release 2.040006
commit e09dab5362
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 4 11:39:12 2019 +0000
#527 update List::MoreUtils version requirement
commit 6e7de3fff3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 4 09:59:41 2019 +0000
release 2.040005
commit 0c98318a45
Author: Oliver Gorwits <oliver@spike.local>
Date: Mon Mar 4 09:57:18 2019 +0000
#526 fix discover syntax bug
commit e9efc45182
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 14:56:48 2019 +0000
release 2.040004
commit 6cdfd80d10
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 14:34:00 2019 +0000
allow undiscovered neighbors report to use discover_{waps,phones} setting
commit ac381e0802
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 14:13:20 2019 +0000
#506 was a red herring
commit b83e614c85
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 13:00:36 2019 +0000
make discover_{phones,waps} work with LLDP capabilities as well
commit 189d234b55
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:47:38 2019 +0000
check discover_no_type and friends earlier on in neighbors list build
commit 9c956466f3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:32:07 2019 +0000
also update default config for new discover_phones and discover_waps settings
commit 09d29954d2
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:26:50 2019 +0000
#512 fix regression in phone/wap discovery exclusion
commit 2bae91f1b6
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:01:34 2019 +0000
rename match_devicetype() to match_to_setting()
commit 57cb6ddb70
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 09:19:39 2019 +0000
fix for over-eager fix to #506
commit ef560fb59a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 22:41:40 2019 +0000
#506 relax device renumber so it works for an alias
commit 7a8bcb094e
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 22:23:39 2019 +0000
#521 Search Node Date Range not working
commit a643820a62
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 21:54:27 2019 +0000
#428 Port-Channels not showing in netmap
commit 5ba5bcd295
Merge: e7aacddba1f95028
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 20:04:11 2019 +0000
Merge branch 'master' of github.com:netdisco/netdisco
commit e7aacddbc6
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 20:01:05 2019 +0000
#498 Map with VLAN filter omits unconnected devices
commit a1f95028ca
Author: nick n <39005454+inphobia@users.noreply.github.com>
Date: Sat Mar 2 19:54:22 2019 +0100
catch up with changes
noticed that rc-sshcollector-core received updates to changes, add them here as well.
didn't mention #499 & #522
commit ce1b847cea
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 18:47:44 2019 +0000
fix bug showing no nodes when only one matches in netmap
commit 78e30a7926
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 16:28:15 2019 +0000
#500 filtering in device/ports on native vlan duplicates entries
commit 9952f0c6c7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 15:02:12 2019 +0000
#499 netdisco-do renumber reports wrong ip (inphobia)
commit ca3fd8f466
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 15:00:18 2019 +0000
#505 device renumber should update device port properties and device skips
commit 1265bc8470
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 14:52:21 2019 +0000
#520 catch slave ports defined without a master
commit d4c7579c10
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 14:47:49 2019 +0000
#522 TypeAhead.pm can reference empty data (inphobia)
commit 77decc23b7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 14:45:37 2019 +0000
#514 inconsistent results in ip inventory (inphobia)
commit 3f211650b8
Author: nick n <39005454+inphobia@users.noreply.github.com>
Date: Fri Mar 1 12:34:42 2019 +0100
last pieces for db schema upgrade
last piece of #510
* import legacy sshcollector config
* add default use_legacy_sshcollector config
* remove unneeded deps
* various fixes and now tested
* enable sshcollector platform tests
* Improve netdisco-sshcollector CLI experience
* add -d <device>
* add -O debug option to toggle Net::OpenSSH::debug
* add -w MCE::Loop max_workers
* updated POD for all of the above
* Fix -Q documentation
* Specifying -Q multiple times has no effect, removed part talking about that.
* Emit Net::OpenSSH connection failures as warnings
While setting up an sshcollector, I found that the script doesn't handle an
arpless device very gracefully. The log looks like:
[46567] 2018-04-10 16:59:08 warn WARNING: no entries received from <IP>
Can't use string ("1") as an ARRAY ref while "strict refs" in use at perl5/bin/netdisco-sshcollector line 114, <__ANONIO__> line 3.
This is fixed by making the process function always return the expected
structure, even if it's empty. After this error, the following errors showed
up:
[53232] 2018-04-10 17:06:15 warn WARNING: no entries received from <IP>
[53210] 2018-04-10 17:06:15 info [134.71.0.126] arpnip - retrieved 0 entries
Use of uninitialized value in sprintf at perl5/bin/netdisco-sshcollector line 119, <__ANONIO__> line 3.
[53210] 2018-04-10 17:06:15 info arpnip - processed ARP Cache entries from 1 devices
This is because $stats{entry} only becomes an integer by being incremented, so
if there aren't any entries, it never exists. This is fixed by starting it at 0.
