Commit Graph

101 Commits

Author SHA1 Message Date
Oliver Gorwits
6a986783e4 fix to the fix for ospf_routers discovery 2019-01-02 20:54:50 +00:00
Oliver Gorwits
505b7b5625 #471 fix bug in checking if there are OSPF router IDs to poll 2019-01-02 20:21:34 +00:00
Oliver Gorwits
b445d237e4 #471 OSPF Neighbor Discovery by router ID 2018-12-28 17:32:40 +00:00
nick n
8aed736925 ignore notpresent interfaces, with type filtering config item (set to [] to not filter). work done by postilion/nic bernstein, filter by me. also includes trailing space fix by nic. (#464) 2018-12-28 16:08:40 +00:00
Oliver Gorwits
13d5f04465 #419 "neigh - discrepancy in IP" due to differences in IPv6 formatting 2018-06-08 10:56:16 +01:00
Oliver Gorwits
0d8cd3e764 #411 store_modules: false is ignored 2018-05-05 16:12:43 +01:00
Oliver Gorwits
cddbf44916 do not enqueue the same routed peer more than once 2018-04-28 11:40:58 +01:00
Eric A. Miller
8d1fb71c76 #401 Autodiscovery via EIGRP peers 2018-04-19 00:16:56 -04:00
Oliver Gorwits
b36a9e5699 #392 fix heuristic neighbour detection 2018-04-18 21:27:02 +01:00
Oliver Gorwits
454ededa46 Revert "#380 attempt to resolve port name when it is given wrong"
This reverts commit f4a143612b.
2018-04-10 21:03:10 +01:00
Oliver Gorwits
08a5652ae0 Revert "save a device_port lookup"
This reverts commit d19b2fac93.
2018-04-10 20:58:07 +01:00
Oliver Gorwits
67ee1808b6 Revert "better way to construct short interface name"
This reverts commit 8bcfaf12d0.
2018-04-10 20:58:06 +01:00
Oliver Gorwits
00f3f2a796 Revert "work for shortening or lengthening ports"
This reverts commit 9d48c4a025.
2018-04-10 20:58:05 +01:00
Oliver Gorwits
52e14aeeeb Revert "no need for quotemeta"
This reverts commit 9339c1a2ce.
2018-04-10 20:58:02 +01:00
Oliver Gorwits
9339c1a2ce no need for quotemeta 2018-04-09 23:15:58 +01:00
Oliver Gorwits
9d48c4a025 work for shortening or lengthening ports 2018-04-09 23:05:17 +01:00
Oliver Gorwits
8bcfaf12d0 better way to construct short interface name 2018-04-09 22:58:23 +01:00
Oliver Gorwits
d19b2fac93 save a device_port lookup 2018-04-08 13:22:52 +01:00
Oliver Gorwits
87d42eacac enforce single row return 2018-04-07 23:24:53 +01:00
Oliver Gorwits
f4a143612b #380 attempt to resolve port name when it is given wrong 2018-04-07 23:17:23 +01:00
Oliver Gorwits
3ae4eabd39 #12 store Cisco PortFast status in device_port_properties:faststart 2018-03-21 10:53:09 +00:00
Oliver Gorwits
7529a93501 #382 invaid regexp syntax 2018-03-20 10:10:41 +00:00
Oliver Gorwits
938b375df6 #381 LLDP port name is space compressed 2018-03-19 18:22:45 +00:00
Oliver Gorwits
1ba1ea2e27 better handling of malformed IPs in c_ip results 2018-03-17 14:57:13 +00:00
Oliver Gorwits
fb42c871c1 add interface alias for discovery IP 2018-03-17 14:24:05 +00:00
Oliver Gorwits
8d01a415e7 strip whitespace from model on HP 2018-03-05 22:55:36 +00:00
Oliver Gorwits
66ecb203a7 #370 Missing Map Links due to inability to parse port speeds 2018-03-05 21:42:02 +00:00
Oliver Gorwits
0229d46f86 fix typo in log 2018-03-02 20:20:17 +00:00
Oliver Gorwits
e1b9f2225e move wap and phone detection into portproperties worker 2018-03-01 04:56:07 +00:00
Oliver Gorwits
94da566184 gather lldp remote capabilities and info 2018-02-28 21:41:34 +00:00
Oliver Gorwits
7191a1cd00 implement port properties table and error disable gathering to it 2018-02-20 22:45:53 +00:00
Oliver Gorwits
3e7ffe8045 handle malformed IPs in c_ip results 2018-02-20 22:15:22 +00:00
Oliver Gorwits
c1f9033125 routed neighbors only queue if not also l2 neighbor 2018-02-11 21:54:28 +00:00
Oliver Gorwits
e31cb803eb split device properties and alias discovery and allow cancel after properties 2018-02-11 12:31:16 +00:00
Oliver Gorwits
d3c83c395d cancel jobs when it is known fresh device is already discovered 2018-02-11 11:16:56 +00:00
Oliver Gorwits
147c02a956 fix renumber when running at cli 2018-02-10 23:14:31 +00:00
Oliver Gorwits
748ebba7c0 watch for dupe IPs 2018-02-10 16:38:38 +00:00
Oliver Gorwits
403ab48157 #47 gather IPv6 Interface Addresses 2018-02-02 18:32:06 +00:00
Oliver Gorwits
35980ba0cd improve logging on routed peers worker 2018-02-01 18:46:18 +00:00
Oliver Gorwits
a78f3b8e5d remove unnecessary snmp reindex 2018-02-01 18:32:40 +00:00
Oliver Gorwits
1f1af381fb Do not attempt Canonical IP change to non-discoverable IP [skip ci] 2018-02-01 15:32:35 +00:00
Oliver Gorwits
dec681a2d5 #332 Autodiscovery via BGP and OSPF peers [skip ci] 2018-02-01 11:24:40 +00:00
Oliver Gorwits
7b1ef2b0c1 minor tidying [skip ci] 2018-01-31 15:53:33 +00:00
Oliver Gorwits
382022d3eb tidy up reindex call 2018-01-28 18:33:17 +00:00
Ambroise
0bc5c68ed8 Retrieve vrf interfaces (#366)
Allow to retrieve the VRF interface for some devices (used for Nexus devices).
The SNMP::Info::Layer3::Nexus module should have the patch to retrieve the VRF context.
And the context should have been created on Nexus device
2018-01-28 18:28:07 +00:00
Oliver Gorwits
4716be4c2f more useful to log the ID than the type (esp in homogeneous networks) 2018-01-05 17:41:02 +00:00
dgeo
d397aa1744 fix #361 (#362) 2018-01-04 20:53:23 +00:00
Oliver Gorwits
629b046a94 add log for skipping when duplicate lldpRemChassisId seen 2017-11-28 21:05:51 +00:00
Oliver Gorwits
26b4bdb907 change noop to info, and some fixes 2017-11-25 12:29:08 +00:00
Oliver Gorwits
0bb15f36b9 fixes for race conditions and dupes in job queue
we had situations where the manager would start workers on the same job,
either because of race conditions or because at the time of queueing it wasn't
known that the jobs were targeting the same device (due to device aliases).

this commit removes duplicate jobs, reduces the need for locking on the job
queue, and makes use of lldpRemChassisId to try to deduplicate jobs before
they are started. in effect we have several goes to prevent duplicate jobs:

1. at neighbor discovery time we try to skip queueing same lldpRemChassisId
2. at job selection we 'error out' jobs with same profile as job selected
3. at job selection we check for running job with same profile as selected
4. the job manager process also checks for duplicate job profiles
5. at job lock we abort if the job was 'errored out'

all together this seems to work well. a test on a large university network of
303 devices (four core routers and the rest edge routers, runing VRF with many
duplicate identities), ~1200 subnets, ~50k hosts, resulted in no DB deadlock
or contention and a complete discover+arpnip+macsuck (909 jobs) in ~3 minutes
(with ~150 duplicate jobs identified and skipped).
2017-11-23 19:55:34 +00:00