Commit Graph

706 Commits

Author SHA1 Message Date
Oliver Gorwits
f14e495e49 use new faster portvlanmismatch query without duplication 2023-06-13 17:41:20 +01:00
Oliver Gorwits
460b014e91 swagger-ui allows adding X-REMOTE_USER header when behind proxy 2023-06-13 17:41:20 +01:00
Oliver Gorwits
5181d83742 fix for undef HTTP_SERVER and HTTP_PORT err when browsing swagger-ui 2023-06-13 17:41:20 +01:00
Christian Ramseyer
82dea7de2a Try to fix #1044 by subquery inlining instead of CTE (#1046) 2023-06-08 16:29:14 +01:00
Christian Ramseyer
5d6697b035 Add indexes for custom_fields in device + device_port (#1045) 2023-06-08 16:12:59 +01:00
Oliver Gorwits
195f98dff1 make safe the api calls with potential for demo site damage 2023-06-05 17:28:34 +01:00
Oliver Gorwits
65a908dcd3 #1036 skip API login for trust_remote_user, trust_x_remote_user, no_auth 2023-06-05 17:02:20 +01:00
Ambroise
130fa4aebe Change the way to retrieve IP address of interface (#1026)
Use by default the ipTable MIB entry to retrieve the IP address of interfaces and fallback to the index method as previously.
Fixe the issue with the case where the index is not really an IP address (seen in Fortinet with VDOM).

Related to issue #1016
2023-05-31 14:06:00 +01:00
Oliver Gorwits
9355f5c2b9 Refactored ACL support with multi-object compare
Squashed commit of the following:

commit 4081e22202693bd7c4ea00e95daad8e628c6fd5a
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Mon May 29 21:02:07 2023 +0100

    large rename of check_acl* to acl_matches*

commit 3cfa284ddd24d68765c255578cc5c184afbdcd83
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Fri May 19 20:39:03 2023 +0100

    update permission doc

commit 8c7bb93cc5e9fafb770f98f446e45cbd94b14894
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Wed May 17 21:50:07 2023 +0100

    migrate most check_acl_only to acl_matches_only

commit c47f699f2a22f08f2f3e093ed0f24c891e6f9a82
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Wed May 17 21:39:19 2023 +0100

    rename check_acl* to be acl_matches*

commit a884a22c3ab1f3262118c3a47ed8e25b0b0a7336
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun May 14 16:50:42 2023 +0100

    update macsuck_no_deviceports to use acl_matches

commit 8c256af728721329b64d071fa529dfc844073ac6
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun May 7 22:54:33 2023 +0100

    update hide_deviceports to use acl_matches multi @things

commit cd5d9978aba1da459be4fed4500f395df13f7784
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sun May 7 22:53:38 2023 +0100

    check_acl fix to allow all @things to offer a property before fallback to missing as empty string

commit 1a3ab9a7646e9f994f03126d45fc36e9e5a13ed5
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue May 2 15:31:17 2023 +0100

    add ignore_deviceports to portproperties discover; improve comments

commit 51385ce89458dc939587dae902fda431719c22c9
Merge: b97c07d2 3f8ffe78
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue May 2 15:21:48 2023 +0100

    Merge branch 'master' into og-acl_multidict

commit b97c07d237d750c1d9eb3095d8ff3908512eac2a
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Sat Mar 25 14:37:53 2023 +0000

    add support for arrayref of items, and unblessed hash, to check_acl
2023-05-29 21:32:07 +01:00
Oliver Gorwits
3f8ffe787f hooks only queued if their trigger job is successful (done) 2023-04-30 22:59:20 +01:00
Oliver Gorwits
949aeb9eea delete hook (#1032)
* make log_message optional in delete_device

* add hooks support to delete job

* make delete job high prio

* web delete now queues job instead of inline delete

* move web logging into web package and remove userlog from device delete helper

* submit delete job for expire device instead of inline delete

* fixes to get web submit form for delete device to work

* enable delete hook functionality
2023-04-30 22:58:42 +01:00
Oliver Gorwits
0a1f1bcb73 api for actions (#1031)
* implementation of GET and DELETE for Job Queue API

* implement POST jobs submission to queue via API

* implement GET /queue/backends API endpoint to get backend names
2023-04-27 16:26:26 +01:00
Oliver Gorwits
e268b9d522 #1010 Search port descriptions 2023-04-03 22:02:43 +01:00
Oliver Gorwits
5c1e753c14 #1013 undef error in Nodes interfaces 2023-03-29 11:17:06 +01:00
Oliver Gorwits
701ef51a53 #990 API error: Not Authorized due to time zone calc error 2023-03-29 10:58:01 +01:00
Oliver Gorwits
6586815fc6 #1001 support for FQDN node search while domain_suffix is set; add fallback to IPv4 host lookup search 2023-03-16 15:53:25 +00:00
Oliver Gorwits
2b8a45ef08 better name for variable 2023-03-16 13:54:59 +00:00
Oliver Gorwits
1d988bbf7c implement ignore_layers, force_macsuck, force_arpnip config settings (#1002)
* implementation of ignore_layers, force_macsuck, force_arpnip and macwalk

* use new WalkJobs view to get devices needing macsuck

* also new query for discoverall, arpwalk, nbtwalk

* faux record has a last_defer stamp so we can see when the backend started

* fix typo
2023-03-15 14:44:42 +00:00
Oliver Gorwits
062895df10 allow 3min for port last_change compare to uptime, do not assume wrapped 2023-03-15 08:07:45 +00:00
Oliver Gorwits
e758a78c18 fix error with unused reports menu categories 2023-03-10 18:04:37 +00:00
Oliver Gorwits
9fd1e71b8b #974 show all chassis serials in device details 2023-03-08 22:56:18 +00:00
Oliver Gorwits
91e783e96f fix bug with ILIKE/LIKE on UTF8 encoded field 2023-03-08 22:52:13 +00:00
Oliver Gorwits
c6e0ad75b9 #985 allow netdisco-{deploy,do,db-deploy} on custom tenant with NETDISCO_DB_TENANT 2023-03-08 14:15:12 +00:00
Oliver Gorwits
db112d99cd #989 netdisco-deploy and netdisco-db-deploy respect ND2_DB_ROLLBACK 2023-03-08 13:49:02 +00:00
Oliver Gorwits
2848877d74 #977 add comment to netdisco-do renumber about device_identity 2023-03-07 20:15:54 +00:00
Oliver Gorwits
1505a8637b #952 support user-supplied net-snmp options in SNMP Transport 2023-03-07 18:17:30 +00:00
Oliver Gorwits
75f8ffdcc2 sort Report menu items by label 2023-03-06 20:28:51 +00:00
Oliver Gorwits
08a88f8337 support pseudo/offline device renumber and also pseudo device autovivification 2023-03-05 20:57:05 +00:00
Oliver Gorwits
4bb9b25ae9 #901 node_ip time_last can be before time_first 2023-03-03 15:34:16 +00:00
Oliver Gorwits
1d00ebc91e #949 inconsistencies in time values due to time zone handling 2023-03-03 15:01:06 +00:00
Oliver Gorwits
214b98d28f #949 replace other occurances of now() with LOCALTIMESTAMP 2023-03-03 14:22:21 +00:00
Oliver Gorwits
cbc32eb032 #949 replace other occurances of now() with LOCALTIMESTAMP 2023-03-03 14:21:18 +00:00
Oliver Gorwits
d9a384d1d0 #949 replace other occurances of now() with LOCALTIMESTAMP 2023-03-03 14:17:38 +00:00
Oliver Gorwits
29402f0726 #949 replace now() with LOCALTIMESTAMP and cast to_timestamp() as ::timestamp 2023-03-03 14:08:10 +00:00
Oliver Gorwits
de1ec0dc67 #981 inspect ports lastchange for uptime wrap only after filtering ports 2023-02-27 18:00:21 +00:00
Oliver Gorwits
252c9c7e66 #478 rewrite wireless client count report which was bobbins 2023-02-25 14:07:44 +00:00
Oliver Gorwits
86ef8add72 #979 tenancy awareness for generic reports 2023-02-21 11:52:50 +00:00
Oliver Gorwits
d14c4b6726 #958 make job queue updates work reliably and atomically 2023-01-11 14:59:12 +00:00
Oliver Gorwits
15a5e05a38 #957 error in job queue management when deleting one job 2023-01-10 13:14:43 +00:00
Oliver Gorwits
e43f6de283 #953 fix port reconfig (vlan) fail due to missing DB column data 2023-01-10 13:05:12 +00:00
Oliver Gorwits
83b49f8ece add IEEE8023-LAG-MIB to snapshot retrieval 2022-12-13 15:29:10 +00:00
Oliver Gorwits
c82dfc8a10 #948 Column order wrong when displaying custom fields 2022-12-13 11:30:36 +00:00
Christian Ramseyer
8cc8bdcd19 Add NAC columns to UI (#941)
* Add NAC columns to UI

* Compact variant with a "NAC Summary" column

* display PAE stuff as very short summary in web and full columbs in csv

* add tooltips for actual port status and state detail

* minor naming tweaks

Co-authored-by: Oliver Gorwits <oliver@cpan.org>
2022-12-13 09:16:32 +01:00
Oliver Gorwits
22210b26b7 keep port custom_fields in place across device discovery 2022-12-11 16:54:07 +00:00
Oliver Gorwits
97f40539e9 update num_ports to number of actually stored interfaces
also change update_or_insert to just update as the code never runs unless
in_storage anyway
2022-12-11 16:37:33 +00:00
Oliver Gorwits
1c7c749f0e custom fields on devices and ports in the web from config (#945)
* custom device field web display and edit

* make display work; relies on T::T calling dict slot or method with same syntax

* add storing port custom fields

* use resultset method instead, use cf_ prefix

* update Pg min ver for jsonb

* allow override of position and default for port custom fields

* support hidden for custom fields

* update description of Objects API class

* allow left and mid position for custom fields

* add custom fields in csv

* change port control sidebar label

* fix default missing bug on backend jobs
2022-12-09 10:20:26 +00:00
Oliver Gorwits
d03eab02db #944 DevicePort.pm should use vlan_entry instead of vlan 2022-12-06 19:11:51 +00:00
Oliver Gorwits
2338a83f2b avoid pulling port_properties rows if with_properties already called 2022-12-04 12:26:10 +00:00
Oliver Gorwits
9eb6aaebfc set layer2 support after successful macsuck, similar to arpnip does for l3 2022-11-25 21:54:03 +00:00
Oliver Gorwits
826e1db39d API Endpoints to submit arpnip and macsuck results (#942)
* Add macsuck worker to collect various PortAccessEntity (NAC) attributes

* Incorporate PAE feedback on #937

 * missing Result/Device.pm column added
 * pae_is... columns instead of pae_capabilities
 * moved most code to Util/PortAccessEntity.pm so the update can
   be done in discover and macsuck

* Refactor PAE attributes during discover as separate Plugin

* PortAccessEntity: don't use device->dns in log string

* Fix "Experimental keys on scalar is now forbidden" test failure

* Revamp pae_control and add missing attribute

 - device.pae_control (text) is now device.pae_is_enabled (bool)
 - also store pae_authconfig_port_control (port mode auto/force(un)Auth)

* Fix "Experimental keys on scalar is now forbidden" test failure

 - ... again because of botched merge
 - at least perlgolfed away a set of curly braces

* Update PortAccessEntity.pm

* Incorporate @ollyg PR feedback

* allow actions without transport to run when there are also no creds

* initial refactor for separate gather, process, store phases for macsuck

* factor out the vlan sanity check

* additional help with log of action workers

* cleanup logic in check macsuck

* refactor to make main phases only

* some fixes

* implement file slurp. amazingly the whole thing works

* remove outdated noop from test

* treat error as critical, use cancel to suppress further drivers

* big refactor to share mac sanity code to both paths

* fix inverted logic on vlan sanity filter

* some code tidy

* fix error in default value

* fix for vlan 0 nodes input from cli

* ensure imported MACs are IEEE format

* add api endpoint, no useful return status yet

* exit status if error from nodes PUT

* suppress other networked workers when direct workers are active

* better log showing worker

* fix status recording to get first error or last done message

* implement arpnip API PUT

* avoid package redeclaration error

* make sure write API methods require admin status

* add doc for passing JSON data to arpnip and macsuck

* update manifest

* remove option to do jobs in web handler; all by queue now

* use job entry timestamp for offline queued jobs

* fix store username and IP on api PUT

* never de-duplicate user-submitted jobs; never reset DeviceSkip for offline jobs

* myworker no longer needed

* make logic cleaner

Co-authored-by: Christian Ramseyer <ramseyer@netnea.com>
2022-11-25 15:24:23 +00:00