Hi @ollyg! Unfortunately I have found some issues with the code we
finally released in #680:
* get_port_macs expects an array ref but values() returns array,
so the code was never called due to the return unless... check
* When fw_mac_list had exactly two entries, only the second value
was bound as a scalar to the parameter. This is probably due
to the shorthand bind formats described in
https://metacpan.org/pod/DBIx::Class::ResultSet#DBIC-BIND-VALUES,
but I'm not a 100% on this.
* return unless now checks for an entry in the list, with the old
check the statement was also executed for empty lists
In cases where only the device(_port)?.mac lookup worked for uplink
detection, users of 02.044005 - 010 might get a lot of uplinks not
labeled as such.
* Reduce macsuck bandwidth usage to database
get_port_macs transfers a full list of all device_port.(mac,ip) in every macsuck.
With 8k devices and 40k interfaces it takes up around 15MB. Transferring them 8k times
during an 1h macsuck cycle requires bandwidth in the 300 to 400 mbit/s range.
This patch changes get_port_macs to be called inside walk_fwtable and only transfer
the macs found in the current target device/vlan.
this patch resets all pseudo devices to have no layer3 support but adds a
feature to the pseudo devices admin panel to enable layer3 support. it also
changes arpnip and arpwalk behaviour to always permit the action if layer3
is available (ignoring the vendor).
documentation will need updating to tell users to create pseudo devices
with layer3 support when they want to arpnip an unsupported platform.
arpnip with ssh/cli against a supported platform (one that can be discovered)
will continue to work normally.
Squashed commit of the following:
commit 9dad5be81d
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Sep 3 09:03:53 2019 +0100
allow pseudo with layer 3 to run arpnip
commit 7d97943fcd
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Sep 3 08:59:10 2019 +0100
allow pseudo devices with layer 2/3 capability
commit d1fdf574e3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Sep 3 08:55:41 2019 +0100
move pseudo and layer checks to is_able from is_able_now
commit e0f72ef67d
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Sep 3 08:51:42 2019 +0100
ports defaults to one
commit 86ba01270c
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Sep 3 08:50:45 2019 +0100
add tooltip for arpnip toggle
commit cdd2470228
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Sep 3 08:34:46 2019 +0100
simplify template
commit 46236d68ea
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Sep 1 23:53:56 2019 +0100
a fix up for pseudo devices which need layer 3
commit 016d249efc
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Sep 1 20:37:11 2019 +0100
do not wrap buttons
commit 1ec1402e0c
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Sep 1 20:33:03 2019 +0100
implement user settable layer-three service for pseudo devices
commit a267efa3d8
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Sep 1 18:39:22 2019 +0100
only set layer if successful action
commit b108be5e23
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Sep 1 18:32:19 2019 +0100
should defer SNMP against pseudo devices
commit 897ba3a629
Merge: e0ddbaaba7348900
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Sep 1 14:54:36 2019 +0100
Merge branch 'master' into og-pseudo-vs-cli-arpnip
commit e0ddbaab08
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Aug 26 11:35:13 2019 +0100
as last commit, for discover
commit 61f9c89040
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Aug 25 23:55:38 2019 +0100
move pseudo and layer checks into is_*able functions
commit 8b010d4023
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Aug 25 18:38:11 2019 +0100
any device completing macsuck/arpnip must have that layer
commit a11bce7863
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Aug 25 18:33:27 2019 +0100
clean up device layers
commit d2661bff61
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Aug 25 18:18:02 2019 +0100
first make arpnip behave like other jobs towards pseudo devices
* update changes and SNMP::Info dep
* Integrate netdisco-sshcollector into Worker::Plugin architecture (#489)
* Initial integration of sshcollector into Worker::Plugin architecture
* add NodesBySSH.pm
* update Build.PL and config.yml to integrate the new module
* Further integration of sshcollector into Worker::Plugin architecture
* added App::Netdisco::Transport::CLI loosely based on ::SNMP counterpart
* switched to the more prevalent two-space tabs style
* removed various TBD items, some new ones
* Further steps to integration of sshcollector into Worker::Plugin architecture
* cleaned up code
* added various error handling
* warning for bin/netdisco-sshcollector deprecation
* device_auth allows passing master_opts to Net::OpenSSH
* netdisco-do -D also toggles Net::OpenSSH debug
* Merged NodesBySSH.pm into Nodes.pm
* see https://github.com/netdisco/netdisco/pull/489#pullrequestreview-205603516
* Further integration of sshcollector into Worker::Plugin architecture
* add snmp_arpnip_also option to sshcollector device_auth
* cleanup code
* Remove big TBD: comment from CLI.pm as doc is updated now
* add transport/cli.pm to manifest
* revert some changes to allow simpler merging
* silent exit legacy script unless explicitly requested
* move ssh code into Transport, part one
* rewrite the CLI transport to provide an API
* merge in og-get_external_credentials
Squashed commit of the following:
commit 3fe8f383a7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 11 17:07:42 2019 +0000
add debug lines and tested
commit 3249739e42
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 11 16:54:11 2019 +0000
change config name to get_credentials
commit e78558397a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 11 16:51:11 2019 +0000
separate out generic device auth to DeviceAuth module
commit 249f05165f
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Mar 6 18:43:31 2019 +0000
release 2.040007
commit e3af64df77
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Mar 6 18:42:47 2019 +0000
#521-redux fix wifi date search
commit 48857ae300
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 4 12:03:31 2019 +0000
release 2.040006
commit e09dab5362
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 4 11:39:12 2019 +0000
#527 update List::MoreUtils version requirement
commit 6e7de3fff3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Mar 4 09:59:41 2019 +0000
release 2.040005
commit 0c98318a45
Author: Oliver Gorwits <oliver@spike.local>
Date: Mon Mar 4 09:57:18 2019 +0000
#526 fix discover syntax bug
commit e9efc45182
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 14:56:48 2019 +0000
release 2.040004
commit 6cdfd80d10
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 14:34:00 2019 +0000
allow undiscovered neighbors report to use discover_{waps,phones} setting
commit ac381e0802
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 14:13:20 2019 +0000
#506 was a red herring
commit b83e614c85
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 13:00:36 2019 +0000
make discover_{phones,waps} work with LLDP capabilities as well
commit 189d234b55
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:47:38 2019 +0000
check discover_no_type and friends earlier on in neighbors list build
commit 9c956466f3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:32:07 2019 +0000
also update default config for new discover_phones and discover_waps settings
commit 09d29954d2
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:26:50 2019 +0000
#512 fix regression in phone/wap discovery exclusion
commit 2bae91f1b6
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 12:01:34 2019 +0000
rename match_devicetype() to match_to_setting()
commit 57cb6ddb70
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Mar 3 09:19:39 2019 +0000
fix for over-eager fix to #506
commit ef560fb59a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 22:41:40 2019 +0000
#506 relax device renumber so it works for an alias
commit 7a8bcb094e
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 22:23:39 2019 +0000
#521 Search Node Date Range not working
commit a643820a62
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 21:54:27 2019 +0000
#428 Port-Channels not showing in netmap
commit 5ba5bcd295
Merge: e7aacddba1f95028
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 20:04:11 2019 +0000
Merge branch 'master' of github.com:netdisco/netdisco
commit e7aacddbc6
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 20:01:05 2019 +0000
#498 Map with VLAN filter omits unconnected devices
commit a1f95028ca
Author: nick n <39005454+inphobia@users.noreply.github.com>
Date: Sat Mar 2 19:54:22 2019 +0100
catch up with changes
noticed that rc-sshcollector-core received updates to changes, add them here as well.
didn't mention #499 & #522
commit ce1b847cea
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 18:47:44 2019 +0000
fix bug showing no nodes when only one matches in netmap
commit 78e30a7926
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 16:28:15 2019 +0000
#500 filtering in device/ports on native vlan duplicates entries
commit 9952f0c6c7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 15:02:12 2019 +0000
#499 netdisco-do renumber reports wrong ip (inphobia)
commit ca3fd8f466
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 15:00:18 2019 +0000
#505 device renumber should update device port properties and device skips
commit 1265bc8470
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 14:52:21 2019 +0000
#520 catch slave ports defined without a master
commit d4c7579c10
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 14:47:49 2019 +0000
#522 TypeAhead.pm can reference empty data (inphobia)
commit 77decc23b7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 2 14:45:37 2019 +0000
#514 inconsistent results in ip inventory (inphobia)
commit 3f211650b8
Author: nick n <39005454+inphobia@users.noreply.github.com>
Date: Fri Mar 1 12:34:42 2019 +0100
last pieces for db schema upgrade
last piece of #510
* import legacy sshcollector config
* add default use_legacy_sshcollector config
* remove unneeded deps
* various fixes and now tested
* enable sshcollector platform tests
also link to manual topology from device ports
fix tooltip reinit on datatables paging
Squashed commit of the following:
commit 85d52ed174
Merge: 66e3536607446ed7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 31 08:59:19 2017 +0000
Merge branch 'master' into og-newnetmap
commit 66e353669d
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 31 00:16:49 2017 +0000
add docs link
commit 809f1ede76
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 31 00:11:29 2017 +0000
node links to other devices
commit 187e1ea803
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 23:58:56 2017 +0000
add node infostring
commit 6453f99b28
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 23:41:19 2017 +0000
link infostrings!
commit f3ba260142
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 22:42:09 2017 +0000
maxnoderadius is now based on dynamic size calc
commit 0af415e391
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 22:33:22 2017 +0000
fix to get aggregate ports in matching order on left and right side
commit 3f36121a4c
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 22:07:28 2017 +0000
initial aggregate link summing
commit e5b96b0781
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 14:55:00 2017 +0000
tidy and refactor
commit 79f22a47b3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 13:42:58 2017 +0000
get rid of d3 v3/v4 and only have v3
commit 18c3f16c8f
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 12:54:45 2017 +0000
fullscreen exit now works
commit 93f8181fc8
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 30 08:58:04 2017 +0000
implement show link speeds on links
commit 72961f172d
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 28 23:51:26 2017 +0000
add speed to retrieved devicelinks
commit ae5496310e
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 26 11:21:12 2017 +0000
remove annealing on label change
commit 885cb92bd3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 26 11:15:21 2017 +0000
reorder options
commit 015a1debe0
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 26 11:11:01 2017 +0000
fix d3-force debug link messing up svg text elements
commit 10ccaa78b1
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 26 10:52:47 2017 +0000
show ips functionality; improvement to maximise icon; bugfix d3-force label wrap
commit 71a1a20909
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Dec 25 13:21:23 2017 +0000
move labels on neighbor view
commit 9578215349
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Dec 25 13:13:13 2017 +0000
force running spinner
commit 6618fba548
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 23:13:33 2017 +0000
fix neighbors pinning
commit 938848551e
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 18:12:04 2017 +0000
implement dynamic sizing option
commit e4b19be5d7
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 13:25:00 2017 +0000
zoom to device on neighbor show; do not save positions on neighbor show
commit 58b576b464
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 13:10:48 2017 +0000
better neighbors/save interaction
commit 2c77660f2f
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 13:03:46 2017 +0000
fix labels on checkboxes to be clickable
commit 2c2dc62cda
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 12:50:26 2017 +0000
prevent save positions when in neighbor view mode
commit 78c558b5be
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 12:37:51 2017 +0000
add tooltip to show why host groups radio is disabled
commit 7000d4b0eb
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 12:12:29 2017 +0000
allow port control role to edit manual topology
commit 547d2934cb
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 12:09:40 2017 +0000
working save/restore node positions with groups
commit bf7e231ffe
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 24 10:09:26 2017 +0000
node colors!
commit e23594b041
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 23 23:42:17 2017 +0000
wooo device group selection is working
commit b1b22c9811
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 23 22:31:23 2017 +0000
send full query str from netmap for json
commit 9a13bb7f9b
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 23 22:06:24 2017 +0000
implement host_group_displaynames and fix vlan save bug
commit 35ed34ed2f
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 23 17:52:14 2017 +0000
when neighbors only can restrict the links search
commit f9e5ec02ab
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 23 17:44:41 2017 +0000
tweak mapshow
commit 9f9971ff4e
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 23 00:47:17 2017 +0000
better sidebar look and layout
commit 1def41da67
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 21 23:54:44 2017 +0000
sidebar with many options!!
commit 4203cbb225
Merge: 7c12df6b7db65932
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 21 20:14:55 2017 +0000
Merge branch 'master' into og-newnetmap
commit 7c12df6b83
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 21 00:13:03 2017 +0000
refresh tooltips when the datatables table is updated
commit 081b89d5dc
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 20 23:59:15 2017 +0000
shortcut from device port to manual topology
commit 9520438960
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 20 23:34:44 2017 +0000
tighten the sql for neighbor links
commit d6b0275931
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 20 23:26:22 2017 +0000
tweak layout again
commit 9e5e2f0ed5
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 20 23:18:57 2017 +0000
fullscreen mode for netmap
commit aba359d2a9
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 20 22:05:51 2017 +0000
save and load netmap positions for same device groups
commit b7cd0251ff
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 19 23:24:47 2017 +0000
basic positions upload
commit 786115ebda
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 19 22:13:16 2017 +0000
working group drag
commit 91f98d4f33
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Dec 18 23:00:16 2017 +0000
drag all selected nodes
commit ba48eee5f7
Merge: 60412cd67f8e3edf
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Dec 18 20:14:20 2017 +0000
Merge branch 'master' into og-newnetmap
commit 60412cd6e6
Merge: 39ca14917dc79f72
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 17 20:23:41 2017 +0000
Merge branch 'master' into og-newnetmap
commit 39ca1491b0
Merge: 69622582c8806bea
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 17 19:52:49 2017 +0000
Merge branch 'master' into og-newnetmap
commit 6962258223
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 17 19:52:26 2017 +0000
bleed versions
commit 444e82b8a3
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 16 15:33:41 2017 +0000
use d3 v4 only
commit 01cd7a908d
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Dec 16 15:22:08 2017 +0000
two d3 connected
commit 854f37fc94
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 14 21:34:49 2017 +0000
more fiddling with d3
commit 61a3a9e06d
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 14 19:15:21 2017 +0000
working worker
commit ebadebe69a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Thu Dec 14 07:57:55 2017 +0000
borken worker
commit c327b28513
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 13 13:45:03 2017 +0000
fix node center
commit 33bd9d39da
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed Dec 13 01:14:50 2017 +0000
improvements to graphing
commit 6178bf2298
Merge: 1c627eaf925940c9
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 12 23:44:48 2017 +0000
Merge branch 'master' into og-newnetmap
commit 1c627eaf3c
Merge: 77ca8f96000cbaa1
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue Dec 12 23:38:00 2017 +0000
Merge branch 'master' into og-newnetmap
commit 77ca8f96e1
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon Dec 11 00:09:08 2017 +0000
working rendering using d3-force plugin
commit 187265fc03
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun Dec 10 23:19:23 2017 +0000
initial work on moving to d3-force-apex-plugin - json data
