This commit adds a table 'device_skip' that is used to restrict job queue searches to avoid jobs that are not permitted on this backend via *_no ACLs, or jobs on devices that have previously encountered multiple SNMP timeouts. When the backend loads or a device is added, a row is added to the table if that device should not be polled on this backend (together with the job actions which are to be skipped/denied). When a device SNMP connect fails a counter in the same row (or a new row) is incremented. There is also a new report 'SNMP Connect Failures' to show the devices with non-zero SNMP connect failure counters. A configurable limit in the setting 'max_deferrals' is used to set the threshold of no longer polling the device. To reset the deferrals/failures count, restart the Netdisco backend (which regenerates 'device_skip' cache entries). Squashed commit of the following: commitb5e32c219dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 20:55:14 2017 +0100 show all failed connections in report commitffce3cee84Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 20:12:39 2017 +0100 only resolve fqdn once commitcc4f680f01Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 20:10:20 2017 +0100 Revert "only resolve fqdn once" This reverts commit3d136a54de. commitd8d082b30eAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 20:09:05 2017 +0100 a report to show SNMP failures commit3d136a54deAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 19:37:58 2017 +0100 only resolve fqdn once commit4550b8a84cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 17:27:43 2017 +0100 skipover now implicit from deferrals/actionset; fix sql where logic with better correlation commitb51edbccd2Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 16:11:29 2017 +0100 only abort lock if action matches badactions commit415559b24fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 13:56:42 2017 +0100 set skipover true when adding to actionset commit1086f2c467Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 13:50:56 2017 +0100 fix empty actionset commit31962580b8Merge:9b2e993e6808133bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 13:25:08 2017 +0100 Merge branch 'og-device_skip' of github.com:netdisco/netdisco into og-device_skip commit6808133bdbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 13:19:54 2017 +0100 in-job checks for acls are required for netdisco-do foreground actions commit3944dd7813Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 13:18:30 2017 +0100 avoid extra device lookup commit9b2e993e0fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 12:31:36 2017 +0100 also delete device_skip rows when deleting device commitb55854e91dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 11:34:27 2017 +0100 actions in device_skip table are now an array/set commit5e126eef07Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 09:36:33 2017 +0100 typo commit44266f2767Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 09:14:25 2017 +0100 *able checks within jobs should not be necessary with skiplist commite7c22e7d11Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 08:58:57 2017 +0100 increment deferrals field when job is deferred commit88ae9c00baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 08:40:27 2017 +0100 turn connect fail into defer commiteac1857043Author: Oliver Gorwits <oliver@cpan.org> Date: Tue May 23 08:26:59 2017 +0100 rename failures column to be deferrals commit96ed444bbbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon May 22 22:52:51 2017 +0100 set up list of jobs the backend instance should skip commit3a0019296dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon May 22 22:01:50 2017 +0100 separate out is_*able last_* checks commitcf8589aba2Author: Oliver Gorwits <oliver@cpan.org> Date: Sun May 21 22:35:38 2017 +0100 change from ignore to skip name commited193356f8Author: Oliver Gorwits <oliver@cpan.org> Date: Sun May 21 14:52:33 2017 +0100 device_ignore table to track devices to skip in polling
		
			
				
	
	
		
			99 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Perl
		
	
	
	
	
	
			
		
		
	
	
			99 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Perl
		
	
	
	
	
	
| package App::Netdisco::Backend::Worker::Poller::Common;
 | |
| 
 | |
| use Dancer qw/:moose :syntax :script/;
 | |
| 
 | |
| use App::Netdisco::Util::SNMP 'snmp_connect';
 | |
| use App::Netdisco::Util::Device 'get_device';
 | |
| use App::Netdisco::Backend::Util ':all';
 | |
| use App::Netdisco::JobQueue qw/jq_queued jq_insert/;
 | |
| 
 | |
| use Dancer::Plugin::DBIC 'schema';
 | |
| use NetAddr::IP::Lite ':lower';
 | |
| 
 | |
| use Role::Tiny;
 | |
| use namespace::clean;
 | |
| 
 | |
| # queue a job for all devices known to Netdisco
 | |
| sub _walk_body {
 | |
|   my ($self, $job_type, $job) = @_;
 | |
| 
 | |
|   my $layer_method = $job_type .'_layer';
 | |
|   my $job_layer = $self->$layer_method;
 | |
| 
 | |
|   my %queued = map {$_ => 1} jq_queued($job_type);
 | |
|   my @devices = schema('netdisco')->resultset('Device')
 | |
|     ->has_layer($job_layer)->get_column('ip')->all;
 | |
|   my @filtered_devices = grep {!exists $queued{$_}} @devices;
 | |
| 
 | |
|   jq_insert([
 | |
|       map {{
 | |
|           device => $_,
 | |
|           action => $job_type,
 | |
|           username => $job->username,
 | |
|           userip => $job->userip,
 | |
|       }} (@filtered_devices)
 | |
|   ]);
 | |
| 
 | |
|   return job_done("Queued $job_type job for all devices");
 | |
| }
 | |
| 
 | |
| sub _single_body {
 | |
|   my ($self, $job_type, $job) = @_;
 | |
| 
 | |
|   my $action_method = $job_type .'_action';
 | |
|   my $job_action = $self->$action_method;
 | |
| 
 | |
|   my $layer_method = $job_type .'_layer';
 | |
|   my $job_layer = $self->$layer_method;
 | |
| 
 | |
|   my $device = get_device($job->device)
 | |
|     or job_error("$job_type failed: unable to interpret device parameter");
 | |
|   my $host = $device->ip;
 | |
| 
 | |
|   if ($device->in_storage
 | |
|       and $device->vendor and $device->vendor eq 'netdisco') {
 | |
|       return job_done("$job_type skipped: $host is pseudo-device");
 | |
|   }
 | |
| 
 | |
|   my $filter_method = $job_type .'_filter';
 | |
|   my $job_filter = $self->$filter_method;
 | |
| 
 | |
|   unless ($job_filter->($device->ip)) {
 | |
|       return job_defer("$job_type deferred: $host is not ${job_type}able");
 | |
|   }
 | |
| 
 | |
|   my $snmp = snmp_connect($device);
 | |
|   if (!defined $snmp) {
 | |
|       return job_defer("$job_type failed: could not SNMP connect to $host");
 | |
|   }
 | |
| 
 | |
|   unless ($snmp->has_layer( $job_layer )) {
 | |
|       return job_done("Skipped $job_type for device $host without OSI layer $job_layer capability");
 | |
|   }
 | |
| 
 | |
|   $job_action->($device, $snmp);
 | |
| 
 | |
|   return job_done("Ended $job_type for $host");
 | |
| }
 | |
| 
 | |
| sub _single_node_body {
 | |
|   my ($self, $job_type, $node, $now) = @_;
 | |
| 
 | |
|   my $action_method = $job_type .'_action';
 | |
|   my $job_action = $self->$action_method;
 | |
| 
 | |
|   my $filter_method = $job_type .'_filter';
 | |
|   my $job_filter = $self->$filter_method;
 | |
| 
 | |
|   unless ($job_filter->($node)) {
 | |
|       return job_defer("$job_type deferred: $node is not ${job_type}able");
 | |
|   }
 | |
| 
 | |
|   $job_action->($node, $now);
 | |
| 
 | |
|   # would be ignored if wrapped in a loop
 | |
|   return job_done("Ended $job_type for $node");
 | |
| }
 | |
| 
 | |
| 1;
 |