Squashed commit of the following: commit86d0f61d0bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 16 22:26:32 2017 +0000 fix typo commit5aff19621cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 16 22:10:18 2017 +0000 fix use of snmp_connect_ip which does not work for SNMPv3 commit68a56d35bbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 16 20:50:16 2017 +0000 no need for Array::Iterator even though it was cute commit71ee869c02Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Nov 15 22:14:47 2017 +0000 additional doc examples commit620b3fe544Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Nov 15 22:09:05 2017 +0000 stash workers within poller instance, and load plugins explicitly commit2431365583Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 13 22:17:11 2017 +0000 better fix for duplicate module entity index commita400b26704Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 13 22:14:42 2017 +0000 add ignore interfaces for HPE routers commit1502ec1966Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 13 22:08:02 2017 +0000 bug fixes after testing on a real network commit840b6b4069Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Nov 12 20:38:35 2017 +0000 add tests commit2de36c69baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Nov 12 00:14:21 2017 +0000 some reengineering to support proper testing commitc5f138fe62Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 11 14:43:53 2017 +0000 correct algorithm on finalise status, correct logging commit98442a2308Author: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 9 21:49:45 2017 +0000 bug fixes commite0c6615c87Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Nov 8 20:29:33 2017 +0000 fix bugs commit1eeaba441dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Nov 7 22:30:55 2017 +0000 finish refactor to new desired behaviour (buggy?) commit7edfe88f25Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 6 22:50:51 2017 +0000 fix to work, and correct namespace check commit25907d3544Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 6 21:26:01 2017 +0000 move status tracking and checking inside job instance commit4436150bf4Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Nov 5 20:54:28 2017 +0000 remove global rubbish commit28b016e713Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 4 23:31:51 2017 +0000 fix docs commit650f6c719bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 4 23:22:12 2017 +0000 tidy line commit10f78d5dbeAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 4 23:06:20 2017 +0000 add priority and namespace to support fancy worker overrides commitb9f9816d09Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Oct 11 18:33:46 2017 +0100 release 2.036012_001 commitc33bf204a4Merge:5b7ce3f7d3d81eb6Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Oct 11 18:30:23 2017 +0100 Merge branch 'master' into og-coreplugins commit5b7ce3f797Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Oct 9 15:46:09 2017 +0100 cannot Sereal::Encode DBIC row commit0a575f02baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Oct 9 14:07:56 2017 +0100 fix bug in job->device init commit207476950dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Oct 9 14:03:37 2017 +0100 default causes no attr to be created?! commit912f2fa91fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 8 18:43:51 2017 +0100 better debug logging commitdfeb9d9ddcAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 8 18:40:02 2017 +0100 make device_auth have driver setting for snmp entries commit460c0c0ee9Merge:3ccd107b98423445Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 8 18:08:58 2017 +0100 Merge branch 'master' into og-coreplugins commit3ccd107bd4Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 14:13:58 2017 +0100 fix bug in device->has_layer commita4b9bf2036Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:58:52 2017 +0100 netdisco-do show takes a param for method in -p commit4389cd0459Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:36:06 2017 +0100 fix to only check last poll on devices in storage commit58d0fbdddaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:21:13 2017 +0100 do not run discover parts if properties failed to complete commitb52aaaf1a1Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:08:46 2017 +0100 fix typo commit41be926921Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:04:45 2017 +0100 run all check workers commita41d114965Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:02:46 2017 +0100 fix driver config commitb10908a138Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 12:43:50 2017 +0100 use vars() cache between phases commit08b34e083dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 11:39:17 2017 +0100 remove die() calls commitb8108986fbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 11:31:59 2017 +0100 phase fixups commit273cbbc11bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 09:42:41 2017 +0100 change stage to phase commit256c10bae5Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 09:35:14 2017 +0100 multi worker actions need not return done from all workers commitee38bae48aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 09:05:25 2017 +0100 store result of worker if best for this phase so far commit5bddfc73baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 08:50:31 2017 +0100 auto debug-log worker return messages commit8b660a89c0Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:48:58 2017 +0100 bug fixes commitb58a5816a9Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:44:20 2017 +0100 remove unnecessary check phases commite44f06364aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:18:03 2017 +0100 fix unknown command check in netdisco-do commit3af13f0dfeAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:15:59 2017 +0100 introduce noop and refactor checks in all workers commit98463c8cadAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 1 10:49:12 2017 +0100 no need to debug log if there are no hooks in phase commit3b32e84312Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 1 08:18:13 2017 +0100 fiddle about with runner logic to fix exit states commit8fdba38ee0Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 08:01:42 2017 +0100 cannot reuse a worker as the job will be already set and the wrong plugins loaded commita155d9cb77Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 08:01:06 2017 +0100 should defer when we cannot connect to device commit10b5f6cbc4Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 08:00:32 2017 +0100 fix bug in where workerconf acls are checked commit2a74e0befaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 07:38:05 2017 +0100 can pass device instance to check_* commit4256b117dfAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 07:27:14 2017 +0100 move device_auth build to be with community defaults setting commita2de2c1616Merge:32be11c38dc4b9bcAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 07:21:03 2017 +0100 Merge branch 'master' into og-coreplugins commit32be11c3ffAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Sep 21 00:09:29 2017 +0100 move remaining interactive actions to be plugins commit3e41c93f5aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 20 21:47:50 2017 +0100 clean snmp handling commit30a2d5dd86Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 20 21:00:29 2017 +0100 make sure check plugins are loaded/run before phases commit3454d95a84Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 20 20:53:52 2017 +0100 capture result on main phase as well commit559fa4f93fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 18 22:46:35 2017 +0100 build device_auth from communities commit1969291719Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 18 22:04:22 2017 +0100 simplify to remove phases and fewer hooks commit6f78032e28Author: Oliver Gorwits <oliver@cpan.org> Date: Thu Sep 14 21:30:03 2017 +0100 add phase to test worker commit6edd2dc879Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 21:51:40 2017 +0100 no need to list all plugins commitdfaeb34d8cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 20:42:41 2017 +0100 add reset after messing with snmp context or community index commit09214dce92Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 20:29:21 2017 +0100 no need to pass $snmp around commit58cd488cccAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 19:22:40 2017 +0100 refactor layer and pseudo checks commit753acc607fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 10:53:12 2017 +0100 use overloaded $device commitd5d39289d6Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 10:44:31 2017 +0100 rename init stage to check commit1fdb086183Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 12 08:12:12 2017 +0100 refactor to remove second loop commit64a9491115Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 10 16:09:45 2017 +0100 change to init, first, second stages commit5f2da69697Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 22:26:04 2017 +0100 move discover and discoverall to worker plugins commitc6ebb7cf07Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 16:44:32 2017 +0100 move arpnip and arpwalk to worker plugins commit16a79463cbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 16:27:58 2017 +0100 set snmp driver on macsuck phase workers commit9167e02de5Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 15:55:53 2017 +0100 move macsuck and macwalk to worker plugins (macsuck needs snmp scope guard) commit68ca85643bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 14:56:15 2017 +0100 move expire and expirenodes to worker plugins commit271ef1a25cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 14:46:00 2017 +0100 move nbtstat and nbtwalk to worker plugins commite7508a9ecaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 21:23:54 2017 +0100 move all netdisco-do action to worker plugins commit707fc82b99Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 21:01:37 2017 +0100 remove psql code from netdisco-do and fix detection of misspelled action commit411918e3f8Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 20:56:26 2017 +0100 only load worker plugins for the action commit1f9740c0e2Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 18:30:43 2017 +0100 shorten hook names commita59c23de79Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 18:27:34 2017 +0100 make psql worker primary, add hook debug log commit36c70220a2Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 22:39:22 2017 +0100 allow two forms of worker declaration, and update docs commita79cb9a9e4Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 22:10:53 2017 +0100 all the bug fixes and a working plugin!!!!!!!!! :-D commit04896202e0Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 21:39:41 2017 +0100 refine runner commit547fce2f3cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 20:56:21 2017 +0100 hack the status class to regen if needed commitcd71a0b7a8Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 20:41:05 2017 +0100 move status update to job class commitc8e5cea4edAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 20:37:13 2017 +0100 objectify the running commitf48004fffaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:58:28 2017 +0100 bug squish commit46ece568f6Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:54:57 2017 +0100 implement runner?! commitfc9c60f707Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:28:38 2017 +0100 rename ok to is_ok and change slot names to avoid conflict with creators commit3ee85383abAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:25:41 2017 +0100 skip worker when action is per-device but no creds commit75abdad812Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 21:54:37 2017 +0100 further work on retval handling from workers commit4c1fdf4f92Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:37:53 2017 +0100 move worker plugin loader to Worker.pm commitbe0c5181a3Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:35:42 2017 +0100 move Runner to Worker namespace commit1c2cf924bcAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:33:20 2017 +0100 worker roles in Role namespace commit3099eda393Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:30:58 2017 +0100 load workers when runner role is loaded commita8c58a7b05Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 22:30:28 2017 +0100 initial broken implementation of the runner commit49b5274c33Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 19:04:20 2017 +0100 use run() mixin to exec action commite0a666668aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 18:54:44 2017 +0100 fix pod; set status defaults; stub runner mixin commit8eaa33770cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 18:45:00 2017 +0100 rename Core to Worker and move other packages around commit4def0af0b0Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 17:58:03 2017 +0100 better use of new status class commit8675bf62c6Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 17:27:38 2017 +0100 fix hook naming and implement primary workers commitef1bb81f2bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 17:26:27 2017 +0100 new backend status class commit5f50dfadf1Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 16:51:55 2017 +0100 new Backend package to load core plugins commit3baa7a818aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 16:22:29 2017 +0100 remove unnecessary Worker::Common role commit36b4adcc06Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 16:17:29 2017 +0100 disambiguate util/backend package and remove backend prelaod commit98bff731bdAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 2 08:25:06 2017 +0100 settle on a design for hook override, I think commitfe5c16a16dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Aug 30 20:37:36 2017 +0100 rework docs to be more clear and reflect new operation commitb34ba1977cMerge:31d1977fc34ed61dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Aug 21 21:17:46 2017 +0100 Merge branch 'master' into og-coreplugins commit31d1977f1eAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Aug 14 18:11:42 2017 +0100 Revert "move expire code to be initial plugin pilot (broken)" I think we'll only do the new backend code for jobs with a device. This reverts commit07998b72d9. commit61dc80aff8Merge:07998b72ade02db1Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Aug 14 18:10:29 2017 +0100 Merge branch 'master' into og-coreplugins commit07998b72d9Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 22:15:00 2017 +0100 move expire code to be initial plugin pilot (broken) commit685ec02108Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 22:10:58 2017 +0100 pass $job to the core worker commitd6523fe543Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 22:01:49 2017 +0100 $job->device is always a DBIC row commitee6deea01bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 18:12:34 2017 +0100 load plugins commitfd80096ca2Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 16:53:16 2017 +0100 rename all the things commit464c42d1f5Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Aug 2 10:19:16 2017 +0100 use Scope::Guard to reduce device_auth commitec041dafd2Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Aug 1 15:34:37 2017 +0100 the other way around commit33d2fe13bdAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Jul 31 17:57:29 2017 +0100 fix pod commit3faee1cf16Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Jul 31 17:55:10 2017 +0100 remove need for instance() call commitc6d0f1c035Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 13:51:23 2017 +0100 add doc note on accessing transports commitdca4b4fc03Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 11:50:10 2017 +0100 add backend driver documentation commit052a2acd79Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 10:16:58 2017 +0100 rename web plugins doc commit69c9a6393aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 10:12:42 2017 +0100 rename args to driverconf commit2586a36f8cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Jul 25 22:41:10 2017 +0100 new version of core plugin manager with better config and filters commit4056831f99Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Jul 25 20:53:56 2017 +0100 change SNMP to be a cached transport singleton commitc31030ef70Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Jul 23 13:46:27 2017 +0100 fixes because Dancer docs are a mess! commitf65ef90b86Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Jul 22 08:11:36 2017 +0100 rename snmp_auth to device_auth and include a little doc on transports commitd61556e1cfAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Jul 22 07:54:26 2017 +0100 plugin config added commitde8de56308Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 12 21:38:31 2017 +0100 initial core plugin implementation
32 lines
889 B
Perl
32 lines
889 B
Perl
package App::Netdisco::Worker::Plugin::Arpnip;
|
|
|
|
use Dancer ':syntax';
|
|
use App::Netdisco::Worker::Plugin;
|
|
use aliased 'App::Netdisco::Worker::Status';
|
|
|
|
use App::Netdisco::Util::Device 'is_arpnipable_now';
|
|
|
|
register_worker({ phase => 'check' }, sub {
|
|
my ($job, $workerconf) = @_;
|
|
my $device = $job->device;
|
|
|
|
return Status->error('arpnip failed: unable to interpret device param')
|
|
unless defined $device;
|
|
|
|
return Status->error("arpnip skipped: $device not yet discovered")
|
|
unless $device->in_storage;
|
|
|
|
return Status->defer("arpnip skipped: $device is pseudo-device")
|
|
if $device->is_pseudo;
|
|
|
|
return Status->defer("arpnip skipped: $device has no layer 3 capability")
|
|
unless $device->has_layer(3);
|
|
|
|
return Status->defer("arpnip deferred: $device is not arpnipable")
|
|
unless is_arpnipable_now($device);
|
|
|
|
return Status->done('arpnip is able to run');
|
|
});
|
|
|
|
true;
|