Squashed commit of the following: commit86d0f61d0bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 16 22:26:32 2017 +0000 fix typo commit5aff19621cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 16 22:10:18 2017 +0000 fix use of snmp_connect_ip which does not work for SNMPv3 commit68a56d35bbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 16 20:50:16 2017 +0000 no need for Array::Iterator even though it was cute commit71ee869c02Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Nov 15 22:14:47 2017 +0000 additional doc examples commit620b3fe544Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Nov 15 22:09:05 2017 +0000 stash workers within poller instance, and load plugins explicitly commit2431365583Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 13 22:17:11 2017 +0000 better fix for duplicate module entity index commita400b26704Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 13 22:14:42 2017 +0000 add ignore interfaces for HPE routers commit1502ec1966Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 13 22:08:02 2017 +0000 bug fixes after testing on a real network commit840b6b4069Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Nov 12 20:38:35 2017 +0000 add tests commit2de36c69baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Nov 12 00:14:21 2017 +0000 some reengineering to support proper testing commitc5f138fe62Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 11 14:43:53 2017 +0000 correct algorithm on finalise status, correct logging commit98442a2308Author: Oliver Gorwits <oliver@cpan.org> Date: Thu Nov 9 21:49:45 2017 +0000 bug fixes commite0c6615c87Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Nov 8 20:29:33 2017 +0000 fix bugs commit1eeaba441dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Nov 7 22:30:55 2017 +0000 finish refactor to new desired behaviour (buggy?) commit7edfe88f25Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 6 22:50:51 2017 +0000 fix to work, and correct namespace check commit25907d3544Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Nov 6 21:26:01 2017 +0000 move status tracking and checking inside job instance commit4436150bf4Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Nov 5 20:54:28 2017 +0000 remove global rubbish commit28b016e713Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 4 23:31:51 2017 +0000 fix docs commit650f6c719bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 4 23:22:12 2017 +0000 tidy line commit10f78d5dbeAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Nov 4 23:06:20 2017 +0000 add priority and namespace to support fancy worker overrides commitb9f9816d09Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Oct 11 18:33:46 2017 +0100 release 2.036012_001 commitc33bf204a4Merge:5b7ce3f7d3d81eb6Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Oct 11 18:30:23 2017 +0100 Merge branch 'master' into og-coreplugins commit5b7ce3f797Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Oct 9 15:46:09 2017 +0100 cannot Sereal::Encode DBIC row commit0a575f02baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Oct 9 14:07:56 2017 +0100 fix bug in job->device init commit207476950dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Oct 9 14:03:37 2017 +0100 default causes no attr to be created?! commit912f2fa91fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 8 18:43:51 2017 +0100 better debug logging commitdfeb9d9ddcAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 8 18:40:02 2017 +0100 make device_auth have driver setting for snmp entries commit460c0c0ee9Merge:3ccd107b98423445Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 8 18:08:58 2017 +0100 Merge branch 'master' into og-coreplugins commit3ccd107bd4Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 14:13:58 2017 +0100 fix bug in device->has_layer commita4b9bf2036Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:58:52 2017 +0100 netdisco-do show takes a param for method in -p commit4389cd0459Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:36:06 2017 +0100 fix to only check last poll on devices in storage commit58d0fbdddaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:21:13 2017 +0100 do not run discover parts if properties failed to complete commitb52aaaf1a1Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:08:46 2017 +0100 fix typo commit41be926921Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:04:45 2017 +0100 run all check workers commita41d114965Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 13:02:46 2017 +0100 fix driver config commitb10908a138Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 12:43:50 2017 +0100 use vars() cache between phases commit08b34e083dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 11:39:17 2017 +0100 remove die() calls commitb8108986fbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 11:31:59 2017 +0100 phase fixups commit273cbbc11bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 09:42:41 2017 +0100 change stage to phase commit256c10bae5Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 09:35:14 2017 +0100 multi worker actions need not return done from all workers commitee38bae48aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 09:05:25 2017 +0100 store result of worker if best for this phase so far commit5bddfc73baAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Oct 7 08:50:31 2017 +0100 auto debug-log worker return messages commit8b660a89c0Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:48:58 2017 +0100 bug fixes commitb58a5816a9Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:44:20 2017 +0100 remove unnecessary check phases commite44f06364aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:18:03 2017 +0100 fix unknown command check in netdisco-do commit3af13f0dfeAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Oct 6 07:15:59 2017 +0100 introduce noop and refactor checks in all workers commit98463c8cadAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 1 10:49:12 2017 +0100 no need to debug log if there are no hooks in phase commit3b32e84312Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Oct 1 08:18:13 2017 +0100 fiddle about with runner logic to fix exit states commit8fdba38ee0Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 08:01:42 2017 +0100 cannot reuse a worker as the job will be already set and the wrong plugins loaded commita155d9cb77Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 08:01:06 2017 +0100 should defer when we cannot connect to device commit10b5f6cbc4Author: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 08:00:32 2017 +0100 fix bug in where workerconf acls are checked commit2a74e0befaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 07:38:05 2017 +0100 can pass device instance to check_* commit4256b117dfAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 07:27:14 2017 +0100 move device_auth build to be with community defaults setting commita2de2c1616Merge:32be11c38dc4b9bcAuthor: Oliver Gorwits <oliver@cpan.org> Date: Fri Sep 29 07:21:03 2017 +0100 Merge branch 'master' into og-coreplugins commit32be11c3ffAuthor: Oliver Gorwits <oliver@cpan.org> Date: Thu Sep 21 00:09:29 2017 +0100 move remaining interactive actions to be plugins commit3e41c93f5aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 20 21:47:50 2017 +0100 clean snmp handling commit30a2d5dd86Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 20 21:00:29 2017 +0100 make sure check plugins are loaded/run before phases commit3454d95a84Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 20 20:53:52 2017 +0100 capture result on main phase as well commit559fa4f93fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 18 22:46:35 2017 +0100 build device_auth from communities commit1969291719Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 18 22:04:22 2017 +0100 simplify to remove phases and fewer hooks commit6f78032e28Author: Oliver Gorwits <oliver@cpan.org> Date: Thu Sep 14 21:30:03 2017 +0100 add phase to test worker commit6edd2dc879Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 21:51:40 2017 +0100 no need to list all plugins commitdfaeb34d8cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 20:42:41 2017 +0100 add reset after messing with snmp context or community index commit09214dce92Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 20:29:21 2017 +0100 no need to pass $snmp around commit58cd488cccAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 19:22:40 2017 +0100 refactor layer and pseudo checks commit753acc607fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 10:53:12 2017 +0100 use overloaded $device commitd5d39289d6Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 13 10:44:31 2017 +0100 rename init stage to check commit1fdb086183Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 12 08:12:12 2017 +0100 refactor to remove second loop commit64a9491115Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 10 16:09:45 2017 +0100 change to init, first, second stages commit5f2da69697Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 22:26:04 2017 +0100 move discover and discoverall to worker plugins commitc6ebb7cf07Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 16:44:32 2017 +0100 move arpnip and arpwalk to worker plugins commit16a79463cbAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 16:27:58 2017 +0100 set snmp driver on macsuck phase workers commit9167e02de5Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 15:55:53 2017 +0100 move macsuck and macwalk to worker plugins (macsuck needs snmp scope guard) commit68ca85643bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 14:56:15 2017 +0100 move expire and expirenodes to worker plugins commit271ef1a25cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 9 14:46:00 2017 +0100 move nbtstat and nbtwalk to worker plugins commite7508a9ecaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 21:23:54 2017 +0100 move all netdisco-do action to worker plugins commit707fc82b99Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 21:01:37 2017 +0100 remove psql code from netdisco-do and fix detection of misspelled action commit411918e3f8Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 20:56:26 2017 +0100 only load worker plugins for the action commit1f9740c0e2Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 18:30:43 2017 +0100 shorten hook names commita59c23de79Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Sep 6 18:27:34 2017 +0100 make psql worker primary, add hook debug log commit36c70220a2Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 22:39:22 2017 +0100 allow two forms of worker declaration, and update docs commita79cb9a9e4Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 22:10:53 2017 +0100 all the bug fixes and a working plugin!!!!!!!!! :-D commit04896202e0Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 21:39:41 2017 +0100 refine runner commit547fce2f3cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 20:56:21 2017 +0100 hack the status class to regen if needed commitcd71a0b7a8Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 20:41:05 2017 +0100 move status update to job class commitc8e5cea4edAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 20:37:13 2017 +0100 objectify the running commitf48004fffaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:58:28 2017 +0100 bug squish commit46ece568f6Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:54:57 2017 +0100 implement runner?! commitfc9c60f707Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:28:38 2017 +0100 rename ok to is_ok and change slot names to avoid conflict with creators commit3ee85383abAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Sep 5 19:25:41 2017 +0100 skip worker when action is per-device but no creds commit75abdad812Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 21:54:37 2017 +0100 further work on retval handling from workers commit4c1fdf4f92Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:37:53 2017 +0100 move worker plugin loader to Worker.pm commitbe0c5181a3Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:35:42 2017 +0100 move Runner to Worker namespace commit1c2cf924bcAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:33:20 2017 +0100 worker roles in Role namespace commit3099eda393Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Sep 4 20:30:58 2017 +0100 load workers when runner role is loaded commita8c58a7b05Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 22:30:28 2017 +0100 initial broken implementation of the runner commit49b5274c33Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 19:04:20 2017 +0100 use run() mixin to exec action commite0a666668aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 18:54:44 2017 +0100 fix pod; set status defaults; stub runner mixin commit8eaa33770cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 18:45:00 2017 +0100 rename Core to Worker and move other packages around commit4def0af0b0Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 17:58:03 2017 +0100 better use of new status class commit8675bf62c6Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 17:27:38 2017 +0100 fix hook naming and implement primary workers commitef1bb81f2bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 17:26:27 2017 +0100 new backend status class commit5f50dfadf1Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 16:51:55 2017 +0100 new Backend package to load core plugins commit3baa7a818aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 16:22:29 2017 +0100 remove unnecessary Worker::Common role commit36b4adcc06Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Sep 3 16:17:29 2017 +0100 disambiguate util/backend package and remove backend prelaod commit98bff731bdAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Sep 2 08:25:06 2017 +0100 settle on a design for hook override, I think commitfe5c16a16dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Aug 30 20:37:36 2017 +0100 rework docs to be more clear and reflect new operation commitb34ba1977cMerge:31d1977fc34ed61dAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Aug 21 21:17:46 2017 +0100 Merge branch 'master' into og-coreplugins commit31d1977f1eAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Aug 14 18:11:42 2017 +0100 Revert "move expire code to be initial plugin pilot (broken)" I think we'll only do the new backend code for jobs with a device. This reverts commit07998b72d9. commit61dc80aff8Merge:07998b72ade02db1Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Aug 14 18:10:29 2017 +0100 Merge branch 'master' into og-coreplugins commit07998b72d9Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 22:15:00 2017 +0100 move expire code to be initial plugin pilot (broken) commit685ec02108Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 22:10:58 2017 +0100 pass $job to the core worker commitd6523fe543Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 22:01:49 2017 +0100 $job->device is always a DBIC row commitee6deea01bAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 18:12:34 2017 +0100 load plugins commitfd80096ca2Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Aug 5 16:53:16 2017 +0100 rename all the things commit464c42d1f5Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Aug 2 10:19:16 2017 +0100 use Scope::Guard to reduce device_auth commitec041dafd2Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Aug 1 15:34:37 2017 +0100 the other way around commit33d2fe13bdAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Jul 31 17:57:29 2017 +0100 fix pod commit3faee1cf16Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Jul 31 17:55:10 2017 +0100 remove need for instance() call commitc6d0f1c035Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 13:51:23 2017 +0100 add doc note on accessing transports commitdca4b4fc03Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 11:50:10 2017 +0100 add backend driver documentation commit052a2acd79Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 10:16:58 2017 +0100 rename web plugins doc commit69c9a6393aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 26 10:12:42 2017 +0100 rename args to driverconf commit2586a36f8cAuthor: Oliver Gorwits <oliver@cpan.org> Date: Tue Jul 25 22:41:10 2017 +0100 new version of core plugin manager with better config and filters commit4056831f99Author: Oliver Gorwits <oliver@cpan.org> Date: Tue Jul 25 20:53:56 2017 +0100 change SNMP to be a cached transport singleton commitc31030ef70Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Jul 23 13:46:27 2017 +0100 fixes because Dancer docs are a mess! commitf65ef90b86Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Jul 22 08:11:36 2017 +0100 rename snmp_auth to device_auth and include a little doc on transports commitd61556e1cfAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Jul 22 07:54:26 2017 +0100 plugin config added commitde8de56308Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Jul 12 21:38:31 2017 +0100 initial core plugin implementation
339 lines
11 KiB
Perl
339 lines
11 KiB
Perl
package App::Netdisco::Worker::Plugin::Discover::Neighbors;
|
||
|
||
use Dancer ':syntax';
|
||
use App::Netdisco::Worker::Plugin;
|
||
use aliased 'App::Netdisco::Worker::Status';
|
||
|
||
use App::Netdisco::Transport::SNMP ();
|
||
use App::Netdisco::Util::Device
|
||
qw/get_device match_devicetype is_discoverable/;
|
||
use App::Netdisco::Util::Permission 'check_acl_no';
|
||
use App::Netdisco::JobQueue 'jq_insert';
|
||
use Dancer::Plugin::DBIC 'schema';
|
||
use List::MoreUtils ();
|
||
use NetAddr::MAC;
|
||
use Encode;
|
||
|
||
=head2 discover_new_neighbors( )
|
||
|
||
Given a Device database object, and a working SNMP connection, discover and
|
||
store the device's port neighbors information.
|
||
|
||
Entries in the Topology database table will override any discovered device
|
||
port relationships.
|
||
|
||
The Device database object can be a fresh L<DBIx::Class::Row> object which is
|
||
not yet stored to the database.
|
||
|
||
Any discovered neighbor unknown to Netdisco will have a C<discover> job
|
||
immediately queued (subject to the filtering by the C<discover_*> settings).
|
||
|
||
=cut
|
||
|
||
register_worker({ phase => 'main', driver => 'snmp' }, sub {
|
||
my ($job, $workerconf) = @_;
|
||
|
||
my $device = $job->device;
|
||
return unless $device->in_storage;
|
||
my $snmp = App::Netdisco::Transport::SNMP->reader_for($device)
|
||
or return Status->defer("discover failed: could not SNMP connect to $device");
|
||
|
||
my @to_discover = store_neighbors($device);
|
||
|
||
# only enqueue if device is not already discovered,
|
||
# discover_* config permits the discovery
|
||
foreach my $neighbor (@to_discover) {
|
||
my ($ip, $remote_type) = @$neighbor;
|
||
|
||
my $device = get_device($ip);
|
||
next if $device->in_storage;
|
||
|
||
if (not is_discoverable($device, $remote_type)) {
|
||
debug sprintf
|
||
' queue - %s, type [%s] excluded by discover_* config',
|
||
$ip, ($remote_type || '');
|
||
next;
|
||
}
|
||
|
||
jq_insert({
|
||
device => $ip,
|
||
action => 'discover',
|
||
subaction => 'with-nodes',
|
||
});
|
||
}
|
||
});
|
||
|
||
=head2 store_neighbors( $device )
|
||
|
||
returns: C<@to_discover>
|
||
|
||
Given a Device database object, and a working SNMP connection, discover and
|
||
store the device's port neighbors information.
|
||
|
||
Entries in the Topology database table will override any discovered device
|
||
port relationships.
|
||
|
||
The Device database object can be a fresh L<DBIx::Class::Row> object which is
|
||
not yet stored to the database.
|
||
|
||
A list of discovererd neighbors will be returned as [C<$ip>, C<$type>] tuples.
|
||
|
||
=cut
|
||
|
||
sub store_neighbors {
|
||
my $device = shift;
|
||
my @to_discover = ();
|
||
|
||
my $snmp = App::Netdisco::Transport::SNMP->reader_for($device)
|
||
or return (); # already checked!
|
||
|
||
# first allow any manually configured topology to be set
|
||
set_manual_topology($device);
|
||
|
||
if (!defined $snmp->has_topo) {
|
||
debug sprintf ' [%s] neigh - neighbor protocols are not enabled', $device->ip;
|
||
return @to_discover;
|
||
}
|
||
|
||
my $interfaces = $snmp->interfaces;
|
||
my $c_if = $snmp->c_if;
|
||
my $c_port = $snmp->c_port;
|
||
my $c_id = $snmp->c_id;
|
||
my $c_platform = $snmp->c_platform;
|
||
my $c_cap = $snmp->c_cap;
|
||
|
||
# v4 and v6 neighbor tables
|
||
my $c_ip = ($snmp->c_ip || {});
|
||
my %c_ipv6 = %{ ($snmp->can('hasLLDP') and $snmp->hasLLDP)
|
||
? ($snmp->lldp_ipv6 || {}) : {} };
|
||
|
||
# remove keys with undef values, as c_ip does
|
||
delete @c_ipv6{ grep { not defined $c_ipv6{$_} } keys %c_ipv6 };
|
||
# now combine them, v6 wins
|
||
$c_ip = { %$c_ip, %c_ipv6 };
|
||
|
||
foreach my $entry (sort (List::MoreUtils::uniq( (keys %$c_ip), (keys %$c_cap) ))) {
|
||
if (!defined $c_if->{$entry} or !defined $interfaces->{ $c_if->{$entry} }) {
|
||
debug sprintf ' [%s] neigh - port for IID:%s not resolved, skipping',
|
||
$device->ip, $entry;
|
||
next;
|
||
}
|
||
|
||
my $port = $interfaces->{ $c_if->{$entry} };
|
||
my $portrow = schema('netdisco')->resultset('DevicePort')
|
||
->single({ip => $device->ip, port => $port});
|
||
|
||
if (!defined $portrow) {
|
||
info sprintf ' [%s] neigh - local port %s not in database!',
|
||
$device->ip, $port;
|
||
next;
|
||
}
|
||
|
||
if (ref $c_ip->{$entry}) {
|
||
error sprintf ' [%s] neigh - Error! port %s has multiple neighbors - skipping',
|
||
$device->ip, $port;
|
||
next;
|
||
}
|
||
|
||
my $remote_ip = $c_ip->{$entry};
|
||
my $remote_port = undef;
|
||
my $remote_type = Encode::decode('UTF-8', $c_platform->{$entry} || '');
|
||
my $remote_id = Encode::decode('UTF-8', $c_id->{$entry});
|
||
my $remote_cap = $c_cap->{$entry} || [];
|
||
|
||
# IP Phone and WAP detection type fixup
|
||
if (scalar @$remote_cap or $remote_type) {
|
||
my $phone_flag = grep {match_devicetype($_, 'phone_capabilities')}
|
||
@$remote_cap;
|
||
my $ap_flag = grep {match_devicetype($_, 'wap_capabilities')}
|
||
@$remote_cap;
|
||
|
||
if ($phone_flag or match_devicetype($remote_type, 'phone_platforms')) {
|
||
$remote_type = 'IP Phone: '. $remote_type
|
||
if $remote_type !~ /ip.phone/i;
|
||
}
|
||
elsif ($ap_flag or match_devicetype($remote_type, 'wap_platforms')) {
|
||
$remote_type = 'AP: '. $remote_type;
|
||
}
|
||
|
||
$portrow->update({remote_type => $remote_type});
|
||
}
|
||
|
||
if ($portrow->manual_topo) {
|
||
info sprintf ' [%s] neigh - %s has manually defined topology',
|
||
$device->ip, $port;
|
||
next;
|
||
}
|
||
|
||
next unless $remote_ip;
|
||
|
||
# a bunch of heuristics to search known devices if we don't have a
|
||
# useable remote IP...
|
||
|
||
if ($remote_ip eq '0.0.0.0' or
|
||
check_acl_no($remote_ip, 'group:__LOCAL_ADDRESSES__')) {
|
||
|
||
if ($remote_id) {
|
||
my $devices = schema('netdisco')->resultset('Device');
|
||
my $neigh = $devices->single({name => $remote_id});
|
||
info sprintf
|
||
' [%s] neigh - bad address %s on port %s, searching for %s instead',
|
||
$device->ip, $remote_ip, $port, $remote_id;
|
||
|
||
if (!defined $neigh) {
|
||
my $mac = NetAddr::MAC->new(mac => $remote_id);
|
||
if ($mac and not $mac->errstr) {
|
||
$neigh = $devices->single({mac => $mac->as_ieee});
|
||
}
|
||
}
|
||
|
||
# some HP switches send 127.0.0.1 as remote_ip if no ip address
|
||
# on default vlan for HP switches remote_ip looks like
|
||
# "myswitchname(012345-012345)"
|
||
if (!defined $neigh) {
|
||
(my $tmpid = $remote_id) =~ s/.*\(([0-9a-f]{6})-([0-9a-f]{6})\).*/$1$2/;
|
||
my $mac = NetAddr::MAC->new(mac => $tmpid);
|
||
if ($mac and not $mac->errstr) {
|
||
info sprintf
|
||
'[%s] neigh - found neighbor %s by MAC %s',
|
||
$device->ip, $remote_id, $mac->as_ieee;
|
||
$neigh = $devices->single({mac => $mac->as_ieee});
|
||
}
|
||
}
|
||
|
||
if (!defined $neigh) {
|
||
(my $shortid = $remote_id) =~ s/\..*//;
|
||
$neigh = $devices->single({name => { -ilike => "${shortid}%" }});
|
||
}
|
||
|
||
if ($neigh) {
|
||
$remote_ip = $neigh->ip;
|
||
info sprintf ' [%s] neigh - found %s with IP %s',
|
||
$device->ip, $remote_id, $remote_ip;
|
||
}
|
||
else {
|
||
info sprintf ' [%s] neigh - could not find %s, skipping',
|
||
$device->ip, $remote_id;
|
||
next;
|
||
}
|
||
}
|
||
else {
|
||
info sprintf ' [%s] neigh - skipping unuseable address %s on port %s',
|
||
$device->ip, $remote_ip, $port;
|
||
next;
|
||
}
|
||
}
|
||
|
||
# what we came here to do.... discover the neighbor
|
||
debug sprintf
|
||
' [%s] neigh - adding neighbor %s, type [%s], on %s to discovery queue',
|
||
$device->ip, $remote_ip, ($remote_type || ''), $port;
|
||
push @to_discover, [$remote_ip, $remote_type];
|
||
|
||
$remote_port = $c_port->{$entry};
|
||
if (defined $remote_port) {
|
||
# clean weird characters
|
||
$remote_port =~ s/[^\d\/\.,()\w:-]+//gi;
|
||
}
|
||
else {
|
||
info sprintf ' [%s] neigh - no remote port found for port %s at %s',
|
||
$device->ip, $port, $remote_ip;
|
||
}
|
||
|
||
$portrow->update({
|
||
remote_ip => $remote_ip,
|
||
remote_port => $remote_port,
|
||
remote_type => $remote_type,
|
||
remote_id => $remote_id,
|
||
is_uplink => \"true",
|
||
manual_topo => \"false",
|
||
});
|
||
|
||
# update master of our aggregate to be a neighbor of
|
||
# the master on our peer device (a lot of iffs to get there...).
|
||
# & cannot use ->neighbor prefetch because this is the port insert!
|
||
if (defined $portrow->slave_of) {
|
||
|
||
my $peer_device = get_device($remote_ip);
|
||
my $master = schema('netdisco')->resultset('DevicePort')->single({
|
||
ip => $device->ip,
|
||
port => $portrow->slave_of
|
||
});
|
||
|
||
if ($peer_device and $peer_device->in_storage and $master
|
||
and not ($portrow->is_master or defined $master->slave_of)) {
|
||
|
||
my $peer_port = schema('netdisco')->resultset('DevicePort')->single({
|
||
ip => $peer_device->ip,
|
||
port => $portrow->remote_port,
|
||
});
|
||
|
||
$master->update({
|
||
remote_ip => ($peer_device->ip || $remote_ip),
|
||
remote_port => ($peer_port ? $peer_port->slave_of : undef ),
|
||
is_uplink => \"true",
|
||
is_master => \"true",
|
||
manual_topo => \"false",
|
||
});
|
||
}
|
||
}
|
||
}
|
||
|
||
return @to_discover;
|
||
}
|
||
|
||
# take data from the topology table and update remote_ip and remote_port
|
||
# in the devices table. only use root_ips and skip any bad topo entries.
|
||
sub set_manual_topology {
|
||
my $device = shift;
|
||
my $snmp = App::Netdisco::Transport::SNMP->reader_for($device) or return;
|
||
|
||
schema('netdisco')->txn_do(sub {
|
||
# clear manual topology flags
|
||
schema('netdisco')->resultset('DevicePort')
|
||
->search({ip => $device->ip})->update({manual_topo => \'false'});
|
||
|
||
my $topo_links = schema('netdisco')->resultset('Topology')
|
||
->search({-or => [dev1 => $device->ip, dev2 => $device->ip]});
|
||
debug sprintf ' [%s] neigh - setting manual topology links', $device->ip;
|
||
|
||
while (my $link = $topo_links->next) {
|
||
# could fail for broken topo, but we ignore to try the rest
|
||
try {
|
||
schema('netdisco')->txn_do(sub {
|
||
# only work on root_ips
|
||
my $left = get_device($link->dev1);
|
||
my $right = get_device($link->dev2);
|
||
|
||
# skip bad entries
|
||
return unless ($left->in_storage and $right->in_storage);
|
||
|
||
$left->ports
|
||
->single({port => $link->port1})
|
||
->update({
|
||
remote_ip => $right->ip,
|
||
remote_port => $link->port2,
|
||
remote_type => undef,
|
||
remote_id => undef,
|
||
is_uplink => \"true",
|
||
manual_topo => \"true",
|
||
});
|
||
|
||
$right->ports
|
||
->single({port => $link->port2})
|
||
->update({
|
||
remote_ip => $left->ip,
|
||
remote_port => $link->port1,
|
||
remote_type => undef,
|
||
remote_id => undef,
|
||
is_uplink => \"true",
|
||
manual_topo => \"true",
|
||
});
|
||
});
|
||
};
|
||
}
|
||
});
|
||
}
|
||
|
||
true;
|