Squashed commit of the following:
commit 4081e22202693bd7c4ea00e95daad8e628c6fd5a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Mon May 29 21:02:07 2023 +0100
large rename of check_acl* to acl_matches*
commit 3cfa284ddd24d68765c255578cc5c184afbdcd83
Author: Oliver Gorwits <oliver@cpan.org>
Date: Fri May 19 20:39:03 2023 +0100
update permission doc
commit 8c7bb93cc5e9fafb770f98f446e45cbd94b14894
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed May 17 21:50:07 2023 +0100
migrate most check_acl_only to acl_matches_only
commit c47f699f2a22f08f2f3e093ed0f24c891e6f9a82
Author: Oliver Gorwits <oliver@cpan.org>
Date: Wed May 17 21:39:19 2023 +0100
rename check_acl* to be acl_matches*
commit a884a22c3ab1f3262118c3a47ed8e25b0b0a7336
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun May 14 16:50:42 2023 +0100
update macsuck_no_deviceports to use acl_matches
commit 8c256af728721329b64d071fa529dfc844073ac6
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun May 7 22:54:33 2023 +0100
update hide_deviceports to use acl_matches multi @things
commit cd5d9978aba1da459be4fed4500f395df13f7784
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sun May 7 22:53:38 2023 +0100
check_acl fix to allow all @things to offer a property before fallback to missing as empty string
commit 1a3ab9a7646e9f994f03126d45fc36e9e5a13ed5
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue May 2 15:31:17 2023 +0100
add ignore_deviceports to portproperties discover; improve comments
commit 51385ce89458dc939587dae902fda431719c22c9
Merge: b97c07d2 3f8ffe78
Author: Oliver Gorwits <oliver@cpan.org>
Date: Tue May 2 15:21:48 2023 +0100
Merge branch 'master' into og-acl_multidict
commit b97c07d237d750c1d9eb3095d8ff3908512eac2a
Author: Oliver Gorwits <oliver@cpan.org>
Date: Sat Mar 25 14:37:53 2023 +0000
add support for arrayref of items, and unblessed hash, to check_acl
102 lines
3.2 KiB
Perl
102 lines
3.2 KiB
Perl
package App::Netdisco::Worker::Plugin::Discover::CanonicalIP;
|
||
|
||
use Dancer ':syntax';
|
||
use App::Netdisco::Worker::Plugin;
|
||
use aliased 'App::Netdisco::Worker::Status';
|
||
|
||
use App::Netdisco::Transport::SNMP ();
|
||
use App::Netdisco::Util::Permission 'acl_matches';
|
||
use App::Netdisco::Util::DNS 'ipv4_from_hostname';
|
||
use App::Netdisco::Util::Device 'is_discoverable';
|
||
use Dancer::Plugin::DBIC 'schema';
|
||
|
||
register_worker({ phase => 'main', driver => 'snmp' }, sub {
|
||
my ($job, $workerconf) = @_;
|
||
|
||
my $device = $job->device;
|
||
return unless $device->in_storage;
|
||
my $snmp = App::Netdisco::Transport::SNMP->reader_for($device)
|
||
or return Status->defer("discover failed: could not SNMP connect to $device");
|
||
|
||
my $old_ip = $device->ip;
|
||
my $new_ip = $old_ip;
|
||
my $revofname = ipv4_from_hostname($snmp->name);
|
||
|
||
if (setting('reverse_sysname') and $revofname) {
|
||
if (App::Netdisco::Transport::SNMP->test_connection( $new_ip )) {
|
||
$new_ip = $revofname;
|
||
}
|
||
else {
|
||
debug sprintf ' [%s] device - cannot renumber to %s - SNMP connect failed',
|
||
$old_ip, $revofname;
|
||
}
|
||
}
|
||
|
||
if (scalar @{ setting('device_identity') }) {
|
||
my @idmaps = @{ setting('device_identity') };
|
||
my @devips = $device->device_ips->order_by('alias')->all;
|
||
|
||
# using ALIASMAP break so that we stop after first successful renumber
|
||
|
||
ALIASMAP: foreach my $map (@idmaps) {
|
||
next unless ref {} eq ref $map;
|
||
|
||
foreach my $key (sort keys %$map) {
|
||
# lhs matches device, rhs matches device_ip
|
||
next unless $key and $map->{$key};
|
||
next unless acl_matches($device, $key);
|
||
|
||
foreach my $alias (@devips) {
|
||
next if $alias->alias eq $old_ip;
|
||
next unless acl_matches($alias, $map->{$key});
|
||
|
||
if (not is_discoverable( $alias->alias )) {
|
||
debug sprintf ' [%s] device - cannot renumber to %s - not discoverable',
|
||
$old_ip, $alias->alias;
|
||
next;
|
||
}
|
||
|
||
if (App::Netdisco::Transport::SNMP->test_connection( $alias->alias )) {
|
||
$new_ip = $alias->alias;
|
||
last ALIASMAP;
|
||
}
|
||
else {
|
||
debug sprintf ' [%s] device - cannot renumber to %s - SNMP connect failed',
|
||
$old_ip, $alias->alias;
|
||
}
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
return if $new_ip eq $old_ip;
|
||
|
||
schema('netdisco')->txn_do(sub {
|
||
my $existing = schema('netdisco')->resultset('Device')->search({
|
||
ip => $new_ip, vendor => $device->vendor, serial => $device->serial,
|
||
});
|
||
|
||
if (($job->subaction eq 'with-nodes') and $existing->count) {
|
||
$device->delete;
|
||
return $job->cancel(
|
||
" [$old_ip] device - cancelling fresh discover: already known as $new_ip");
|
||
}
|
||
|
||
# discover existing device but change IP, need to remove existing device
|
||
$existing->delete;
|
||
|
||
# if target device exists then this will die
|
||
$device->renumber($new_ip)
|
||
or die "cannot renumber to: $new_ip"; # rollback
|
||
|
||
# is not done in renumber, but required, otherwise confusing at job end!
|
||
schema('netdisco')->resultset('Admin')
|
||
->find({job => $job->id})->update({device => $new_ip}) if $job->id;
|
||
|
||
return Status->info(sprintf ' [%s] device - changed IP to %s (%s)',
|
||
$old_ip, $device->ip, ($device->dns || ''));
|
||
});
|
||
});
|
||
|
||
true;
|