Squashed commit of the following: commit3fe8f383a7Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Mar 11 17:07:42 2019 +0000 add debug lines and tested commit3249739e42Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Mar 11 16:54:11 2019 +0000 change config name to get_credentials commite78558397aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Mon Mar 11 16:51:11 2019 +0000 separate out generic device auth to DeviceAuth module commit249f05165fAuthor: Oliver Gorwits <oliver@cpan.org> Date: Wed Mar 6 18:43:31 2019 +0000 release 2.040007 commite3af64df77Author: Oliver Gorwits <oliver@cpan.org> Date: Wed Mar 6 18:42:47 2019 +0000 #521-redux fix wifi date search commit48857ae300Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Mar 4 12:03:31 2019 +0000 release 2.040006 commite09dab5362Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Mar 4 11:39:12 2019 +0000 #527 update List::MoreUtils version requirement commit6e7de3fff3Author: Oliver Gorwits <oliver@cpan.org> Date: Mon Mar 4 09:59:41 2019 +0000 release 2.040005 commit0c98318a45Author: Oliver Gorwits <oliver@spike.local> Date: Mon Mar 4 09:57:18 2019 +0000 #526 fix discover syntax bug commite9efc45182Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 14:56:48 2019 +0000 release 2.040004 commit6cdfd80d10Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 14:34:00 2019 +0000 allow undiscovered neighbors report to use discover_{waps,phones} setting commitac381e0802Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 14:13:20 2019 +0000 #506 was a red herring commitb83e614c85Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 13:00:36 2019 +0000 make discover_{phones,waps} work with LLDP capabilities as well commit189d234b55Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 12:47:38 2019 +0000 check discover_no_type and friends earlier on in neighbors list build commit9c956466f3Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 12:32:07 2019 +0000 also update default config for new discover_phones and discover_waps settings commit09d29954d2Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 12:26:50 2019 +0000 #512 fix regression in phone/wap discovery exclusion commit2bae91f1b6Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 12:01:34 2019 +0000 rename match_devicetype() to match_to_setting() commit57cb6ddb70Author: Oliver Gorwits <oliver@cpan.org> Date: Sun Mar 3 09:19:39 2019 +0000 fix for over-eager fix to #506 commitef560fb59aAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 22:41:40 2019 +0000 #506 relax device renumber so it works for an alias commit7a8bcb094eAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 22:23:39 2019 +0000 #521 Search Node Date Range not working commita643820a62Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 21:54:27 2019 +0000 #428 Port-Channels not showing in netmap commit5ba5bcd295Merge:e7aacddba1f95028Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 20:04:11 2019 +0000 Merge branch 'master' of github.com:netdisco/netdisco commite7aacddbc6Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 20:01:05 2019 +0000 #498 Map with VLAN filter omits unconnected devices commita1f95028caAuthor: nick n <39005454+inphobia@users.noreply.github.com> Date: Sat Mar 2 19:54:22 2019 +0100 catch up with changes noticed that rc-sshcollector-core received updates to changes, add them here as well. didn't mention #499 & #522 commitce1b847ceaAuthor: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 18:47:44 2019 +0000 fix bug showing no nodes when only one matches in netmap commit78e30a7926Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 16:28:15 2019 +0000 #500 filtering in device/ports on native vlan duplicates entries commit9952f0c6c7Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 15:02:12 2019 +0000 #499 netdisco-do renumber reports wrong ip (inphobia) commitca3fd8f466Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 15:00:18 2019 +0000 #505 device renumber should update device port properties and device skips commit1265bc8470Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 14:52:21 2019 +0000 #520 catch slave ports defined without a master commitd4c7579c10Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 14:47:49 2019 +0000 #522 TypeAhead.pm can reference empty data (inphobia) commit77decc23b7Author: Oliver Gorwits <oliver@cpan.org> Date: Sat Mar 2 14:45:37 2019 +0000 #514 inconsistent results in ip inventory (inphobia) commit3f211650b8Author: nick n <39005454+inphobia@users.noreply.github.com> Date: Fri Mar 1 12:34:42 2019 +0100 last pieces for db schema upgrade last piece of #510
120 lines
3.3 KiB
Perl
120 lines
3.3 KiB
Perl
package App::Netdisco::Util::SNMP;
|
|
|
|
use Dancer qw/:syntax :script/;
|
|
use App::Netdisco::Util::DeviceAuth 'get_external_credentials';
|
|
|
|
use base 'Exporter';
|
|
our @EXPORT = ();
|
|
our @EXPORT_OK = qw/ get_communities snmp_comm_reindex /;
|
|
our %EXPORT_TAGS = (all => \@EXPORT_OK);
|
|
|
|
=head1 NAME
|
|
|
|
App::Netdisco::Util::SNMP
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
Helper functions for L<SNMP::Info> instances.
|
|
|
|
There are no default exports, however the C<:all> tag will export all
|
|
subroutines.
|
|
|
|
=head1 EXPORT_OK
|
|
|
|
=head2 get_communities( $device, $mode )
|
|
|
|
Takes the current C<device_auth> setting and pushes onto the front of the list
|
|
the last known good SNMP settings used for this mode (C<read> or C<write>).
|
|
|
|
=cut
|
|
|
|
sub get_communities {
|
|
my ($device, $mode) = @_;
|
|
$mode ||= 'read';
|
|
|
|
my $seen_tags = {}; # for cleaning community table
|
|
my $config = (setting('device_auth') || []);
|
|
my @communities = ();
|
|
|
|
# first of all, use external command if configured
|
|
push @communities, get_external_credentials($device, $mode);
|
|
|
|
# last known-good by tag
|
|
my $tag_name = 'snmp_auth_tag_'. $mode;
|
|
my $stored_tag = eval { $device->community->$tag_name };
|
|
|
|
if ($device->in_storage and $stored_tag) {
|
|
foreach my $stanza (@$config) {
|
|
if ($stanza->{tag} and $stored_tag eq $stanza->{tag}) {
|
|
push @communities, {%$stanza, only => [$device->ip]};
|
|
last;
|
|
}
|
|
}
|
|
}
|
|
|
|
# try last-known-good v2 read
|
|
push @communities, {
|
|
read => 1, write => 0, driver => 'snmp',
|
|
only => [$device->ip],
|
|
community => $device->snmp_comm,
|
|
} if defined $device->snmp_comm and $mode eq 'read';
|
|
|
|
# try last-known-good v2 write
|
|
my $snmp_comm_rw = eval { $device->community->snmp_comm_rw };
|
|
push @communities, {
|
|
write => 1, read => 0, driver => 'snmp',
|
|
only => [$device->ip],
|
|
community => $snmp_comm_rw,
|
|
} if $snmp_comm_rw and $mode eq 'write';
|
|
|
|
# clean the community table of obsolete tags
|
|
eval { $device->community->update({$tag_name => undef}) }
|
|
if $device->in_storage
|
|
and (not $stored_tag or !exists $seen_tags->{ $stored_tag });
|
|
|
|
return ( @communities, @$config );
|
|
}
|
|
|
|
=head2 snmp_comm_reindex( $snmp, $device, $vlan )
|
|
|
|
Takes an established L<SNMP::Info> instance and makes a fresh connection using
|
|
community indexing, with the given C<$vlan> ID. Works for all SNMP versions.
|
|
|
|
Passing VLAN "C<0>" (zero) will reset the indexing to the basic v2 community
|
|
or v3 empty context.
|
|
|
|
=cut
|
|
|
|
sub snmp_comm_reindex {
|
|
my ($snmp, $device, $vlan) = @_;
|
|
my $ver = $snmp->snmp_ver;
|
|
|
|
if ($ver == 3) {
|
|
my $prefix = '';
|
|
my @comms = get_communities($device, 'read');
|
|
# find a context prefix configured by the user
|
|
foreach my $c (@comms) {
|
|
next unless $c->{tag}
|
|
and $c->{tag} eq (eval { $device->community->snmp_auth_tag_read } || '');
|
|
$prefix = $c->{context_prefix} and last;
|
|
}
|
|
$prefix ||= 'vlan-';
|
|
|
|
debug
|
|
sprintf '[%s] reindexing to "%s%s" (ver: %s, class: %s)',
|
|
$device->ip, $prefix, $vlan, $ver, $snmp->class;
|
|
$vlan ? $snmp->update(Context => ($prefix . $vlan))
|
|
: $snmp->update(Context => '');
|
|
}
|
|
else {
|
|
my $comm = $snmp->snmp_comm;
|
|
|
|
debug sprintf '[%s] reindexing to vlan %s (ver: %s, class: %s)',
|
|
$device->ip, $vlan, $ver, $snmp->class;
|
|
$vlan ? $snmp->update(Community => $comm . '@' . $vlan)
|
|
: $snmp->update(Community => $comm);
|
|
}
|
|
}
|
|
|
|
true;
|