135/snmp-info
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i don't think layer2 is needed, layer3 alrdy has all the same includes (#354)

Browse Source 
and no layer2 specific functions that are not overwritten are used.

also, os name -> lowercase
mention 1 more used mib
This commit is contained in:
nick n
2019-08-26 14:37:15 +02:00
committed by GitHub
parent 68b001105d
commit 0f01c6c07c
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/SNMP/Info/Layer3/SonicWALL.pm
View File

@@ -40,21 +40,25 @@ our ($VERSION, %GLOBALS, %MIBS, %FUNCS, %MUNGE);
$VERSION = '3.68'; $VERSION = '3.68';
%MIBS = ( %MIBS = (
%SNMP::Info::Layer2::MIBS, %SNMP::Info::Layer3::MIBS, %SNMP::Info::Layer3::MIBS,
'SNWL-COMMON-MIB' => 'snwlCommonModule', 'SNWL-COMMON-MIB' => 'snwlCommonModule',
); );
%GLOBALS = ( %GLOBALS = (
%SNMP::Info::Layer2::GLOBALS, %SNMP::Info::Layer3::GLOBALS, %SNMP::Info::Layer3::GLOBALS,
#From SNWL-COMMON-MIB #From SNWL-COMMON-MIB
'sw_model' => 'snwlSysModel', 'sw_model' => 'snwlSysModel',
'sw_serial' => 'snwlSysSerialNumber', 'sw_serial' => 'snwlSysSerialNumber',
'sw_firmware' => 'snwlSysFirmwareVersion', 'sw_firmware' => 'snwlSysFirmwareVersion',
); );
%FUNCS = ( %SNMP::Info::Layer2::FUNCS, %SNMP::Info::Layer3::FUNCS, ); %FUNCS = (
%SNMP::Info::Layer3::FUNCS,
);
%MUNGE = ( %SNMP::Info::Layer2::MUNGE, %SNMP::Info::Layer3::MUNGE, ); %MUNGE = (
%SNMP::Info::Layer3::MUNGE,
);
sub vendor { sub vendor {
return 'sonicwall'; return 'sonicwall';
@@ -64,9 +68,9 @@ sub os {
my $sonicos = shift; my $sonicos = shift;
my $swos = $sonicos->sw_firmware(); my $swos = $sonicos->sw_firmware();
if ($swos =~ /Enhanced/) { if ($swos =~ /Enhanced/) {
return 'SonicOS Enhanced'; return 'sonicos enhanced';
} }
return 'SonicOS Standard'; return 'sonicos standard';
} }
sub os_ver { sub os_ver {
@@ -131,6 +135,8 @@ Subclass for Generic SonicWALL Firewalls
=over =over
=item F<SONICWALL-SMI>
=item F<SNWL-COMMON-MIB> =item F<SNWL-COMMON-MIB>
=item Inherited Classes' MIBs =item Inherited Classes' MIBs
@@ -153,7 +159,7 @@ Returns C<'sonicwall'>
=item $router->os() =item $router->os()
Returns C<'SonicOS'> Returns C<'sonicos enhanded'> or C<'sonicos standard'> based on C<'snwlSysFirmwareVersion'>
=item $router->os_ver() =item $router->os_ver()