From 158ee40f1bfca05ee3b8b6e9437312a5c9db2f6d Mon Sep 17 00:00:00 2001
From: "Eric A. Miller" <emiller@cpan.org>
Date: Tue, 24 Jun 2014 21:14:14 -0400
Subject: [PATCH] Correctly identify device type (class) for instantiated
 objects which have overridden layers.

---
 ChangeLog |  5 +++++
 Info.pm   | 50 ++++++++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 51 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 53c2be8d..dda4d11b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -6,6 +6,11 @@ version 3.18
 
     * Pseudo ENTITY-MIB methods added to L3::Tasman for hardware information
 
+   [BUG FIXES]
+
+    * Correctly identify device type (class) for instantiated objects which
+      have overridden layers. 
+
 version 3.17 (2014-06-23)
 
    [ENHANCEMENTS]
diff --git a/Info.pm b/Info.pm
index 541c21ce..3a261fba 100644
--- a/Info.pm
+++ b/Info.pm
@@ -1496,7 +1496,9 @@ sub device_type {
         8072 => 'SNMP::Info::Layer3::NetSNMP',
         9303 => 'SNMP::Info::Layer3::PacketFront',
         12325 => 'SNMP::Info::Layer3::Pf',
+        14179 => 'SNMP::Info::Layer2::Airespace',
         14525 => 'SNMP::Info::Layer2::Trapeze',
+        14823 => 'SNMP::Info::Layer3::Aruba',
         14988 => 'SNMP::Info::Layer3::Mikrotik',
         17163 => 'SNMP::Info::Layer3::Steelhead',
         25506 => 'SNMP::Info::Layer3::H3C',
@@ -1512,6 +1514,7 @@ sub device_type {
         171   => 'SNMP::Info::Layer3::Dell',
         207   => 'SNMP::Info::Layer2::Allied',
         674   => 'SNMP::Info::Layer3::Dell',
+        890   => 'SNMP::Info::Layer2::ZyXEL_DSLAM',
         1872  => 'SNMP::Info::Layer3::AlteonAD',
         1916  => 'SNMP::Info::Layer3::Extreme',
         1991  => 'SNMP::Info::Layer3::Foundry',
@@ -1530,6 +1533,10 @@ sub device_type {
         26543 => 'SNMP::Info::Layer3::IBMGbTor',
     );
 
+    my %l1sysoidmap = (
+        2925  => 'SNMP::Info::Layer1::Cyclades',
+    );
+
     my %l7sysoidmap = (
         318   => 'SNMP::Info::Layer7::APC',
         5951  => 'SNMP::Info::Layer7::Netscaler',
@@ -1647,6 +1654,20 @@ sub device_type {
             if ($desc =~ /\b(C1100|C1130|C1140|AP1200|C350|C1200|C1240|C1250)\b/
             and $desc =~ /\bIOS\b/ );
 
+        # Airespace (WLC) Module
+        $objtype = 'SNMP::Info::Layer2::Airespace'
+            if ( $desc =~ /^Cisco Controller$/ );
+
+        #Nortel 2270
+        $objtype = 'SNMP::Info::Layer2::N2270'
+            if (
+            $desc =~ /Nortel\s+(Networks\s+)??WLAN\s+-\s+Security\s+Switch/ );
+
+        # Nortel (Trapeze) WSS 2300 Series
+        $objtype = 'SNMP::Info::Layer2::NWSS2300'    
+            if (
+            $desc =~ /^(Nortel\s)??Wireless\sSecurity\sSwitch\s23[568][012]\b/);
+
         # Generic device classification based upon sysObjectID
         if (    ( $objtype eq 'SNMP::Info::Layer3' )
             and ( defined($id) )
@@ -1664,6 +1685,18 @@ sub device_type {
 
         # Device Type Overrides
 
+        #  Bay Hub (Needed here for layers override)
+        $objtype = 'SNMP::Info::Layer1::Bayhub'
+            if ( $desc =~ /\bNMM.*Agent/ );
+        $objtype = 'SNMP::Info::Layer1::Bayhub'
+            if ( $desc =~ /\bBay\s*Stack.*Hub/i );
+
+        #  Synoptics Hub (Needed here for layers override)
+        #  This will override Bay Hub only for specific devices supported
+        #  by this class
+        $objtype = 'SNMP::Info::Layer1::S3000'
+            if ( $desc =~ /\bNMM\s+(281|3000|3030)/i );
+
         #   Catalyst 1900 series override
         $objtype = 'SNMP::Info::Layer2::C1900'
             if ( $desc =~ /catalyst/i and $desc =~ /\D19\d{2}/ );
@@ -1750,7 +1783,7 @@ sub device_type {
 
         # Airespace (WLC) Module
         $objtype = 'SNMP::Info::Layer2::Airespace'
-            if ( $desc =~ /Cisco Controller/ );
+            if ( $desc =~ /^Cisco Controller$/ );
 
         #Nortel 2270
         $objtype = 'SNMP::Info::Layer2::N2270'
@@ -1784,12 +1817,20 @@ sub device_type {
             if ( $desc =~ /\bBay\s*Stack.*Hub/i );
 
         #  Synoptics Hub
-        #  This will override Bay Hub only for specific devices supported by this class
+        #  This will override Bay Hub only for specific devices supported
+        #  by this class
         $objtype = 'SNMP::Info::Layer1::S3000'
             if ( $desc =~ /\bNMM\s+(281|3000|3030)/i );
 
-        # These devices don't claim to have Layer1-3 but we like em anyways.
+        # Generic device classification based upon sysObjectID
+        if (    ( $objtype eq 'SNMP::Info::Layer1' )
+            and ( defined($id) )
+            and ( exists( $l1sysoidmap{$id} ) ) )
+        {
+            $objtype = $l1sysoidmap{$id};
+        }
     }
+    # These devices don't claim to have Layer1-3 but we like em anyways.
     else {
         $objtype = 'SNMP::Info::Layer2::ZyXEL_DSLAM'
             if ( $desc =~ /8-port .DSL Module\(Annex .\)/i );
@@ -1816,7 +1857,8 @@ sub device_type {
 
         # Nortel (Trapeze) WSS 2300 Series
         $objtype = 'SNMP::Info::Layer2::NWSS2300'    
-            if ( $desc =~ /\bWireless\sSecurity\sSwitch\s23[568][012]\b/);
+            if (
+            $desc =~ /^(Nortel\s)??Wireless\sSecurity\sSwitch\s23[568][012]\b/);
 
         # Generic device classification based upon sysObjectID
         if ( defined($id) and $objtype eq 'SNMP::Info') {