135/snmp-info
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Layer1::Asante test class

Browse Source 
Fix logic in Layer1::Asante i_up() method
Don't end a subroutine with a conditional block
This commit is contained in:
Eric A. Miller
2018-03-30 17:11:22 -04:00
parent 125f02b8a2
commit 398f3ee74b
2 changed files with 182 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/SNMP/Info/Layer1/Asante.pm
View File

@@ -84,6 +84,7 @@ sub os_ver {
if ( $descr =~ /software v(\d+\.\d+)/ ) {
return $1;
}
return;
}
sub vendor {
@@ -94,7 +95,7 @@ sub model {
my $asante = shift;
my $id = $asante->id();
my $model = &SNMP::translateObj($id);
my $model = SNMP::translateObj($id);
return $model;
}
@@ -108,8 +109,8 @@ sub i_up {
my $i_up = {};
foreach my $port ( keys %$asante_up ) {
my $up = $asante_up->{$port};
$i_up->{$port} = 'down' if $up =~ /on/;
$i_up->{$port} = 'up' if $up =~ /off/;
$i_up->{$port} = 'down' if $up =~ /off/;
$i_up->{$port} = 'up' if $up =~ /on/;
}
return $i_up;
@@ -149,7 +150,7 @@ sub i_name {
my $asante = shift;
my $partial = shift;
my $i_name = $asante->orig_i_descr($partial) || {};
my $i_name = $asante->orig_i_description($partial) || {};
my %i_name;