135/snmp-info
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

documentation overhaul (#353)

Browse Source 
* ident
* remove $Id$ tags from rcs software which has been retired
* make an effort to sync required mib docs with actual code
* sync even more docs with what code actually does
* some whitespace nits
* fixup example to use snmpv2 for all but the most ancient devices
* remove blurb to find more specific snmp::info classes for classes
  which alrdy are as specific as they can get (eg snmp::info::layer3::vmware
  doesn't need info on to find a specific module since there ain't none)
* rename all sub {vendor} strings to lowercase vendor, if cisco, juniper
  and arista can be lowercase, so can be all the rest.
* fix tests
* spread some use warnings around
* use $ instead of @
* remove defines that are included via parent classes
* use strict + warnings
* remove alrdy included modules
* add comma after last list item
* typos
* mibs are found in our mib repo, not on the cisco site
* documentation fixes
This commit is contained in:
nick n
2019-08-25 06:47:10 +02:00
committed by GitHub
parent 6c8d39d746
commit 3bcc522590
149 changed files with 630 additions and 1168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/SNMP/Info/Bridge.pm
View File

@@ -1,5 +1,4 @@
# SNMP::Info::Bridge
# $Id$
#
# Changes since Version 0.7 Copyright (c) 2004 Max Baker
# All rights reserved.
@@ -34,6 +33,7 @@
package SNMP::Info::Bridge;
use strict;
use warnings;
use Exporter;
use SNMP::Info;
@@ -296,11 +296,11 @@ sub i_stp_port {
my %i_stp_port;
foreach my $index ( keys %$stp_p_port ) {
my $bridge = $stp_p_port->{$index};
my $bport = $stp_p_port->{$index};
my $iid = $bp_index->{$index};
next unless defined $iid;
next unless defined $bridge;
$i_stp_port{$iid} = $bridge;
next unless defined $bport;
$i_stp_port{$iid} = $bport;
}
return \%i_stp_port;
}
@@ -315,11 +315,11 @@ sub i_stp_id {
my %i_stp_id;
foreach my $index ( keys %$stp_p_id ) {
my $bridge = $stp_p_id->{$index};
my $bport = $stp_p_id->{$index};
my $iid = $bp_index->{$index};
next unless defined $iid;
next unless defined $bridge;
$i_stp_id{$iid} = $bridge;
next unless defined $bport;
$i_stp_id{$iid} = $bport;
}
return \%i_stp_id;
}
@@ -334,11 +334,11 @@ sub i_stp_bridge {
my %i_stp_bridge;
foreach my $index ( keys %$stp_p_bridge ) {
my $bridge = $stp_p_bridge->{$index};
my $bport = $stp_p_bridge->{$index};
my $iid = $bp_index->{$index};
next unless defined $iid;
next unless defined $bridge;
$i_stp_bridge{$iid} = $bridge;
next unless defined $bport;
$i_stp_bridge{$iid} = $bport;
}
return \%i_stp_bridge;
}
@@ -609,12 +609,11 @@ None.
=item F<Q-BRIDGE-MIB>
=item F<RSTP-MIB>
=back
F<BRIDGE-MIB> needs to be extracted from
ftp://ftp.cisco.com/pub/mibs/v1/v1.tar.gz
=head1 GLOBAL METHODS
=head1 GLOBALS
These are methods that return scalar values from SNMP