documentation overhaul (#353)

* ident
* remove $Id$ tags from rcs software which has been retired
* make an effort to sync required mib docs with actual code
* sync even more docs with what code actually does
* some whitespace nits
* fixup example to use snmpv2 for all but the most ancient devices
* remove blurb to find more specific snmp::info classes for classes
  which alrdy are as specific as they can get (eg snmp::info::layer3::vmware
  doesn't need info on to find a specific module since there ain't none)
* rename all sub {vendor} strings to lowercase vendor, if cisco, juniper
  and arista can be lowercase, so can be all the rest.
* fix tests
* spread some use warnings around
* use $ instead of @
* remove defines that are included via parent classes
* use strict + warnings
* remove alrdy included modules
* add comma after last list item
* typos
* mibs are found in our mib repo, not on the cisco site
* documentation fixes

lib/SNMP/Info/Layer3/Genua.pm

@@ -29,6 +29,7 @@
 package SNMP::Info::Layer3::Genua;
 
 use strict;
+use warnings;
 use Exporter;
 use SNMP::Info::Layer3;
 
@@ -85,14 +86,15 @@ sub model {
 
     my $genua_model = $genua->genua_model();
 
-    if ( $genua_model =~ m/GeNUA.+(GS.+?)\s/i ) {
+    if (defined $genua_model) {
+      if ($genua_model =~ m/GeNUA.+(GS.+?)\s/i) {
         $genua_model = $1;
-    }
-    elsif ( $genua_model =~ m/genua\s+(.+?)\s+/i ) {
+      }
+      elsif ($genua_model =~ m/genua\s+(.+?)\s+/i) {
         $genua_model = $1;
-    }
-    else {
-        $genua_model = 'unknown';
+      }
+    } else {
+      $genua_model = 'unknown';
     }
     return $genua_model;
 }
@@ -121,7 +123,7 @@ Netdisco Developers
                           Debug       => 1,
                           DestHost    => 'myhub',
                           Community   => 'public',
-                          Version     => 1
+                          Version     => 2
                         )
     or die "Can't connect to DestHost.\n";